Skip to content

Revert "Remove Onyx.connect() in src/libs/Navigation/AppNavigator/AuthScreens.tsx"#71901

Merged
arosiclair merged 1 commit into
mainfrom
revert-71746-refactor-505
Oct 6, 2025
Merged

Revert "Remove Onyx.connect() in src/libs/Navigation/AppNavigator/AuthScreens.tsx"#71901
arosiclair merged 1 commit into
mainfrom
revert-71746-refactor-505

Conversation

@lakchote

@lakchote lakchote commented Oct 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #71746

$ #71856
$ #71837

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@codecov

codecov Bot commented Oct 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/Navigation/AppNavigator/AuthScreens.tsx 92.30% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #71901.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/71901/index.html ⏩ SKIPPED ⏩
Android The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://71901.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@arosiclair arosiclair marked this pull request as ready for review October 6, 2025 15:50
@arosiclair arosiclair requested a review from a team as a code owner October 6, 2025 15:50
@arosiclair arosiclair merged commit 23756f2 into main Oct 6, 2025
23 of 26 checks passed
@melvin-bot melvin-bot Bot requested a review from mjasikowski October 6, 2025 15:51
@melvin-bot

melvin-bot Bot commented Oct 6, 2025

Copy link
Copy Markdown

@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot Bot removed the request for review from a team October 6, 2025 15:51
@arosiclair arosiclair deleted the revert-71746-refactor-505 branch October 6, 2025 15:51
@melvin-bot melvin-bot Bot added the Emergency label Oct 6, 2025
@melvin-bot

melvin-bot Bot commented Oct 6, 2025

Copy link
Copy Markdown

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@arosiclair

arosiclair commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

straight revert

@OSBotify

OSBotify commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Oct 6, 2025
@arosiclair @OSBotify
Merge pull request #71901 from Expensify/revert-71746-refactor-505
c2ba7bd 
Revert "Remove Onyx.connect() in src/libs/Navigation/AppNavigator/AuthScreens.tsx"

(cherry picked from commit 23756f2)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 6, 2025
@OSBotify OSBotify mentioned this pull request Oct 6, 2025
Closed
58 tasks
@OSBotify

OSBotify commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.23-3 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.23-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify

OSBotify commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 6, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.24-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.26-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

OSBotify commented Oct 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.26-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arosiclair arosiclair arosiclair approved these changes

@mjasikowski mjasikowski Awaiting requested review from mjasikowski

Assignees

@lakchote lakchote

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lakchote @arosiclair @OSBotify