Add copyable functionality to various components by ShridharGoel · Pull Request #71899 · Expensify/App

ShridharGoel · 2025-10-06T14:19:56Z

Explanation of Change

Add copyable functionality to various components.

Fixed Issues

$ #71454
PROPOSAL: #71454 (comment)

Tests

Login to any account on web/desktop.
Go to any Workspace not owned by the user
Verify that hovering over the address field shows the copy button (address shouldn't be editable).
Go to any paid report
Verify that all fields which are non-editable (read-only) should show a copy icon when hovered over.
Go to any paid distance expense
Check fields like distance, rate, date etc. whichever are in read-only mode should be copyable by hovering and clicking the copy icon.
Do the same steps on mobile. Long press should give the option to copy such read-only fields on mobile (native and mWeb).

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-10-06.at.8.34.18.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-06.at.8.36.15.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-10-06.at.20.38.48.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.16.Plus.-.2025-10-06.at.20.10.41.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-10-09.at.2.01.06.PM.mov

MacOS: Desktop

Screen.Recording.2025-10-09.at.2.10.40.PM.mov

codecov · 2025-10-06T14:35:52Z

Codecov Report

❌ Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	18 Missing ⚠️
src/pages/workspace/WorkspaceOverviewPage.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/pages/workspace/WorkspaceOverviewPage.tsx	`0.00% <0.00%> (ø)`
...c/components/ReportActionItem/MoneyRequestView.tsx	`0.29% <0.00%> (-0.01%)`	⬇️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-06T15:15:04Z

@dukenv0307 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dukenv0307 · 2025-10-08T02:58:00Z

@ShridharGoel Did you update the PR to fix the comment here?

ShridharGoel · 2025-10-08T06:54:17Z

Yes, but the videos need to be updated.

dukenv0307 · 2025-10-08T09:54:12Z

        return <ReportActionsSkeletonView />;
    }

+    function getAttendeesTitle() {


Let's use useMemo

dukenv0307 · 2025-10-08T10:01:38Z

                                onPressIn={() => shouldBlockSelection && shouldUseNarrowLayout && canUseTouchScreen() && ControlSelection.block()}
                                onPressOut={ControlSelection.unblock}
-                                onSecondaryInteraction={copyable && !deviceHasHoverSupport ? secondaryInteraction : onSecondaryInteraction}
+                                onSecondaryInteraction={copyable ? secondaryInteraction : onSecondaryInteraction}


Any reason for this change? Why don't we keep it as it is?

We should be keeping it after the latest discussion. Updated.

… into copyable

dukenv0307 · 2025-10-09T16:58:35Z

@ShridharGoel I think we can create the variable for copyValue and use !!copyValue for copyable to prevent the duplications

dukenv0307 · 2025-10-09T17:23:30Z

Can you please update the test steps with the expected behavior as well

dukenv0307 · 2025-10-09T17:28:40Z

Is it correct to enable copyable for all read-only fields?

Screen.Recording.2025-10-10.at.00.27.58.mov

ShridharGoel · 2025-10-10T06:35:35Z

Is it correct to enable copyable for all read-only fields?

@shawnborton @dannymcclain

shawnborton · 2025-10-10T07:36:54Z

I think in general, that holds up. But we are definitely going to find some cases where we might not want/need it. Can you maybe share some more examples? Or maybe it can't hurt to try it as default behavior and then we can see how it feels from there (via an adhoc build)? cc @dubielzyk-expensify too

ShridharGoel · 2025-10-10T08:06:23Z

It has been added to the following places (when they are read-only):

MoneyRequestView page:
distance, distanceRate, attendeesList, tags, amount, description, merchant, date, category, cardProgramName, taxRate, taxAmount, reportName

WorkspaceOverviewPage:
address

dannymcclain · 2025-10-10T13:05:57Z

Yeah I could see it being ok for any read-only field, but like Shawn said, we might find some that don't need it / shouldn't have it. I'd be down to try it though.

ShridharGoel · 2025-10-11T08:37:38Z

@dukenv0307 Updated.

dukenv0307 · 2025-10-12T16:48:29Z

-            selection: copyValue,
-            contextMenuAnchor: popoverAnchor.current,
-        });
+        if (!deviceHasHoverSupport) {


why do we need it?

Shouldn't be needed now, since we have restored the !deviceHasHoverSupport condition at the calling place

dukenv0307 · 2025-10-12T17:08:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-12.at.23.57.03.mov

Android: mWeb Chrome

Screen.Recording.2025-10-12.at.23.52.24.mov

iOS: HybridApp

Screen.Recording.2025-10-13.at.00.04.08.mov

iOS: mWeb Safari

Screen.Recording.2025-10-12.at.23.53.22.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-12.at.23.50.34.mov

MacOS: Desktop

Screen.Recording.2025-10-12.at.23.59.41.mov

dubielzyk-expensify · 2025-10-13T00:42:34Z

Let us know when we should run a test build 👍

ShridharGoel · 2025-10-13T07:17:48Z

@dubielzyk-expensify Yeah we can start an Adhoc build

shawnborton · 2025-10-13T07:18:50Z

Cool, I'll fire one up now.

github-actions · 2025-10-13T07:19:53Z

🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-13T07:50:37Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #71899.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/71899/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/71899/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/71899/NewExpensify.dmg	https://71899.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2025-10-13T08:05:25Z

Feels pretty good to me:

CleanShot.2025-10-13.at.10.05.02.mp4

ShridharGoel · 2025-10-13T13:01:39Z

@dukenv0307 Can you complete the review when possible?

dukenv0307 · 2025-10-15T15:16:23Z

all yours @youssef-lr

OSBotify · 2025-10-16T17:22:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-16T23:41:42Z

🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-20T09:25:30Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dukenv0307 · 2025-10-29T16:21:00Z

                        brickRoadIndicator={getErrorForField('comment') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
                        errorText={getErrorForField('comment')}
                        numberOfLinesTitle={0}
+                        copyValue={descriptionCopyValue}


Coming from #72826, descriptionCopyValue should be converted from html to text

Add copyable functionality to various components

dbb3ee0

melvin-bot Bot assigned ShridharGoel Oct 6, 2025

Lint fixes

2611443

ShridharGoel marked this pull request as ready for review October 6, 2025 15:14

ShridharGoel requested a review from a team as a code owner October 6, 2025 15:14

melvin-bot Bot requested review from dukenv0307 and removed request for a team October 6, 2025 15:15

ShridharGoel added 3 commits October 7, 2025 15:32

Updates

1dff061

Prettier fix

fa5d21b

Merge branch 'main' into copyable

4a5aa8f

dukenv0307 reviewed Oct 8, 2025

View reviewed changes

ShridharGoel added 3 commits October 9, 2025 14:01

Updates

dcf2153

Merge branch 'copyable' of https://github.com/ShridharGoel/ExpensifyApp…

e269343

… into copyable

Lint and prettier fixes

89dbbeb

Use common variables for copyValue and copyable

a5dd73b

dukenv0307 reviewed Oct 12, 2025

View reviewed changes

ShridharGoel added 2 commits October 12, 2025 23:55

Update

d8d53a8

Merge branch 'main' of https://github.com/Expensify/App into copyable

8d77093

dukenv0307 approved these changes Oct 13, 2025

View reviewed changes

melvin-bot Bot requested a review from youssef-lr October 13, 2025 14:55

ShridharGoel added 2 commits October 13, 2025 20:30

Merge branch 'main' into copyable

17c65df

Update

2713b51

youssef-lr approved these changes Oct 16, 2025

View reviewed changes

youssef-lr merged commit 609de88 into Expensify:main Oct 16, 2025
20 checks passed

OSBotify mentioned this pull request Oct 16, 2025

Deploy Checklist: New Expensify 2025-10-16 #72816

Closed

67 tasks

mitarachim mentioned this pull request Oct 17, 2025

[Due for payment 2025-10-30] [$250] Expense - Description with mark down is copied with HTML tags #72826

Closed

8 tasks

melvin-bot Bot mentioned this pull request Oct 20, 2025

[Awaiting checklist completion] [$250] Web - Instances are not copiable using the right click #71454

Closed

8 tasks

dukenv0307 reviewed Oct 29, 2025

View reviewed changes

Conversation

ShridharGoel commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 6, 2025

Uh oh!

dukenv0307 commented Oct 8, 2025

Uh oh!

ShridharGoel commented Oct 8, 2025

Uh oh!

dukenv0307 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Oct 9, 2025

Uh oh!

dukenv0307 commented Oct 9, 2025

Uh oh!

dukenv0307 commented Oct 9, 2025

Uh oh!

ShridharGoel commented Oct 10, 2025

Uh oh!

shawnborton commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShridharGoel commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dannymcclain commented Oct 10, 2025

Uh oh!

ShridharGoel commented Oct 11, 2025

Uh oh!

dukenv0307 Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

ShridharGoel Oct 12, 2025

Choose a reason for hiding this comment

Uh oh!

dukenv0307 commented Oct 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dubielzyk-expensify commented Oct 13, 2025

Uh oh!

ShridharGoel commented Oct 13, 2025

Uh oh!

shawnborton commented Oct 13, 2025

Uh oh!

github-actions Bot commented Oct 13, 2025

Uh oh!

github-actions Bot commented Oct 13, 2025

Uh oh!

shawnborton commented Oct 13, 2025

Uh oh!

ShridharGoel commented Oct 13, 2025

Uh oh!

dukenv0307 commented Oct 15, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

ShridharGoel commented Oct 6, 2025 •

edited

Loading

codecov Bot commented Oct 6, 2025 •

edited

Loading

shawnborton commented Oct 10, 2025 •

edited

Loading

ShridharGoel commented Oct 10, 2025 •

edited

Loading