fix: Paid with bank account system message has different content when copied by etCoderDysto · Pull Request #71883 · Expensify/App

etCoderDysto · 2025-10-06T09:30:11Z

Explanation of Change

Fixed Issues

$ #71287
PROPOSAL: #71287 (comment)

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Precondition:

Admin invites member to workspace.
Workspace is set up with business bank account.
Member has personal bank account.

Go to staging.new.expensify.com
[Member] Go to workspace chat and create an expense over $100.
[Member] Click Submit on the expense preview.
[Admin] Open the expense report.
[Admin] Click Approve and Pay with business account.
[Admin] Right click on "paid with bank account 1111" system message > Copy to clipboard.
[Admin] Paste the content.
Verify that copied content matches with the system message

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.Screen.Recording.2025-10-06.at.12.00.51.in.the.afternoon.mp4

Android: mWeb Chrome

android.web.Screen.Recording.2025-10-06.at.12.05.18.in.the.afternoon.mp4

iOS: Native

ios.Screen.Recording.2025-10-06.at.12.11.15.in.the.afternoon.mp4

iOS: mWeb Safari

ios.safariScreen.Recording.2025-10-06.at.12.15.12.in.the.afternoon.mp4

MacOS: Chrome / Safari

web.Screen.Recording.2025-10-06.at.11.58.04.in.the.morning.mp4

MacOS: Desktop

desktop.Screen.Recording.2025-10-06.at.12.22.06.in.the.afternoon.mp4

codecov · 2025-10-06T09:40:48Z

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/ReportUtils.ts	20.00%	4 Missing ⚠️
...ges/home/report/ContextMenu/ContextMenuActions.tsx	0.00%	1 Missing ⚠️
src/pages/home/report/PureReportActionItem.tsx	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.92% <0.00%> (ø)`
src/pages/home/report/PureReportActionItem.tsx	`51.50% <0.00%> (ø)`
src/libs/ReportUtils.ts	`74.26% <20.00%> (+0.31%)`	⬆️

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-06T09:53:00Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

etCoderDysto · 2025-10-06T12:16:20Z

@ishpaul777 the copied message is capitalized. Should we change the copy?

Action message

paid with bank account 0000

System message

Paid with bank account 0000

ishpaul777 · 2025-10-06T15:12:09Z

have you checked other usage of the translationkey at other places, do they need to be small cased also? if no then i think we should apply change specifically for this case not all usages @etCoderDysto

ishpaul777 · 2025-10-07T16:52:08Z

bump @etCoderDysto

etCoderDysto · 2025-10-07T18:33:48Z

@ishpaul777

We are using the copy in getReportName but it shouldn't be capitalized. It makes the report title inconsistent with the system message. Other system message as submit are consistent for report title

App/src/libs/ReportUtils.ts

Line 5389 in 6663672

return translateLocal('iou.businessBankAccount', {last4Digits});

We are using the copy in getReportPreviewMessage. One of the places we use getReportPreviewMessage is in ContextMenuActions to copy the system message when user right click expense preview > tap copy to clipboard. In that case we should change the copy to small letter to make it consistent with system message

App/src/libs/ReportUtils.ts

Line 4846 in 6663672

translatePhraseKey = 'iou.businessBankAccount';
We are already changing the copy to lower case for ReportActionItemBasicMessage

App/src/pages/home/report/PureReportActionItem.tsx

Line 1165 in 6663672

children = <ReportActionItemBasicMessage message={translate('iou.businessBankAccount', {amount: '', last4Digits})?.toLowerCase()} />;

I think it is safe to change to the copy to small letter. I will investigate this more tomorrow and make an update.

etCoderDysto · 2025-10-07T18:38:10Z

@ishpaul777 I have found a bug. Wrong content is copied when copying an expense report preview that is paid with bank account

Pay an expense with bank account
Right click the expense preview
Copy to clipboard
Past the content

Copied message should be: paid with bank account 1111

Screen.Recording.2025-10-07.at.9.34.31.at.night.mov

ishpaul777 · 2025-10-07T19:58:16Z

can you please investigate ^, to see if we can fix this here if its a easy fix?

etCoderDysto · 2025-10-08T08:09:56Z

2. App/src/libs/ReportUtils.ts

@ishpaul777 I think we can change the original copy to small letter. I didn't find any reason that we shouldn't change it to small letter. If we are changing the english copy to small letter are we also changing all languages to small letter?

ishpaul777 · 2025-10-08T11:10:53Z

If we are changing the english copy to small letter are we also changing all languages to small letter?

yes i beleive so

etCoderDysto · 2025-10-08T11:44:00Z

can you please investigate ^, to see if we can fix this here if its a easy fix?

For this issue, we call getReportPreviewMessage to get the content to be copied passing it a reportAction with actionName = REPORTPREVIEW

App/src/pages/home/report/ContextMenu/ContextMenuActions.tsx

Line 515 in 52e92f7

const displayMessage = getReportPreviewMessage(iouReportID, reportAction);

And originalMessage will be undefined since the reportAction is not money request reportAction

App/src/libs/ReportUtils.ts

Lines 4827 to 4847 in 52e92f7

    
           const originalMessage = !isEmptyObject(iouReportAction) && isMoneyRequestAction(iouReportAction) ? getOriginalMessage(iouReportAction) : undefined; 
        
           // Show Paid preview message if it's settled or if the amount is paid & stuck at receivers end for only chat reports. 
        
           if (isSettled(report.reportID) || (report.isWaitingOnBankAccount && isPreviewMessageForParentChatReport)) { 
        
               // A settled report preview message can come in three formats "paid ... elsewhere" or "paid ... with Expensify" 
        
               let translatePhraseKey: TranslationPaths = 'iou.paidElsewhere'; 
        
               if (isPreviewMessageForParentChatReport) { 
        
                   translatePhraseKey = 'iou.payerPaidAmount'; 
        
               } else if ( 
        
                   [CONST.IOU.PAYMENT_TYPE.VBBA, CONST.IOU.PAYMENT_TYPE.EXPENSIFY].some((paymentType) => paymentType === originalMessage?.paymentType) || 
        
                   !!reportActionMessage.match(/ (with Expensify|using Expensify)$/) || 
        
                   report.isWaitingOnBankAccount 
        
               ) { 
        
                   translatePhraseKey = 'iou.paidWithExpensify'; 
        
                   if (originalMessage?.automaticAction) { 
        
                       translatePhraseKey = 'iou.automaticallyPaidWithExpensify'; 
        
                   } 
        
                   if (originalMessage?.paymentType === CONST.IOU.PAYMENT_TYPE.VBBA) { 
        
                       translatePhraseKey = 'iou.businessBankAccount'; 
        
                   }

And we will use iou.paidWithExpensify key for copied content.

I think we have to find a way to a pass the right IOU action type to iouReportAction prop of getReportPreviewMessage to fix the issue

App/src/libs/ReportUtils.ts

Lines 4723 to 4731 in 52e92f7

    
            * @param [iouReportAction] This is always an IOU action. When necessary, report preview actions will be unwrapped and the child iou report action is passed here (the original report preview 
        
            *     action will be passed as `originalReportAction` in this case). 
        
            * @param [originalReportAction] This can be either a report preview action or the IOU action. This will be the original report preview action in cases where `iouReportAction` was unwrapped 
        
            *     from a report preview action. Otherwise, it will be the same as `iouReportAction`. 
        
            */ 
        
           function getReportPreviewMessage( 
        
               reportOrID: OnyxInputOrEntry<Report> | string, 
        
               iouReportAction: OnyxInputOrEntry<ReportAction> = null, 
        
               shouldConsiderScanningReceiptOrPendingRoute = false,

IMO, it is not an easy fix.

ishpaul777 · 2025-10-08T12:18:23Z

thanks for investigation @etCoderDysto, i'll report it in slack so we have a GH ticket for it!

etCoderDysto · 2025-10-08T12:56:47Z

thanks for investigation @etCoderDysto, i'll report it in slack so we have a GH ticket for it!

Great! No problem!

I have changed the translation copies to a lower case

ishpaul777 · 2025-10-08T22:29:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-09.at.3.40.21.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-09.at.3.42.00.AM.mov

iOS: HybridApp

Screen.Recording.2025-10-09.at.3.28.43.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-10-09.at.3.30.19.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-09.at.3.17.47.AM.mov

MacOS: Desktop

Screen.Recording.2025-10-09.at.3.48.20.AM.mov

NikkiWines

sorry for the delay! couple very small things

NikkiWines · 2025-10-10T10:56:48Z

+
+        const iouReport = {...createExpenseReport(Number(iouReportID)), policyID: policyID.toString()};
+
+        const policy54 = {


Why add 54?

Suggested change

const policy54 = {

const policy = {

There is an existing policy variable declaration in the outer scope, and it was showing lint error. That is why I named it policy54, but now I have changed the name to policyWithBank to give the name better clarity.

NikkiWines

Looks good! @etCoderDysto could you merge main and then this should be good to go!

etCoderDysto · 2025-10-13T12:06:03Z

Looks good! @etCoderDysto could you merge main and then this should be good to go!

Great! I have merged main @NikkiWines

NikkiWines

OSBotify · 2025-10-13T13:10:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T21:20:51Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:35:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix copied system message content for pay with bank

e3448c5

melvin-bot Bot assigned etCoderDysto Oct 6, 2025

etCoderDysto marked this pull request as ready for review October 6, 2025 09:52

etCoderDysto requested a review from a team as a code owner October 6, 2025 09:52

melvin-bot Bot requested review from ishpaul777 and removed request for a team October 6, 2025 09:52

add test for getIOUReportActionDisplayMessage

8a65b81

etCoderDysto added 2 commits October 8, 2025 15:46

change the first letter in Paid with bank message to small letter

c84d100

Remove unnecessary toLowerCase call on an already lowercase copy

f3f79c2

ishpaul777 approved these changes Oct 8, 2025

View reviewed changes

melvin-bot Bot requested a review from NikkiWines October 8, 2025 22:34

NikkiWines requested changes Oct 10, 2025

View reviewed changes

use translation copy directly in translateLocal call

02d3234

NikkiWines requested changes Oct 13, 2025

View reviewed changes

Merge branch 'main' into fix_71287

6735816

NikkiWines approved these changes Oct 13, 2025

View reviewed changes

NikkiWines merged commit c58b8c1 into Expensify:main Oct 13, 2025
21 checks passed

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-13 #72503

Closed

92 tasks

melvin-bot Bot mentioned this pull request Oct 14, 2025

[Due for payment 2025-10-21] [$250] Expense - Paid with bank account system message has different content when copied #71287

Closed

8 tasks


		const iouReport = {...createExpenseReport(Number(iouReportID)), policyID: policyID.toString()};

		const policy54 = {

Uh oh!

Conversation

etCoderDysto commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 6, 2025

Uh oh!

etCoderDysto commented Oct 6, 2025

Uh oh!

ishpaul777 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ishpaul777 commented Oct 7, 2025

Uh oh!

etCoderDysto commented Oct 7, 2025

Uh oh!

etCoderDysto commented Oct 7, 2025

Uh oh!

ishpaul777 commented Oct 7, 2025

Uh oh!

etCoderDysto commented Oct 8, 2025

Uh oh!

ishpaul777 commented Oct 8, 2025

Uh oh!

etCoderDysto commented Oct 8, 2025

Uh oh!

ishpaul777 commented Oct 8, 2025

Uh oh!

etCoderDysto commented Oct 8, 2025

Uh oh!

ishpaul777 commented Oct 8, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NikkiWines Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

etCoderDysto Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

etCoderDysto commented Oct 13, 2025

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

etCoderDysto commented Oct 6, 2025 •

edited

Loading

codecov Bot commented Oct 6, 2025 •

edited

Loading

ishpaul777 commented Oct 6, 2025 •

edited

Loading