fix: missing Create expense options by nkdengineer · Pull Request #71871 · Expensify/App

nkdengineer · 2025-10-06T03:30:29Z

Explanation of Change

Fixed Issues

$ #71635
PROPOSAL: #71635 (comment)

Tests

Precondition:

User A and User B have not chatted with each other before.

Go to staging.new.expensify.com
[User A] Open FAB > Create expense > Manual.
[User A] Send a manual expense to User B.
[User B] Open 1:1 DM with User A from LHN. Do not open expense report.
[User B] Click + menu.
Verify that: Create expense options will be shown.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-mweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

codecov · 2025-10-06T03:41:14Z

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/SidebarUtils.ts	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/SidebarUtils.ts	`80.04% <0.00%> (ø)`

... and 69 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-06T16:34:50Z

@rojiphil Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rojiphil · 2025-10-08T15:12:51Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

71871-android-hybrid-001.mp4

Android: mWeb Chrome

71871-mweb-chrome-001.mp4

iOS: HybridApp

71871-ios-hybrid-001.mp4

iOS: mWeb Safari

71871-mweb-safari-001.mp4

MacOS: Chrome / Safari

71871-web-chrome-001.mp4

MacOS: Desktop

71871-desktop-001.mp4

rojiphil

Thanks @nkdengineer for the PR.
Changes work well
Please also add a unit test as mentioned here

nkdengineer · 2025-10-13T09:28:34Z

@rojiphil Updated.

nkdengineer · 2025-10-13T09:29:02Z

the fail worker is unrelated

rojiphil · 2025-10-13T13:38:07Z

            expect(getOptionRows()).toHaveLength(0);
        });
+
+        it('display the report with last action is report preview will not change the current user personal detail', async () => {


Thanks @nkdengineer for adding the unit test. Just one comment though.
The explanation does not seem correctly written. Also, can we start with should?

@rojiphil Updated.

rojiphil

Thanks @nkdengineer for the changes.

@neil-marcellini Changes LGTM. Works well too.
All yours. Thanks.

neil-marcellini

Overall, looks good, thank you. None of the comments I left are blockers, but please fix them either before we merge here or with a follow-up pull request.

neil-marcellini · 2025-10-13T16:49:07Z

    // to ensures that lastActorDetails.accountID is correctly set in case it's empty string
    if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && lastActorDetails) {
-        lastActorDetails.accountID = lastAction.actorAccountID;
+        lastActorDetails = {


Not a blocker, but please add a comment explaining why it's important to create a copy of the object.

neil-marcellini · 2025-10-13T16:51:07Z

            expect(getOptionRows()).toHaveLength(0);
        });
+
+        it('should not change the current user personal detail when a report with last action is REPORTPREVIEW is displayed', async () => {


Let's switch to when a report is displayed where the last action is REPORTPREVIEW. I think that's slightly more clear.

neil-marcellini · 2025-10-13T16:53:04Z

+                ...createReport(undefined, [1, 2], undefined, undefined, undefined, true),
+                lastActorAccountID: 1,
+                lastMessageText: '123456',
+            };
+
+            const lastReportAction: ReportAction = {
+                ...createRandomReportAction(2),
+                actionName: 'REPORTPREVIEW',
+                actorAccountID: 2,


NAB: Can we please create variables to give names to these IDs? I think that makes it a lot more clear. For example, something like setting the last actor account ID to submitterAccountID vs 1.

neil-marcellini · 2025-10-13T16:53:52Z

+
+            await waitForBatchedUpdatesWithAct();
+
+            const personalDetail = await getOnyxValue(ONYXKEYS.PERSONAL_DETAILS_LIST);


NAB: You verified that this fails without your fix, right?

neil-marcellini · 2025-10-13T16:57:12Z

Ok I will go ahead and merge, please create a follow up PR when you get a chance @nkdengineer

OSBotify · 2025-10-13T17:08:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T21:20:48Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:35:14Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

hungvu193 · 2025-11-14T09:35:38Z

    if (lastAction?.actionName === CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW && lastActorDetails) {
-        lastActorDetails.accountID = lastAction.actorAccountID;
+        lastActorDetails = {
+            ...lastActorDetails,
+            accountID: lastAction.actorAccountID,
+        };


We ended up removing this piece of code in #73220

More details:
#73220 (comment)

fix: missing Create expense options

cd001af

melvin-bot Bot assigned nkdengineer Oct 6, 2025

nkdengineer marked this pull request as ready for review October 6, 2025 16:34

nkdengineer requested a review from a team as a code owner October 6, 2025 16:34

melvin-bot Bot requested review from rojiphil and removed request for a team October 6, 2025 16:34

rojiphil reviewed Oct 8, 2025

View reviewed changes

nkdengineer added 2 commits October 13, 2025 15:40

Merge branch 'main' into fix/71635

7123259

add unit test

750b7ae

nkdengineer force-pushed the fix/71635 branch from 5c91e57 to 750b7ae Compare October 13, 2025 09:10

rojiphil reviewed Oct 13, 2025

View reviewed changes

change test name

10aaedb

rojiphil approved these changes Oct 13, 2025

View reviewed changes

melvin-bot Bot requested a review from neil-marcellini October 13, 2025 16:10

neil-marcellini approved these changes Oct 13, 2025

View reviewed changes

neil-marcellini merged commit 57c4e99 into Expensify:main Oct 13, 2025
28 checks passed

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-13 #72503

Closed

92 tasks

dmkt9 mentioned this pull request Oct 14, 2025

[$250] Full story : Duplicate member shown in Members list with different roles/permissions #72095

Closed

16 tasks

hungvu193 mentioned this pull request Oct 27, 2025

[$250] When submits an expense to User B, the last message as current user is "You: (User B's name) owes (amount)" #73220

Closed

16 tasks

hungvu193 reviewed Nov 14, 2025

View reviewed changes


		await waitForBatchedUpdatesWithAct();

		const personalDetail = await getOnyxValue(ONYXKEYS.PERSONAL_DETAILS_LIST);

Uh oh!

Conversation

nkdengineer commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 6, 2025

Uh oh!

rojiphil commented Oct 8, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

nkdengineer commented Oct 13, 2025

Uh oh!

nkdengineer commented Oct 13, 2025

Uh oh!

rojiphil Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

nkdengineer Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

rojiphil left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini left a comment

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

neil-marcellini commented Oct 13, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

hungvu193 Nov 14, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nkdengineer commented Oct 6, 2025 •

edited

Loading

codecov Bot commented Oct 6, 2025 •

edited

Loading