Skip to content

Fix LHN tooltip hover inconsistency after scrolling #71867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosmiceli merged 1 commit into from
Oct 8, 2025
Merged

Fix LHN tooltip hover inconsistency after scrolling #71867

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/components/Tooltip/EducationalTooltip/BaseEducationalTooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ import measureTooltipCoordinate, {getTooltipCoordinates} from './measureTooltipC

type LayoutChangeEventWithTarget = NativeSyntheticEvent<{layout: LayoutRectangle; target: HTMLElement}>;

type ScrollingEventData = {
isScrolling: boolean;
};
/**
* A component used to wrap an element intended for displaying a tooltip.
* This tooltip would show immediately without user's interaction and hide after 5 seconds.
Expand Down Expand Up @@ -109,7 +106,7 @@ function BaseEducationalTooltip({children, shouldRender = false, shouldHideOnNav
}

setTooltipPosition(false);
const scrollingListener = DeviceEventEmitter.addListener(CONST.EVENTS.SCROLLING, ({isScrolling}: ScrollingEventData = {isScrolling: false}) => {
const scrollingListener = DeviceEventEmitter.addListener(CONST.EVENTS.SCROLLING, (isScrolling: boolean) => {
setTooltipPosition(isScrolling);
});

Expand Down
4 changes: 1 addition & 3 deletions src/hooks/useScrollEventEmitter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ const useScrollEventEmitter = () => {

const triggerScrollEvent = useCallback(() => {
const emitScrolling = (isScrolling: boolean) => {
DeviceEventEmitter.emit(CONST.EVENTS.SCROLLING, {
isScrolling,
});
DeviceEventEmitter.emit(CONST.EVENTS.SCROLLING, isScrolling);
};

// Start emitting the scrolling event when the scroll begins
Expand Down
Loading