[No QA] ReportNextStep: New format #71855
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -144,6 +144,7 @@ import type { | |
| MovedTransactionParams, | ||
| NeedCategoryForExportToIntegrationParams, | ||
| NewWorkspaceNameParams, | ||
| NextStepParams, | ||
| NoLongerHaveAccessParams, | ||
| NotAllowedExtensionParams, | ||
| NotYouParams, | ||
|
|
@@ -1552,6 +1553,118 @@ const translations = { | |
| modal: { | ||
| backdropLabel: 'Modal Backdrop', | ||
| }, | ||
| nextStep: { | ||
| message: { | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_ADD_TRANSACTIONS]: ({actor, actorType}: NextStepParams) => { | ||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>you</strong> to add expenses.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}</strong> to add expenses.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin to add expenses.`; | ||
| } | ||
| }, | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.NO_FURTHER_ACTION]: (_: NextStepParams) => `No further action required!`, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_SUBMITTER_ACCOUNT]: ({actor, actorType}: NextStepParams) => { | ||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>you</strong> to add a bank account.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}</strong> to add a bank account.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin to add a bank account.`; | ||
| } | ||
| }, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_AUTOMATIC_SUBMIT]: ({actor, actorType, eta, etaType}: NextStepParams) => { | ||
| let formattedETA = ''; | ||
| if (eta) { | ||
| formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` on ${eta}` : ` ${eta}`; | ||
| } | ||
|
|
||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>your</strong> expenses to automatically submit${formattedETA}.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}'s</strong> expenses to automatically submit${formattedETA}.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin's expenses to automatically submit${formattedETA}.`; | ||
|
Comment on lines
+1593
to
+1598
Contributor
There was a problem hiding this comment. @jamesdeanexpensify since you've been working on these lately - is this the message we want in ND? Or should it just be |
||
| } | ||
| }, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_FIX_ISSUES]: ({actor, actorType}: NextStepParams) => { | ||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>you</strong> to fix the issue(s).`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}</strong> to fix the issue(s).`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin to fix the issue(s).`; | ||
| } | ||
| }, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_APPROVE]: ({actor, actorType}: NextStepParams) => { | ||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>you</strong> to approve expenses.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}</strong> to approve expenses.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin to approve expenses.`; | ||
| } | ||
| }, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_TO_PAY]: ({actor, actorType}: NextStepParams) => { | ||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>you</strong> to pay expenses.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}</strong> to pay expenses.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin to pay expenses.`; | ||
| } | ||
| }, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_POLICY_BANK_ACCOUNT]: ({actor, actorType}: NextStepParams) => { | ||
| // Disabling the default-case lint rule here is actually safer as this forces us to make the switch cases exhaustive | ||
| // eslint-disable-next-line default-case | ||
| switch (actorType) { | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.CURRENT_USER: | ||
| return `Waiting for <strong>you</strong> to finish setting up a business bank account.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.OTHER_USER: | ||
| return `Waiting for <strong>${actor}</strong> to finish setting up a business bank account.`; | ||
| case CONST.NEXT_STEP.ACTOR_TYPE.UNSPECIFIED_ADMIN: | ||
| return `Waiting for an admin to finish setting up a business bank account.`; | ||
| } | ||
| }, | ||
| [CONST.NEXT_STEP.MESSAGE_KEY.WAITING_FOR_PAYMENT]: ({eta, etaType}: NextStepParams) => { | ||
| let formattedETA = ''; | ||
| if (eta) { | ||
| formattedETA = etaType === CONST.NEXT_STEP.ETA_TYPE.DATE_TIME ? ` by ${eta}` : ` ${eta}`; | ||
| } | ||
|
|
||
| return `Waiting for payment to complete${formattedETA}.`; | ||
| }, | ||
| }, | ||
| eta: { | ||
| [CONST.NEXT_STEP.ETA_KEY.SHORTLY]: 'shortly', | ||
| [CONST.NEXT_STEP.ETA_KEY.TODAY]: 'later today', | ||
| [CONST.NEXT_STEP.ETA_KEY.END_OF_WEEK]: 'on Sunday', | ||
| [CONST.NEXT_STEP.ETA_KEY.SEMI_MONTHLY]: 'on the 1st and 16th of each month', | ||
| [CONST.NEXT_STEP.ETA_KEY.LAST_BUSINESS_DAY_OF_MONTH]: 'on the last business day of the month', | ||
| [CONST.NEXT_STEP.ETA_KEY.LAST_DAY_OF_MONTH]: 'on the last day of the month', | ||
| [CONST.NEXT_STEP.ETA_KEY.END_OF_TRIP]: 'at the end of your trip', | ||
| }, | ||
| }, | ||
| profilePage: { | ||
| profile: 'Profile', | ||
| preferredPronouns: 'Preferred pronouns', | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can add other languages together in this PR.
Edited: it seems bot can automatically generate translations, see slack