Feature: Automatically create Markdown links when pasting a link on highlighted text by marufsharifi · Pull Request #71819 · Expensify/App

marufsharifi · 2025-10-03T15:45:34Z

Explanation of Change

Fixed Issues

$ #70901
PROPOSAL: (#70901 comment)

Tests

Open the app
Open any chat
Type a sentence
Select some of the words or all of them
Paste a valid URL
The selected part should automatically change into a markdown link

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.1404-07-13.at.12.28.34.AM.mov

Android: mWeb Chrome

Screen.Recording.1404-07-13.at.12.29.34.AM.mov

iOS: Native

Screen.Recording.1404-07-13.at.12.24.15.AM.mov

iOS: mWeb Safari

Screen.Recording.1404-07-13.at.12.25.28.AM.mov

MacOS: Chrome / Safari

Screen.Recording.1404-07-13.at.12.21.27.AM.mov

MacOS: Desktop

Screen.Recording.1404-07-13.at.12.32.20.AM.mov

…ighlighted text

…and useHtmlPaste

melvin-bot · 2025-10-07T18:42:40Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2025-10-08T07:47:13Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-hybrid.mp4

Android: mWeb Chrome

android-mweb.mp4

iOS: HybridApp

ios-hybrid.mov

iOS: mWeb Safari

ios-mweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

ikevin127 · 2025-10-08T18:57:28Z

🟢 Reviewer checklist completed. @marufsharifi Please address the 3 comments from above in order for me to be able to approve the changes and have a engineer assigned for workflows approval & final review.

marufsharifi · 2025-10-09T08:30:51Z

@ikevin127, Thanks for the review. I have addressed all the feedback.

ikevin127

Thanks for the updates!

blimpich

Nice job!

blimpich · 2025-10-09T20:32:16Z

Looks like we do have some failed checks. Normally these run after you push up a PR but for your first PR they weren't run until I approved them to run. Kind of annoying, sorry about that. Can we fix these failing checks?

failing checks

marufsharifi · 2025-10-10T14:50:09Z

@blimpich, I fixed them. It doesn't show those running again. thanks

codecov · 2025-10-10T17:10:23Z

Codecov Report

❌ Patch coverage is 94.91525% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/MarkdownLinkHelpers.ts	94.59%	2 Missing ⚠️
src/hooks/useHtmlPaste/index.ts	90.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/RenderHTML.tsx	`100.00% <ø> (ø)`
...omposerWithSuggestions/ComposerWithSuggestions.tsx	`59.12% <100.00%> (+20.44%)`	⬆️
src/hooks/useHtmlPaste/index.ts	`59.57% <90.00%> (+59.57%)`	⬆️
src/libs/MarkdownLinkHelpers.ts	`94.59% <94.59%> (ø)`

... and 29 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blimpich · 2025-10-10T17:33:06Z

@marufsharifi Nice work! And great job increasing our overall test coverage!

Just a few cspell errors to correct then we should be good to go 👍

ikevin127 · 2025-10-10T20:57:23Z

@marufsharifi You can add the words failing spell check to cspell.json file, words object to omit them from the check since they are either part of the testing logic or comments.

marufsharifi · 2025-10-11T07:27:05Z

@blimpich, @ikevin127, thanks for the review. Fixed the spell check failure as well.

OSBotify · 2025-10-13T17:46:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T21:20:39Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:35:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

linhvovan29546 · 2025-11-22T06:03:20Z

-            const plainText = event.clipboardData?.getData('text/plain');
-            if (plainText) {
-                paste(plainText);
+            const clipboardText = event.clipboardData?.getData('text/plain')?.trim();


We shouldn’t add trim(), because it removes whitespace when pasting text. This is what caused issue #74749. So we applied the fix here.

Feature: Automatically create Markdown links when pasting a link on h…

06197f9

…ighlighted text

melvin-bot Bot assigned marufsharifi Oct 3, 2025

marufsharifi added 5 commits October 4, 2025 18:59

Merge branch 'main' into feat/auto-markdown-link-on-paste

4f85ae4

Add unit test for MarkdownLinkHelper

8c1d2fd

Merge branch 'main' into feat/auto-markdown-link-on-paste

1dea2e4

feat(integration-test): add integration test for ReportActionCompose …

6b8402d

…and useHtmlPaste

Merge branch 'main' into feat/auto-markdown-link-on-paste

67ab8d7

marufsharifi marked this pull request as ready for review October 7, 2025 18:42

marufsharifi requested a review from a team as a code owner October 7, 2025 18:42

melvin-bot Bot requested a review from ikevin127 October 7, 2025 18:42

melvin-bot Bot removed the request for review from a team October 7, 2025 18:42

ikevin127 reviewed Oct 8, 2025

View reviewed changes

Comment thread src/components/RenderHTML.tsx Outdated

ikevin127 reviewed Oct 8, 2025

View reviewed changes

Comment thread tests/ui/ReportActionComposeTest.tsx

ikevin127 reviewed Oct 8, 2025

View reviewed changes

Comment thread src/hooks/useHtmlPaste/index.ts

marufsharifi added 2 commits October 9, 2025 12:42

Merge branch 'main' into feat/auto-markdown-link-on-paste

2fad97d

extended test cases for ReportActionCompose

e53062b

marufsharifi requested a review from ikevin127 October 9, 2025 08:31

ikevin127 approved these changes Oct 9, 2025

View reviewed changes

melvin-bot Bot requested a review from blimpich October 9, 2025 08:33

blimpich previously approved these changes Oct 9, 2025

View reviewed changes

marufsharifi added 2 commits October 10, 2025 13:13

Merge branch 'main' into feat/auto-markdown-link-on-paste

82dc8a0

Fix: type, eslint issues

a99daf4

marufsharifi added 2 commits October 11, 2025 11:54

fix spell check failing

3d636c0

Merge branch 'main' into feat/auto-markdown-link-on-paste

cc4454b

marufsharifi requested review from blimpich and ikevin127 October 11, 2025 07:27

ikevin127 approved these changes Oct 11, 2025

View reviewed changes

blimpich approved these changes Oct 13, 2025

View reviewed changes

blimpich merged commit fdf96d0 into Expensify:main Oct 13, 2025
21 checks passed

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-13 #72503

Closed

92 tasks

ikevin127 mentioned this pull request Oct 18, 2025

[$250] Automatically create a Markdown link when highlighting text and pasting a link #70901

Closed

linhvovan29546 mentioned this pull request Nov 11, 2025

[Due for payment 2025-11-26] [$250] Trailing whitespace trimmed when pasting in composer #74749

Closed

16 tasks

linhvovan29546 reviewed Nov 22, 2025

View reviewed changes

Uh oh!

Conversation

marufsharifi commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 7, 2025

Uh oh!

ikevin127 commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ikevin127 commented Oct 8, 2025

Uh oh!

marufsharifi commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ikevin127 left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich commented Oct 9, 2025

Uh oh!

marufsharifi commented Oct 10, 2025

Uh oh!

codecov Bot commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blimpich commented Oct 10, 2025

Uh oh!

ikevin127 commented Oct 10, 2025

Uh oh!

marufsharifi commented Oct 11, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

linhvovan29546 Nov 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marufsharifi commented Oct 3, 2025 •

edited

Loading

ikevin127 commented Oct 8, 2025 •

edited

Loading

marufsharifi commented Oct 9, 2025 •

edited

Loading

codecov Bot commented Oct 10, 2025 •

edited

Loading