[CP Staging] fix regression from #69644: Invoice - To field on confirm page has right caret when sending invoice from invoice room by TaduJR · Pull Request #71648 · Expensify/App

TaduJR · 2025-10-01T08:33:46Z

Explanation of Change

Fixed a bug where the "To" field on the invoice confirmation page was incorrectly showing a right caret icon and appearing interactive when sending an invoice from an invoice room, even though the recipient is already determined and cannot be changed in this context.

Root Cause:

App/src/components/MoneyRequestConfirmationList.tsx

Lines 813 to 818 in fa5e06d

    
           const formattedSelectedParticipants = selectedParticipants.map((participant) => ({ 
        
               ...participant, 
        
               isSelected: false, 
        
               isInteractive: (isCreateExpenseFlow && !isTestReceipt && !isRestrictedToPreferredPolicy) || isTypeInvoice, 
        
               shouldShowRightIcon: (isCreateExpenseFlow && !isTestReceipt && !isRestrictedToPreferredPolicy) || isTypeInvoice, 
        
           }));

The preferred policy restriction feature added an exception for invoices (|| isTypeInvoice) to ensure they remain interactive despite workspace restrictions. However, this exception was too broad and applied to ALL invoice scenarios, including invoice rooms where the recipient is already locked in.

The Fix:
Modified the logic to require isCreateExpenseFlow for both regular expenses AND the invoice exception. This ensures the invoice exception only applies during the global create flow (FAB → Send invoice), not when sending invoices from invoice rooms where the recipient is predetermined.

Fixed Issues

$ #71633
PROPOSAL: #69644 (comment)

Tests

Precondition: Invoice is enabled.

Test FAB → Send invoice (should be interactive)
- Open FAB → Send invoice
- Select a recipient
- Enter amount → Next
- Verify the "To" field shows a right caret icon
- Verify clicking the "To" field allows changing the recipient
Test Invoice room → Send invoice
- Open FAB → Send invoice
- Send an invoice to any user
- Open the created invoice room
- Click + → Send invoice
- Enter amount → Next
- Verify the "To" field does NOT show a right caret icon
- Verify the "To" field is NOT clickable/interactive

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

…invoice from invoice room

melvin-bot · 2025-10-01T08:34:23Z

@cristipaval Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ahmedGaber93 · 2025-10-01T08:38:08Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

20251001115912324.mp4

MacOS: Desktop

codecov · 2025-10-01T08:45:20Z

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/MoneyRequestConfirmationList.tsx	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

Co-authored-by: ahmedGaber93 <41129870+ahmedGaber93@users.noreply.github.com>

ahmedGaber93 · 2025-10-01T09:11:26Z

@TaduJR could you please add "fix regression from #69644" or "follow-up #69644" in the PR title for more context?

ahmedGaber93 · 2025-10-01T09:17:35Z

Also add in test steps

Precondition:

- Invoice is enabled.

TaduJR · 2025-10-01T09:18:11Z

@TaduJR could you please add "fix regression from #69644" or "follow-up #69644" in the PR title for more context?

Done.

Do you have an idea on why [React Compiler Compliance Check / React Compiler Compliance] is failing?

ahmedGaber93 · 2025-10-01T09:43:43Z

Do you have an idea on why [React Compiler Compliance Check / React Compiler Compliance] is failing?

This action was merged into main 10 hours ago here #70394, It looks we should fix every issue here https://github.com/Expensify/App/actions/runs/18157150347/job/51679597610?pr=71648

@TaduJR To run it locally, do any change to MoneyRequestConfirmationList.tsx then run npm run react-compiler-compliance-check check-changed

This link can help https://react.dev/reference/eslint-plugin-react-hooks/lints/preserve-manual-memoization

ahmedGaber93

Changes LGTM! We just still need to pass the new action react-compiler-compliance-check, All the compiler issues are optimization tips that already exist in production and on the latest main branch, so they’re not related to this PR.

I’ve approved this PR since it’s a deployment blocker. I’ll leave it to the internal engineer to decide whether to wait for @TaduJR to fix them or proceed with merging.

CC @mountiny

Julesssss · 2025-10-01T17:55:39Z

Skipping compiler check for this component as it already exists.

melvin-bot · 2025-10-01T17:56:24Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

Julesssss · 2025-10-01T17:57:16Z

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

#71648 (comment)

…-page-has-right-caret-when-sending-invoice-from-invoice-room fix regression from #69644: Invoice - To field on confirm page has right caret when sending invoice from invoice room (cherry picked from commit b0daafa) (cherry-picked to staging by Julesssss)

OSBotify · 2025-10-01T18:07:12Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-01T18:43:34Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.21-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Julesssss · 2025-10-01T19:55:59Z

Resolved ✅

OSBotify · 2025-10-02T04:26:51Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-02T04:50:36Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-02T05:16:53Z

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.2.22-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-03T17:36:52Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.22-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Invoice - To field on confirm page has right caret when sending …

75befdd

…invoice from invoice room

TaduJR requested a review from a team as a code owner October 1, 2025 08:33

melvin-bot Bot assigned TaduJR Oct 1, 2025

melvin-bot Bot requested review from cristipaval and removed request for a team October 1, 2025 08:34

ahmedGaber93 reviewed Oct 1, 2025

View reviewed changes

Comment thread src/components/MoneyRequestConfirmationList.tsx Outdated

Update src/components/MoneyRequestConfirmationList.tsx

078a760

Co-authored-by: ahmedGaber93 <41129870+ahmedGaber93@users.noreply.github.com>

TaduJR changed the title ~~fix: Invoice - To field on confirm page has right caret when sending invoice from invoice room~~ fix regression from #69644: Invoice - To field on confirm page has right caret when sending invoice from invoice room Oct 1, 2025

ahmedGaber93 approved these changes Oct 1, 2025

View reviewed changes

melvin-bot Bot requested a review from marcaaron October 1, 2025 11:07

Julesssss mentioned this pull request Oct 1, 2025

[Due for payment 2025-10-09] Invoice - To field on confirm page has right caret when sending invoice from invoice room #71633

Closed

8 tasks

Julesssss approved these changes Oct 1, 2025

View reviewed changes

Julesssss merged commit b0daafa into Expensify:main Oct 1, 2025
23 of 24 checks passed

melvin-bot Bot added the Emergency label Oct 1, 2025

Julesssss removed the Emergency label Oct 1, 2025

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 1, 2025

OSBotify mentioned this pull request Oct 1, 2025

Deploy Checklist: New Expensify 2025-09-30 #71621

Closed

72 tasks

mountiny changed the title ~~fix regression from #69644: Invoice - To field on confirm page has right caret when sending invoice from invoice room~~ [CP Staging] fix regression from #69644: Invoice - To field on confirm page has right caret when sending invoice from invoice room Oct 1, 2025

mitarachim mentioned this pull request Oct 2, 2025

[Due for payment 2026-01-21] [Due for payment 2026-01-20] [$250] Invoice-Wrong recipient when selecting an email address after selecting an Invoice room #71723

Closed

8 tasks

TaduJR deleted the fix-Invoice-To-field-on-confirm-page-has-right-caret-when-sending-invoice-from-invoice-room branch October 2, 2025 04:54

	const formattedSelectedParticipants = selectedParticipants.map((participant) => ({
	...participant,
	isSelected: false,
	isInteractive: (isCreateExpenseFlow && !isTestReceipt && !isRestrictedToPreferredPolicy) \|\| isTypeInvoice,
	shouldShowRightIcon: (isCreateExpenseFlow && !isTestReceipt && !isRestrictedToPreferredPolicy) \|\| isTypeInvoice,
	}));

Uh oh!

Conversation

TaduJR commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 1, 2025

Uh oh!

ahmedGaber93 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Oct 1, 2025

Codecov Report

Uh oh!

Uh oh!

ahmedGaber93 commented Oct 1, 2025

Uh oh!

ahmedGaber93 commented Oct 1, 2025

Uh oh!

TaduJR commented Oct 1, 2025

Uh oh!

ahmedGaber93 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ahmedGaber93 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Julesssss commented Oct 1, 2025

Uh oh!

Uh oh!

melvin-bot Bot commented Oct 1, 2025

Uh oh!

Julesssss commented Oct 1, 2025

Uh oh!

OSBotify commented Oct 1, 2025

Uh oh!

OSBotify commented Oct 1, 2025

Uh oh!

Julesssss commented Oct 1, 2025

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

OSBotify commented Oct 2, 2025

Uh oh!

OSBotify commented Oct 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

TaduJR commented Oct 1, 2025 •

edited

Loading

ahmedGaber93 commented Oct 1, 2025 •

edited

Loading

ahmedGaber93 commented Oct 1, 2025 •

edited

Loading

ahmedGaber93 left a comment •

edited

Loading