Fix/70912 - Edit composer isn't automatically focused by dmkt9 · Pull Request #71637 · Expensify/App

dmkt9 · 2025-10-01T03:27:10Z

Explanation of Change

Fixed Issues

$ #70912
PROPOSAL: #70912 (comment)

Tests

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Same as QA Steps

QA Steps

Test 1:

Launch Expensify app.
Go to any chat.
Send the message.
Long press on the message > Edit comment.
Verify that edit composer will be focused.

Test 2:

Launch Expensify app on iOS.
Go to any chat.
Tap on "+" button.
Select "Add attachment"
Verify that the Add attachment modal displays correctly.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Test 1:

Android: Native

android.native.mp4

Android: mWeb Chrome

android.mweb.mp4

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.mweb.mp4

MacOS: Chrome / Safari

mac.safari.mp4

MacOS: Desktop

mac.desktop.mp4

Test 2:

ios.native.test.mp4

melvin-bot · 2025-10-01T03:27:17Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

helenjmurry-ux · 2025-10-01T05:40:29Z

@brunovjk Please check this PR has an issue with latest main.

brunovjk · 2025-10-02T00:06:29Z

@brunovjk Please check this PR has an issue with latest main.

What do you mean with issue with the lastest main? Thank you @helenjmurry-ux

brunovjk · 2025-10-02T00:30:02Z

@dmkt9 the main composer sometimes doesn't return to focus after editing, do you think we can fix this here? Another thing, to understand, why are you checking only IOS this time? Thanks.

Screen.Recording.2025-10-01.at.21.24.14.mov

Screen.Recording.2025-10-01.at.21.22.25.mov

dmkt9 · 2025-10-07T10:14:31Z

@dmkt9 the main composer sometimes doesn't return to focus after editing, do you think we can fix this here

Hi @brunovjk, I think it's possible, but the root cause seems to be different. If we want to fix it, I think we can apply a similar approach as this one when ReportActionItemMessageEdit unmounts.

dmkt9 · 2025-10-07T10:23:05Z

Another thing, to understand, why are you checking only IOS this time? Thanks.

I noticed that onDismiss works correctly on iOS. Also, on iOS, when 'Add attachment' is clicked, onDismiss is triggered first. It seems the Container is only being hidden rather than actually unmounted, so the exiting animation doesn’t run.

codecov · 2025-10-07T10:36:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #71637      +/-   ##
==========================================
- Coverage   35.17%   35.14%   -0.04%     
==========================================
  Files        3290     3291       +1     
  Lines      107852   107964     +112     
  Branches    34421    34474      +53     
==========================================
- Hits        37942    37939       -3     
- Misses      69725    69838     +113     
- Partials      185      187       +2

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brunovjk · 2025-10-08T02:52:19Z

Another thing, to understand, why are you checking only IOS this time? Thanks.

I noticed that onDismiss works correctly on iOS. Also, on iOS, when 'Add attachment' is clicked, onDismiss is triggered first. It seems the Container is only being hidden rather than actually unmounted, so the exiting animation doesn’t run.

Sorry @dmkt9, I didn't quite understand. I tested it and the issue is reproducible on Android, right? Note: The bug with the attachment iOS is also reproducible in the latest main:

Android: HybridApp - main

androd_native_main.mov

iOS: HybridApp - main

ios_native_main.mov

I tested it and our PR seems to work fine.

Android: HybridApp - our PR

androd_native_PR.mov

iOS: HybridApp - our PR

ios_native_PR.mov

I need to test more to make sure there aren't any other regressions. Thank you very much.

brunovjk · 2025-10-09T14:43:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

71637_android_native.mov

Android: mWeb Chrome

71637_androidweb.mov

iOS: HybridApp

71637_ios_native.mov

iOS: mWeb Safari

71637_ios_web.mov

MacOS: Chrome / Safari

71637_web_chrome.mov

MacOS: Desktop

71637_web_desktop.mov

brunovjk

LGTM. On some platforms, after returning from editing, the main composer no longer becomes focused, even if it was focused before. This bug was neither introduced nor fixed by this PR.

MacOS: Desktop Lastest main

71637_web_desktop_main.mov

Beamanator

LGTM!

OSBotify · 2025-10-09T17:39:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-10T11:12:31Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T20:59:29Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

situchan · 2025-12-23T13:16:28Z

-        if (getPlatform() === CONST.PLATFORM.ANDROID) {
+        // Therefore, we manually call onDismiss and onModalHide here.
+        if (getPlatform() !== CONST.PLATFORM.IOS) {
+            onDismiss?.();


This change caused regression on web.
More details: #72648 (comment)

Fix - Edit composer isn't automatically focused

c9ba5ba

dmkt9 requested a review from a team as a code owner October 1, 2025 03:27

melvin-bot Bot assigned dmkt9 Oct 1, 2025

melvin-bot Bot requested a review from brunovjk October 1, 2025 03:27

melvin-bot Bot removed the request for review from a team October 1, 2025 03:27

Merge branch 'main' into fix/70912b

67ae325

brunovjk approved these changes Oct 9, 2025

View reviewed changes

melvin-bot Bot requested a review from Beamanator October 9, 2025 15:22

Beamanator approved these changes Oct 9, 2025

View reviewed changes

Beamanator merged commit 8c1137d into Expensify:main Oct 9, 2025
20 checks passed

OSBotify mentioned this pull request Oct 10, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

situchan mentioned this pull request Oct 13, 2025

[HOLD App #70912] Chat - Compose box is not focused after selecting emoji #71938

Closed

8 tasks

brunovjk mentioned this pull request Oct 16, 2025

[Due for payment 2025-10-07] [$250] Android + iOS - Chat - Main composer is focused when editing message #70912

Closed

8 tasks

Eskalifer1 mentioned this pull request Oct 22, 2025

[Due for payment 2025-12-23] [$250] Status - Cursor overlaps with text after adding an emoji #72648

Closed

8 tasks

This was referenced Dec 10, 2025

Revert "Fix/70912 - Edit composer isn't automatically focused" #77271

Closed

Remove onDismiss, trigger onModalHide on Android; fix early-unmount setReadyToFocus #77104

Merged

situchan reviewed Dec 23, 2025

View reviewed changes

Conversation

dmkt9 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 1, 2025

Uh oh!

helenjmurry-ux commented Oct 1, 2025

Uh oh!

brunovjk commented Oct 2, 2025

Uh oh!

brunovjk commented Oct 2, 2025

Uh oh!

dmkt9 commented Oct 7, 2025

Uh oh!

dmkt9 commented Oct 7, 2025

Uh oh!

codecov Bot commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brunovjk commented Oct 8, 2025

Uh oh!

brunovjk commented Oct 9, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

Beamanator left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

situchan Dec 23, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dmkt9 commented Oct 1, 2025 •

edited

Loading

codecov Bot commented Oct 7, 2025 •

edited

Loading