fix edit comment input: mention suggestions is not displayed#71417
Conversation
|
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@cristipaval Feel free to trigger the adhoc build |
Codecov Report❌ Patch coverage is
... and 5 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
Testing on physical devices today. |
|
Sorry for the delay I am still unable to reproduce this deploy blocker using the adhoc desktop build + web above Screen.Recording.2025-10-02.at.06.39.38.mov |
|
@cristipaval, could we ask QA to try reproducing #70679, with the changes of this PR? |
this is a great idea. Please merge main, then I'll trigger ad-hoc builds and ask for a retest of that issue with the new builds. |
@NJ-2020, please merge main. |
|
Done cc: @cristipaval |
|
Friendly bump @cristipaval |
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
Retest requested here |
|
Applause confirmed that the issue is no longer reproducible. Are we good to merge this? |
Thanks, yeah I think so, but we need approval checklist from @thesahindia first. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-09-12.at.5.01.14.PM.movAndroid: mWeb ChromeScreen.Recording.2025-09-12.at.5.06.13.PM.moviOS: HybridAppiOS: mWeb SafariScreen.Recording.2025-09-13.at.2.22.30.PM.movMacOS: Chrome / SafariScreen.Recording.2025-09-12.at.4.51.19.PM.movScreen.Recording.2025-10-10.at.1.40.49.PM.movMacOS: DesktopScreen.Recording.2025-09-13.at.2.43.11.PM.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.30-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀
|
Explanation of Change
Prevent from hiding the mention suggestions menu when the scroll event is likely triggered from the layout changes
Fixed Issues
$ #68722
PROPOSAL: #68722 (comment)
Tests
@Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
chat_mentions_android_native.webm
Android: mWeb Chrome
chat_mention_suggestions_mweb_android.1.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-05.at.15.29.26.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-09-05.at.15.23.23.mp4
MacOS: Chrome / Safari
Screen.Recording.2025-09-05.at.15.38.27.mov
MacOS: Desktop
Screen.Recording.2025-09-05.at.15.36.22.mov