[No QA] Remove `nestedStyles` by staszekscp · Pull Request #71277 · Expensify/App

staszekscp · 2025-09-25T06:44:36Z

cc: @mountiny

Explanation of Change

This PR removes nestedStyles and introduces plainStyles for values that cannot be wrapped in StyleSheet.create

Fixed Issues

$ #70099
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-25.at.09.44.33.mov

Android: mWeb Chrome

Screen.Recording.2025-09-25.at.08.49.48.mov

iOS: Native

Screen.Recording.2025-09-25.at.09.25.29.mov

iOS: mWeb Safari

Screen.Recording.2025-09-25.at.09.28.45.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-25.at.08.48.17.mov

MacOS: Desktop

Screen.Recording.2025-09-25.at.09.35.27.mov

codecov · 2025-09-25T07:42:23Z

Codecov Report

❌ Patch coverage is 36.84211% with 24 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/workspace/WorkspacesListRow.tsx	0.00%	4 Missing and 1 partial ⚠️
.../LocationErrorMessage/BaseLocationErrorMessage.tsx	0.00%	3 Missing ⚠️
src/styles/index.ts	62.50%	3 Missing ⚠️
src/components/DotIndicatorMessage.tsx	0.00%	2 Missing ⚠️
...TMLEngineProvider/HTMLRenderers/EditedRenderer.tsx	0.00%	1 Missing ⚠️
src/components/OfflineWithFeedback.tsx	66.66%	1 Missing ⚠️
...rc/components/ReportActionItem/MoneyReportView.tsx	0.00%	1 Missing ⚠️
...ents/WorkspacesListRowDisplayName/index.native.tsx	50.00%	1 Missing ⚠️
.../components/WorkspacesListRowDisplayName/index.tsx	0.00%	1 Missing ⚠️
.../pages/home/report/comment/TextCommentFragment.tsx	0.00%	1 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

melvin-bot · 2025-09-25T09:52:03Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

staszekscp · 2025-09-25T09:52:11Z

Please, review the PR after #71168 gets merged

jayeshmangwani · 2025-09-26T12:31:33Z

It looks like the PR #71168 has been approved and is waiting to be merged.

jayeshmangwani · 2025-10-05T19:03:17Z

@staszekscp Please merge main here, I’ll test and review so we can move forward with this PR.

staszekscp · 2025-10-06T08:26:50Z

Sure, I'll do it later today!

jayeshmangwani · 2025-10-07T12:08:18Z

@staszekscp I think you mistakenly pushed the Mobile-Expensify submodule changes here.

mountiny · 2025-10-07T15:35:49Z

There are conflicts now too

…styles

jayeshmangwani · 2025-10-08T06:14:56Z

@staszekscp Please remove the Mobile-Expensify changes and fix the conflicts. I’ll review it again and merge it before more conflicts pop up.

staszekscp · 2025-10-08T06:20:10Z

Sure, sorry for the Mobile-Expensify mess, I would have to deinit the whole submodule to fix the problem but yesterday at the same time I was working on an issue that had Mobile-Expensify changes stashed, so I didn't want to get rid of them

jayeshmangwani · 2025-10-08T07:04:37Z

        webViewStyles: webViewStyles(theme),
+        textInputDesktop: addOutlineWidth(theme, {}, 0),
+        noOutline: addOutlineWidth(theme, {}, 0),
+        picker: (disabled = false, backgroundColor: string = theme.appBG) =>


@staszekscp Why are we adding this style to plainStyles? It seems like it should go under dynamicStyles instead.

I think its because of the Math.round no?

jayeshmangwani · 2025-10-08T10:11:46Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android.mov

Android: mWeb Chrome

mweb-chrome.mov

iOS: HybridApp

ioS.mov

iOS: mWeb Safari

mweb-safari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

jayeshmangwani

LGTM 🚀

mountiny

Thanks, moving this ahead

mountiny · 2025-10-08T18:59:42Z

        webViewStyles: webViewStyles(theme),
+        textInputDesktop: addOutlineWidth(theme, {}, 0),
+        noOutline: addOutlineWidth(theme, {}, 0),
+        picker: (disabled = false, backgroundColor: string = theme.appBG) =>


I think its because of the Math.round no?

OSBotify · 2025-10-08T19:12:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-08T21:56:59Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-10T10:51:22Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Remove nestedStyles

2308502

melvin-bot Bot assigned staszekscp Sep 25, 2025

staszekscp added 2 commits September 25, 2025 09:28

Fix linter by using named imports in WorkspacesListRowDisplayName

b850eea

Fix prettier

347b374

staszekscp changed the title ~~Remove nestedStyles~~ [No QA] Remove nestedStyles Sep 25, 2025

staszekscp marked this pull request as ready for review September 25, 2025 09:51

staszekscp requested review from a team as code owners September 25, 2025 09:51

melvin-bot Bot requested review from jayeshmangwani and removed request for a team September 25, 2025 09:52

Update Mobile-Expensify

e6cd2d6

Merge remote-tracking branch 'origin/main' into chore/migrate-nested-…

4194c20

…styles

Merge branch 'main' into chore/migrate-nested-styles

a6dea3a

jayeshmangwani reviewed Oct 8, 2025

View reviewed changes

jayeshmangwani approved these changes Oct 8, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny October 8, 2025 10:12

mountiny approved these changes Oct 8, 2025

View reviewed changes

mountiny merged commit 46a3949 into Expensify:main Oct 8, 2025
23 of 24 checks passed

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72135

Closed

62 tasks

jayeshmangwani mentioned this pull request Oct 9, 2025

[Due for payment 2025-10-17] [Due for payment 2025-10-09] [$500] Optimize style prop usage by using StyleSheet.create #70099

Closed

Uh oh!

Conversation

staszekscp commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 25, 2025

Uh oh!

staszekscp commented Sep 25, 2025

Uh oh!

jayeshmangwani commented Sep 26, 2025

Uh oh!

jayeshmangwani commented Oct 5, 2025

Uh oh!

staszekscp commented Oct 6, 2025

Uh oh!

jayeshmangwani commented Oct 7, 2025

Uh oh!

mountiny commented Oct 7, 2025

Uh oh!

jayeshmangwani commented Oct 8, 2025

Uh oh!

staszekscp commented Oct 8, 2025

Uh oh!

jayeshmangwani Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

jayeshmangwani commented Oct 8, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

jayeshmangwani left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

staszekscp commented Sep 25, 2025 •

edited

Loading

codecov Bot commented Sep 25, 2025 •

edited

Loading