Perf/images lazy loading by martasudol · Pull Request #71170 · Expensify/App

martasudol · 2025-09-24T09:10:54Z

Explanation of Change

Coming from #69358.
This PR demonstrates the initial implementation, focusing on workspace-related components. It shows how illustrations can be split into chunks and lazy-loaded on demand. Later PRs will extend this approach to Expensicons, general image assets, and bank/company card logos.

Before:

Visual assets dominated the main bundle - Illustrations.ts (162 illustrations) were bundled eagerly, adding several hundred KB of payload at startup

After:

Assets in the workspace components are now loaded on demand. The main bundle size is reduced, startup is faster, and caching is more efficient

Fixed Issues

$ #68775
PROPOSAL: https://callstack-hq.slack.com/archives/C05LX9D6E07/p1756383462406999

Tests

Open the app, switch between offline/online statuses and check if icons are loaded correctly.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Nagranie.z.ekranu.2025-09-26.o.10.44.01.mov

Android: mWeb Chrome

Nagranie.z.ekranu.2025-09-26.o.10.31.51.mov

iOS: Native

Nagranie.z.ekranu.2025-09-26.o.10.09.43.mov

iOS: mWeb Safari

Nagranie.z.ekranu.2025-09-26.o.10.15.08.mov

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-09-26.o.09.33.39.mov

MacOS: Desktop

Nagranie.z.ekranu.2025-09-26.o.10.24.25.mov

codecov · 2025-09-25T11:18:34Z

Codecov Report

❌ Patch coverage is 13.20755% with 322 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...rc/components/Icon/chunks/expensify-icons.chunk.ts	0.00%	55 Missing ⚠️
src/components/Icon/chunks/illustrations.chunk.ts	0.00%	49 Missing ⚠️
src/hooks/useLazyAsset.ts	41.66%	49 Missing ⚠️
src/components/Icon/ExpensifyIconLoader.ts	0.00%	26 Missing ⚠️
src/components/Icon/IllustrationLoader.ts	7.69%	24 Missing ⚠️
src/pages/workspace/WorkspaceOverviewPage.tsx	0.00%	7 Missing ⚠️
...ompanyCards/WorkspaceCompanyCardPageEmptyState.tsx	0.00%	6 Missing ⚠️
...nsifyCard/WorkspaceExpensifyCardPageEmptyState.tsx	0.00%	6 Missing ⚠️
...accounting/netsuite/NetSuiteSubsidiarySelector.tsx	0.00%	5 Missing ⚠️
...ounting/xero/XeroOrganizationConfigurationPage.tsx	0.00%	5 Missing ⚠️
... and 56 more

📢 Thoughts on this report? Let us know!

martasudol · 2025-10-07T07:39:43Z

@martasudol is this ready for a review or something needs to be updated?

It's ready for the review.

mountiny · 2025-10-07T12:35:55Z

@martasudol there are more conflicts now 🙈

github-actions · 2025-10-08T09:30:03Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-08T10:04:03Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #71170.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/71170/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/71170/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/71170/NewExpensify.dmg	https://71170.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

Krishna2323 · 2025-10-08T15:06:38Z

 function ImageSVG({src, width = '100%', height = '100%', fill, hovered = false, pressed = false, style, pointerEvents, preserveAspectRatio}: ImageSVGProps) {
+    if (!src) {
+        return null;
+    }


@martasudol I think we should also add a null-guard in android and ios files.

Krishna2323 · 2025-10-08T15:07:16Z

+    const {asset: ExpensifyAppIcon} = useMemoizedLazyAsset(() => loadExpensifyIcon('ExpensifyAppIcon'));
+    const {asset: Inbox} = useMemoizedLazyAsset(() => loadExpensifyIcon('Inbox'));
+    const {asset: MoneySearch} = useMemoizedLazyAsset(() => loadExpensifyIcon('MoneySearch'));
+    const {asset: Buildings} = useMemoizedLazyAsset(() => loadExpensifyIcon('Buildings'));


Please update this to use useMemoizedLazyExpensifyIcons here.

Krishna2323 · 2025-10-08T15:07:58Z

    const pageTitle = shouldDisplayCardDomain ? expensifyCardTitle : (cardList?.[cardID]?.nameValuePairs?.cardTitle ?? expensifyCardTitle);
    const {displayName} = useCurrentUserPersonalDetails();
+    const {asset: Flag} = useMemoizedLazyAsset(() => loadExpensifyIcon('Flag'));
+    const {asset: MoneySearch} = useMemoizedLazyAsset(() => loadExpensifyIcon('MoneySearch'));


Please update this to use useMemoizedLazyExpensifyIcons here.

Krishna2323 · 2025-10-08T15:11:08Z

+    const {asset: Tag} = useMemoizedLazyAsset(() => loadExpensifyIcon('Tag'));
+    const {asset: Users} = useMemoizedLazyAsset(() => loadExpensifyIcon('Users'));
+    const {asset: Workflows} = useMemoizedLazyAsset(() => loadExpensifyIcon('Workflows'));
+


Please update this to use useMemoizedLazyExpensifyIcons here.

Krishna2323 · 2025-10-08T15:14:38Z

 function ChangeWorkspaceMenuSectionList() {
    const {translate} = useLocalize();
    const styles = useThemeStyles();
+    const illustrations = useMemoizedLazyIllustrations(['FolderOpen', 'Workflows'] as const);


We don't need to use as const for inline literal.

Krishna2323 · 2025-10-08T16:18:11Z

@martasudol We have some console errors and warnings. One of them is from the PlaceholderIcon component, and I think the others were already present. Could you please check on that? Thanks!

Error from PlaceholderIcon component: Error: <svg> attribute viewBox: Expected number, "0 0 100% 100%".

Monosnap (3) New Expensify 2025-10-08 21-45-13

Monosnap (3) New Expensify 2025-10-08 21-44-58

Krishna2323 · 2025-10-08T22:37:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android_native_hybrid.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: HybridApp

ios_native_hybrid.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Krishna2323 · 2025-10-08T22:39:12Z

@mountiny I believe it's expecting a PR reviewer checklist from Gonals, as per this comment. I have tried commenting with the checklist twice.

martasudol · 2025-10-09T06:53:50Z

Error: attribute viewBox: Expected number, "0 0 100% 100%".

Thanks for noticing!

Error: <svg> attribute viewBox: Expected number, "0 0 100% 100%". is already addressed and should not occur anymore. Other errors & warnings are not related and were already there.

Krishna2323

Looks good to me! 🎊

mountiny

Thank you @OlimpiaZurek @martasudol @Krishna2323

Excited to see what will be the bundle size change with all the updates we have done so far

OSBotify · 2025-10-10T11:12:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T20:59:08Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OlimpiaZurek and others added 4 commits September 12, 2025 11:31

perf: lazy load images to reduce main bundle size

91d378a

improve lazy loading and add icons preloading

d90b614

add dynamic imports and preload icons

566bd6c

perf: removed unused assets

5fe3014

melvin-bot Bot assigned martasudol Sep 24, 2025

martasudol added 17 commits September 24, 2025 14:10

Merge branch 'main' into perf/images-lazy-loading

4033969

prettier

cc7c4bc

eslint & prettier

a279040

eslint & prettier

ab0ebca

eslint & prettier

dda16b1

spelling

08337e3

eslint & prettier

f42c3a6

Merge branch 'main' into perf/images-lazy-loading

d737b2d

eslint & prettier

43c6cab

tests fixes

b8173c9

tests fixes

49c2bee

tests fixes

4b71d15

tests fixes

7a29148

tests fixes

ff3b45a

tests fixes

cba11e9

tests fixes

82c08ce

tests fixes

4415ca2

martasudol added 3 commits September 26, 2025 09:11

Merge branch 'main' into perf/images-lazy-loading

c56e849

useLazyAsset.test.ts added

b243dbf

tests fixes

a58b7e5

martasudol marked this pull request as ready for review September 29, 2025 05:48

martasudol requested review from a team as code owners September 29, 2025 05:48

melvin-bot Bot requested a review from Gonals September 29, 2025 05:48

Krishna2323 reviewed Oct 7, 2025

View reviewed changes

Comment thread src/pages/OnboardingInterestedFeatures/BaseOnboardingInterestedFeatures.tsx Outdated

Comment thread tests/unit/hooks/useLazyAsset.test.ts

martasudol added 2 commits October 8, 2025 08:15

Merge branch 'main' into perf/images-lazy-loading

e56b97e

PR comments addressed

1a3cbfb

mountiny requested review from Krishna2323 and removed request for Gonals October 8, 2025 09:29

martasudol added 2 commits October 8, 2025 11:30

PR comments addressed

4e7500b

PR comments addressed

2b67f8f

Krishna2323 suggested changes Oct 8, 2025

View reviewed changes

This comment was marked as resolved.

Sign in to view

PR comments addressed

3abbd3c

PR comments addressed

9fb73d9

Krishna2323 approved these changes Oct 9, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny October 9, 2025 11:00

mountiny approved these changes Oct 9, 2025

View reviewed changes

mountiny merged commit 668ff7b into Expensify:main Oct 9, 2025
21 checks passed

This was referenced Oct 9, 2025

Investigate workflow job failing on main: test / test (job 1) #72206

Closed

Investigate workflow job failing on main: test / test (job 1) #72211

Closed

OSBotify mentioned this pull request Oct 10, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

stitesExpensify mentioned this pull request Oct 10, 2025

[Due for payment 2025-10-21] Category - The "GL & Payroll codes" feature shows a fallback avatar icon #72319

Closed

8 tasks

mountiny mentioned this pull request Nov 7, 2025

[Due for payment 2025-12-12] [Due for payment 2025-11-26] Add clear migration guide and tooling for icons and illustrations #74599

Closed

Conversation

martasudol commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

martasudol commented Oct 7, 2025

Uh oh!

mountiny commented Oct 7, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Oct 8, 2025

Uh oh!

github-actions Bot commented Oct 8, 2025

Uh oh!

Krishna2323 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

Krishna2323 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as resolved.

Krishna2323 commented Oct 8, 2025

Uh oh!

Krishna2323 commented Oct 8, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Krishna2323 commented Oct 8, 2025

Uh oh!

martasudol commented Oct 9, 2025

Uh oh!

Krishna2323 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

martasudol commented Sep 24, 2025 •

edited

Loading

codecov Bot commented Sep 25, 2025 •

edited

Loading