Feat/new contact method confirm magic code uses navigation by jmusial · Pull Request #71166 · Expensify/App

jmusial · 2025-09-24T08:16:16Z

Explanation of Change

Fixed Issues

$ #69171

PROPOSAL:
N/A

Tests

Open the app
Go to Account -> Profile
Click "Contact method"
Click "New contact method"
Enter email
Enter code
Go back or enter second code
Email has been added (Confirmed or not, depending on 7)

Offline tests

n/a

QA Steps

Same as tests

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

0051.android.native.mov

Android: mWeb Chrome

0051.android.chrome.mov

iOS: Native

0051.ios.native.mov

iOS: mWeb Safari

0051.ios.safari.mov

MacOS: Chrome / Safari

0051.desktop.chrome.mov

MacOS: Desktop

0051.desktop.native.mov

…ses-navigation

codecov · 2025-09-30T08:54:46Z

Codecov Report

❌ Patch coverage is 22.50000% with 31 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../Contacts/NewContactMethodConfirmMagicCodePage.tsx	0.00%	15 Missing ⚠️
...settings/Profile/Contacts/NewContactMethodPage.tsx	0.00%	8 Missing ⚠️
src/pages/settings/Profile/Contacts/utils.ts	63.63%	4 Missing ⚠️
src/ROUTES.ts	0.00%	3 Missing ⚠️
...gation/AppNavigator/ModalStackNavigators/index.tsx	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

…ses-navigation

melvin-bot · 2025-10-06T09:02:23Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2025-10-07T17:02:48Z

will review this today

ishpaul777 · 2025-10-07T20:56:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-08.at.11.35.55.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-10-08.at.11.30.59.PM.mov

iOS: HybridApp

Screen.Recording.2025-10-08.at.7.17.46.PM.mov

iOS: mWeb Safari

Untitled.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-08.at.3.37.08.PM.mov

MacOS: Desktop

…ses-navigation

ishpaul777 · 2025-10-08T11:04:35Z

I keep hitting the magic code limit, so I couldn’t finish all the platform videos 😞. I’ll try again a bit later today.

jmusial · 2025-10-08T14:09:22Z

I keep hitting the magic code limit, so I couldn’t finish all the platform videos 😞. I’ll try again a bit later today.

I feel ya :(

Using VPN and a different country helps extend it a little

ishpaul777 · 2025-10-08T18:29:59Z

i dont think its a blocker, but it should be in @libs

nvm i see there are multiple usage of utils in @pages already

ishpaul777 · 2025-10-08T18:36:32Z

Using VPN and a different country helps extend it a little

thnks! will try it next time : )

mountiny · 2025-10-08T18:53:55Z

 */
 function addPendingContactMethod(contactMethod: string) {
-    Onyx.merge(ONYXKEYS.PENDING_CONTACT_ACTION, {
+    return Onyx.merge(ONYXKEYS.PENDING_CONTACT_ACTION, {


I think this violates our philosophy

App/contributingGuides/philosophies/DATA-BINDING.md

Line 23 in 085af64

### - Action methods SHOULD not return a promise

Why do you need to return a promise?

Yeah, it was needed in prev version, forgot but I found a better way :D
Forgot to remove it

but it's was an interesting case.

Basically bc Onyx.merge is async underneath, when I wanted to just update pending action in local onyx and then navigate I could find other way to guarantee that state will be updated when next page renders.

Do you know what would be recommended in that scenario if I cannot return a promise here ?

Not sure for this specific case, but as the rules states the UI should react to the data changes so I would assume we would need to get that logic into some useEffect or something that would listen to the change and run when the onyx change propagates

mountiny · 2025-10-08T18:55:13Z

+            // Waiting for the action to finish before navigating.
+            // Otherwise it may cause an incorrect state on the confirm screen due to async nature of Onyx.merge
+            addPendingContactMethod(submitDetail);


I think there must be some other ways to handle this than returning the promise

mountiny

Thanks!

jmusial · 2025-10-09T13:38:22Z

Fixed.

…ses-navigation

OSBotify · 2025-10-09T16:16:48Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-10T11:12:07Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.29-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-13T20:59:05Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jmusial added 2 commits September 24, 2025 10:15

New contact confirm magic code uses navigation

dcca703

add new confirm page

fde09a0

melvin-bot Bot assigned jmusial Sep 24, 2025

jmusial added 2 commits September 24, 2025 15:14

prettier

2bdeec3

Merge branch 'main' into feat/new-contact-method-confirm-magic-code-u…

d5cb042

…ses-navigation

mhawryluk mentioned this pull request Oct 1, 2025

[Due for payment now] [Tracking] [$1000] Update the ValidateCodeActionModal to be its own screen in the stack #69171

Closed

jmusial added 4 commits October 3, 2025 12:40

Merge branch 'main' into feat/new-contact-method-confirm-magic-code-u…

c2b904e

…ses-navigation

update branch to have email in the confirm url

76c648f

update email shown in the magic code screen msg with correct email

fd330c2

Merge branch 'main' into feat/new-contact-method-confirm-magic-code-u…

0670ba6

…ses-navigation

jmusial marked this pull request as ready for review October 6, 2025 09:02

jmusial requested a review from a team as a code owner October 6, 2025 09:02

melvin-bot Bot requested a review from ishpaul777 October 6, 2025 09:02

melvin-bot Bot removed the request for review from a team October 6, 2025 09:02

Merge branch 'main' into feat/new-contact-method-confirm-magic-code-u…

affb381

…ses-navigation

ishpaul777 reviewed Oct 8, 2025

View reviewed changes

ishpaul777 approved these changes Oct 8, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny October 8, 2025 18:40

mountiny requested changes Oct 8, 2025

View reviewed changes

jmusial added 2 commits October 9, 2025 12:03

remove return promise

8041abc

remove obsolete comment

47240ea

jmusial requested a review from mountiny October 9, 2025 10:09

mountiny previously approved these changes Oct 9, 2025

View reviewed changes

fix a typo I guess

b44c03c

jmusial dismissed mountiny’s stale review via b44c03c October 9, 2025 13:36

Merge branch 'main' into feat/new-contact-method-confirm-magic-code-u…

a252767

…ses-navigation

mountiny approved these changes Oct 9, 2025

View reviewed changes

mountiny merged commit 10d3c4c into Expensify:main Oct 9, 2025
19 checks passed

OSBotify mentioned this pull request Oct 10, 2025

Deploy Checklist: New Expensify 2025-10-10 #72300

Closed

81 tasks

Uh oh!

Conversation

jmusial commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 6, 2025

Uh oh!

ishpaul777 commented Oct 7, 2025

Uh oh!

ishpaul777 commented Oct 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

ishpaul777 commented Oct 8, 2025

Uh oh!

jmusial commented Oct 8, 2025

Uh oh!

ishpaul777 Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

ishpaul777 Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ishpaul777 commented Oct 8, 2025

Uh oh!

mountiny Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 9, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

jmusial commented Oct 9, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 9, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jmusial commented Sep 24, 2025 •

edited

Loading

codecov Bot commented Sep 30, 2025 •

edited

Loading

ishpaul777 commented Oct 7, 2025 •

edited

Loading

ishpaul777 Oct 8, 2025 •

edited

Loading

mountiny Oct 9, 2025 •

edited

Loading