[NoQA] docs: clarify mobile setup steps in README#70864
Merged
mountiny merged 14 commits intoOct 9, 2025
Merged
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
0e628b7 to
3dd89e6
Compare
Signed-off-by: Kamil Stróż <kstroz24@gmail.com>
3dd89e6 to
20f5c9c
Compare
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
CLABotify
added a commit
to Expensify/CLA
that referenced
this pull request
Sep 19, 2025
471df63 to
80c08b3
Compare
adhorodyski
reviewed
Sep 25, 2025
adhorodyski
reviewed
Sep 25, 2025
adhorodyski
reviewed
Sep 25, 2025
adhorodyski
reviewed
Sep 25, 2025
adhorodyski
reviewed
Sep 29, 2025
Contributor
Author
tgolen
previously approved these changes
Oct 8, 2025
|
@dukenv0307 @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
Contributor
|
@kstroz can you please complete the author checklist in the OP template? |
AndrewGable
reviewed
Oct 8, 2025
mountiny
previously approved these changes
Oct 8, 2025
ef581a1
Contributor
Author
|
Applied changes from @AndrewGable and @mountiny if anybody can approve it would awesome! |
Contributor
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.29-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.2.29-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #72118
PROPOSAL: https://expensify.slack.com/archives/C08CZDJFJ77/p1759153172521639
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop