Fix RECEIPT_NOT_SMART_SCANNED violation visibility across Report Preview, LHN, and Search by abzokhattab · Pull Request #70507 · Expensify/App

abzokhattab · 2025-09-12T21:53:02Z

Explanation of Change

Fixed Issues

$ #70038
PROPOSAL: #70038 (comment)

Tests

Create a new workspace
Create a new manual expense
Go to expnse details
Add receipt
Submit the expense
Go to expense preview and validate there is no error indicator
Go to Left Hand Navigation (LHN) and validate there is no error indicator
Go to Reports > Expenses and validate there is no error indicator

Offline tests

Same as tests

QA Steps

same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-12.at.20.07.35.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2025-09-12.at.20.04.05.mov

iOS: mWeb Safari

Screen.Recording.2025-09-13.at.00.04.14.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-12.at.20.02.41.mov

MacOS: Desktop

Screen.Recording.2025-09-13.at.00.16.56.mov

…iew, LHN, and Search

…-scanned-violation-visibility

melvin-bot · 2025-09-15T12:21:14Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

brunovjk · 2025-09-17T13:31:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

70507_android_native.mov

Android: mWeb Chrome

70507_android_web.mov

iOS: HybridApp

70507_ios_native.mov

iOS: mWeb Safari

70507_ios_web.mov

MacOS: Chrome / Safari

70507_web_chrome.mov

MacOS: Desktop

70507_web_desstop.mov

brunovjk · 2025-09-17T21:44:44Z

@abzokhattab, please correct me if I'm wrong, but if I go to a device logged in with an account that is a member of the workspace from which the expense was made, I can see the violation message:

Screen.Recording.2025-09-17.at.18.35.01.mov

This wasn't introduced by this PR, I can reproduce it in staging. But I'm not sure if this should be the expected behavior, what do you think? Thank you.

cc: @blimpich

blimpich · 2025-09-19T15:57:32Z

Sorry for late response here. Not sure I follow. Taking this to Slack to sort out quicker.

brunovjk · 2025-09-27T12:45:28Z

@abzokhattab, please correct me if I'm wrong, but if I go to a device logged in with an account that is a member of the workspace from which the expense was made, I can see the violation message:

Screen.Recording.2025-09-17.at.18.35.01.mov
This wasn't introduced by this PR, I can reproduce it in staging. But I'm not sure if this should be the expected behavior, what do you think? Thank you.

cc: @blimpich

As discussed on Slack, the bug appears to be outside the scope of this PR. Do you agree, @abzokhattab? Can you resolve the conflicts here? I'll proceed with the review. Thank you.

…-scanned-violation-visibility

abzokhattab · 2025-09-28T16:53:18Z

@brunovjk yes, i have the same issue on staging ...regarding the Slack thread, unfortunately, my invitation request to Slack was not accepted yet, so i can't see the discussion thread

abzokhattab · 2025-09-28T16:53:39Z

merged with main 🚀

codecov · 2025-09-28T17:01:02Z

Codecov Report

❌ Patch coverage is 34.78261% with 30 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/Search/index.tsx	0.00%	19 Missing ⚠️
...stReportView/MoneyRequestReportTransactionList.tsx	0.00%	11 Missing ⚠️

Files with missing lines	Coverage Δ
src/libs/ReportPreviewActionUtils.ts	`90.83% <100.00%> (-0.70%)`	⬇️
src/libs/ReportUtils.ts	`73.91% <100.00%> (+0.03%)`	⬆️
src/libs/SearchUIUtils.ts	`69.38% <100.00%> (+0.07%)`	⬆️
src/libs/Violations/ViolationsUtils.ts	`66.77% <100.00%> (+0.98%)`	⬆️
...stReportView/MoneyRequestReportTransactionList.tsx	`2.70% <0.00%> (-0.22%)`	⬇️
src/components/Search/index.tsx	`0.00% <0.00%> (ø)`

... and 49 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brunovjk · 2025-09-29T14:43:45Z

            .filter(Boolean)
            .join(' ');
    },
+


NAB: What do you think about adding a comment to the function? Thanks.

brunovjk · 2025-09-29T15:51:31Z

@abzokhattab I think I found another place that needs updating, what do you think?:

Multiple transactions in a report:

Submit a report with multiple expenses, some with visible violations and some with hidden.
Expected: UI indicators should reflect only visible violations.

Screen.Recording.2025-09-29.at.12.47.00.mov

…-scanned-violation-visibility

abzokhattab · 2025-10-04T13:19:52Z

Good point ... had to filter violations in the MoneyRequestReportTransactionList as well ,, check this commit f3e5f5b

Screen.Recording.2025-10-04.at.15.10.25.mov

can you please take a look

…-scanned-violation-visibility

brunovjk · 2025-10-06T11:02:17Z

It's on my list, I'll review it by the end of the day. Thank you.

brunovjk · 2025-10-07T23:39:29Z

@abzokhattab I can reproduce a bug on Android web:

Create a new account with workspace
Create an expense with an invalid receipt
Wait for the scan to fail
A warning appears about notifications

Android: mWeb Chrome - Our PR

android_web_bug.mov

In stating, doing the same thing, we didn't get the bug:

Android: mWeb Chrome - staging

android_web_main.mov

I don't know how it could be related to our PR, what do you think? Thanks.

abzokhattab · 2025-10-08T07:10:37Z

it seems to be related to notifications, i dont think we have touched this part right?

my guess is that it could be a problem with the build .. try to remove the node modules and reinstall npm and restart the server

brunovjk

LGTM

blimpich · 2025-10-09T19:49:46Z

Looks good but looks like we hit some merge conflicts. @abzokhattab can you merge in the latest main?

…-scanned-violation-visibility

abzokhattab · 2025-10-10T01:02:44Z

there we go .. resolved the conflicts @blimpich

blimpich · 2025-10-10T18:01:12Z

@abzokhattab it looks like we are decreasing test coverage for ReportPreviewActionUtils.ts and MoneyRequestReportTransactionList.tsx. Can maintain their existing levels of coverage (or ideally improve them slightly? We don't want to contribute to them becoming less well covered. Good job on increasing the other three files ⬆️ 👍

abzokhattab · 2025-10-13T14:35:02Z

I added more test cases in the tests/actions/ReportPreviewActionUtilsTest.ts is that enough? is there any other cases please let me know what you think ... as for the MoneyRequestReportTransactionList.tsx we dont have tests file for it

blimpich · 2025-10-13T16:29:54Z

Yeah I think that's good, thank you for adding more tests!

OSBotify · 2025-10-13T16:41:50Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-13T21:19:51Z

🚀 Deployed to staging by https://github.com/blimpich in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-14T17:34:17Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Fix RECEIPT_NOT_SMART_SCANNED violation visibility across Report Prev…

c3fae90

…iew, LHN, and Search

melvin-bot Bot assigned abzokhattab Sep 12, 2025

abzokhattab added 5 commits September 14, 2025 22:08

fix double import

6456973

fixing ts types

8455914

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

3577859

…-scanned-violation-visibility

fixing failing tests

a84ffcc

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

fe2642e

…-scanned-violation-visibility

abzokhattab marked this pull request as ready for review September 15, 2025 12:21

abzokhattab requested a review from a team as a code owner September 15, 2025 12:21

melvin-bot Bot requested review from brunovjk and removed request for a team September 15, 2025 12:21

fixing imports

a10be7d

abzokhattab mentioned this pull request Sep 15, 2025

[Due for payment 2025-10-21] [$250] Expense - Review and red dot display after submit manual expense which add picture to receipt #70038

Closed

8 tasks

bernhardoj mentioned this pull request Sep 16, 2025

[HOLD - E/App #70507] [$250] Scan - The error reappears on the WS chat on the LHN after submitting a scan request #70464

Closed

8 tasks

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

02b3831

…-scanned-violation-visibility

brunovjk reviewed Sep 29, 2025

View reviewed changes

abzokhattab added 2 commits October 4, 2025 14:43

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

33d5a6a

…-scanned-violation-visibility

Filter transaction violations based on user visibility rules

f3e5f5b

abzokhattab added 2 commits October 4, 2025 15:22

adding function comments to hasVisibleViolationsForUser

0bea67f

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

20f4721

…-scanned-violation-visibility

brunovjk approved these changes Oct 9, 2025

View reviewed changes

melvin-bot Bot requested a review from blimpich October 9, 2025 13:05

abzokhattab added 2 commits October 10, 2025 02:58

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

235ff86

…-scanned-violation-visibility

Merge remote-tracking branch 'origin/main' into fix/receipt-not-smart…

e7df872

…-scanned-violation-visibility

Add test coverage for violation filtering

3560612

blimpich approved these changes Oct 13, 2025

View reviewed changes

blimpich merged commit c8541b5 into Expensify:main Oct 13, 2025
20 checks passed

OSBotify mentioned this pull request Oct 13, 2025

Deploy Checklist: New Expensify 2025-10-13 #72503

Closed

92 tasks

Uh oh!

Conversation

abzokhattab commented Sep 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Sep 15, 2025

Uh oh!

brunovjk commented Sep 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk commented Sep 17, 2025

Uh oh!

blimpich commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunovjk commented Sep 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Sep 28, 2025

Uh oh!

abzokhattab commented Sep 28, 2025

Uh oh!

codecov Bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

brunovjk Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

abzokhattab Oct 4, 2025

Choose a reason for hiding this comment

Uh oh!

brunovjk commented Sep 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abzokhattab commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunovjk commented Oct 6, 2025

Uh oh!

brunovjk commented Oct 7, 2025

Uh oh!

abzokhattab commented Oct 8, 2025

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

blimpich commented Oct 9, 2025

Uh oh!

abzokhattab commented Oct 10, 2025

Uh oh!

blimpich commented Oct 10, 2025

Uh oh!

abzokhattab commented Oct 13, 2025

Uh oh!

blimpich commented Oct 13, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 13, 2025

Uh oh!

OSBotify commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

abzokhattab commented Sep 12, 2025 •

edited

Loading

brunovjk commented Sep 17, 2025 •

edited

Loading

blimpich commented Sep 19, 2025 •

edited

Loading

brunovjk commented Sep 27, 2025 •

edited

Loading

codecov Bot commented Sep 28, 2025 •

edited

Loading

brunovjk commented Sep 29, 2025 •

edited

Loading

abzokhattab commented Oct 4, 2025 •

edited

Loading