Skip to content

fix: Hide Copy to clipboard for IOU comments - #7045

Merged
thienlnam merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/hide-iou-copy-clipboard
Jan 5, 2022
Merged

fix: Hide Copy to clipboard for IOU comments#7045
thienlnam merged 1 commit into
Expensify:mainfrom
mananjadhav:fix/hide-iou-copy-clipboard

Conversation

@mananjadhav

Copy link
Copy Markdown
Collaborator

Details

  • Hide Copy to clipboard action for IOU transactions

Fixed Issues

$ #7009

Tests

  1. Tested for all IOU transactions (self and the other party)

QA Steps

  1. Go to any chat list with IOU transactions
  2. Right-click on Web/Desktop (and long press on mobile) on any IOU transaction
  3. Copy to clipboard shouldn't show up.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web-iou-hide-copy-to-clipboard

Mobile Web

mweb-iou-hide-copy-to-clipboard

Desktop

desktop-iou-hide-copy-to-clipboard

iOS

ios-iou-hide-copy-to-clipboard

Android

android-iou-hide-copy-to-clipboard

@mananjadhav
mananjadhav requested a review from a team as a code owner January 5, 2022 21:45
@MelvinBot
MelvinBot requested review from parasharrajat and thienlnam and removed request for a team January 5, 2022 21:45

@parasharrajat parasharrajat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cc: @thienlnam

🎀 👀 🎀 C+ reviewed

@thienlnam
thienlnam merged commit 60e6f3b into Expensify:main Jan 5, 2022
@OSBotify

OSBotify commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

OSBotify commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @thienlnam in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.26-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants