Skip to content

use getLocalMomentFromTimestamp - #7022

Merged
tgolen merged 4 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui-ux/fix-date-flicker
Jan 5, 2022
Merged

use getLocalMomentFromTimestamp#7022
tgolen merged 4 commits into
Expensify:mainfrom
thesahindia:thesahindia/ui-ux/fix-date-flicker

Conversation

@thesahindia

@thesahindia thesahindia commented Jan 4, 2022

Copy link
Copy Markdown
Member

Details

fixed date format flicker in details page

Fixed Issues

$ #6779

Tests

QA Steps

  1. Set the app language to English
  2. Navigate to a conversation
  3. Click on the header to open the user details page
  4. Notice the time format
  5. Refresh the page

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen.Recording.2022-01-04.at.6.42.45.PM.mov

Mobile Web

Screen.Recording.2022-01-04.at.6.44.46.PM.mov

Desktop

Screen.Recording.2022-01-04.at.11.04.44.PM.mov

iOS

Screen.Recording.2022-01-04.at.10.55.31.PM.mov

Android

Screen.Recording.2022-01-04.at.10.54.57.PM.mov

@thesahindia
thesahindia requested a review from a team as a code owner January 4, 2022 13:22
@MelvinBot
MelvinBot requested review from parasharrajat and tgolen and removed request for a team January 4, 2022 13:22
Comment thread src/pages/home/report/ParticipantLocalTime.js Outdated
Comment thread src/pages/home/report/ParticipantLocalTime.js Outdated
Comment thread src/libs/DateUtils.js Outdated
@parasharrajat

Copy link
Copy Markdown
Member

Could you please add videos for remaining platforms as well?

Comment thread src/libs/DateUtils.js Outdated
Comment thread src/libs/DateUtils.js Outdated
Comment thread src/pages/home/report/ParticipantLocalTime.js Outdated
@thesahindia

Copy link
Copy Markdown
Member Author

@tgolen @parasharrajat
Updated the PR!

@tgolen tgolen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick update! I had mentioned this in the original issue and I think it would help to improve this code a little further.

Comment thread src/pages/home/report/ParticipantLocalTime.js Outdated
@thesahindia

Copy link
Copy Markdown
Member Author

bump @tgolen

@tgolen tgolen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@tgolen
tgolen merged commit 117995f into Expensify:main Jan 5, 2022
@OSBotify

OSBotify commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat

parasharrajat commented Jan 5, 2022

Copy link
Copy Markdown
Member

I was going to report that when we refresh the page AM/ PM disappears. @thesahindia . But this is merged.

cc: @tgolen

Actually, sorry that is on staging and working fine on this PR.

@OSBotify

OSBotify commented Jan 6, 2022

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @tgolen in version: 1.1.25-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @Jag96 in version: 1.1.26-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants