Skip to content

Do not render reimbursable URLs for QBD and Intacct #70216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
francoisl merged 10 commits into from
Sep 15, 2025
Merged

Do not render reimbursable URLs for QBD and Intacct #70216

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
2bf8f15
do not render reimbursable URLs for QBD and Intacct
lakchote Sep 9, 2025
5d61574
fix prettier
lakchote Sep 9, 2025
acd76c3
Merge branch 'main' into lucien/fix-intacct-reimbursableLink
lakchote Sep 9, 2025
ccd7abd
add other Intacct key
lakchote Sep 10, 2025
457ce2b
fix logic
lakchote Sep 10, 2025
3f34bfa
new logic to hide reimbursable links not supported
lakchote Sep 10, 2025
dc496cc
Merge branch 'main' into lucien/fix-intacct-reimbursableLink
lakchote Sep 10, 2025
2185b02
Merge branch 'main' into lucien/fix-intacct-reimbursableLink
lakchote Sep 10, 2025
9221dc5
Update src/CONST/index.ts
lakchote Sep 11, 2025
49d0fd9
Merge branch 'main' into lucien/fix-intacct-reimbursableLink
lakchote Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/libs/ReportActionsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
type MemberChangeMessageElement = MessageTextElement | MemberChangeMessageUserMentionElement | MemberChangeMessageRoomReferenceElement;

let allReportActions: OnyxCollection<ReportActions>;
Onyx.connect({

Check warning on line 60 in src/libs/ReportActionsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT_ACTIONS,
waitForCollectionCallback: true,
callback: (actions) => {
Expand All @@ -69,7 +69,7 @@
});

let allReports: OnyxCollection<Report>;
Onyx.connect({

Check warning on line 72 in src/libs/ReportActionsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.COLLECTION.REPORT,
waitForCollectionCallback: true,
callback: (value) => {
Expand All @@ -78,14 +78,14 @@
});

let isNetworkOffline = false;
Onyx.connect({

Check warning on line 81 in src/libs/ReportActionsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.NETWORK,
callback: (val) => (isNetworkOffline = val?.isOffline ?? false),
});

let currentUserAccountID: number | undefined;
let currentEmail = '';
Onyx.connect({

Check warning on line 88 in src/libs/ReportActionsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.SESSION,
callback: (value) => {
// When signed out, value is undefined
Expand All @@ -99,7 +99,7 @@
});

let privatePersonalDetails: PrivatePersonalDetails | undefined;
Onyx.connect({

Check warning on line 102 in src/libs/ReportActionsUtils.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
key: ONYXKEYS.PRIVATE_PERSONAL_DETAILS,
callback: (personalDetails) => {
privatePersonalDetails = personalDetails;
Expand Down Expand Up @@ -2146,11 +2146,13 @@
url: '',
});
}

if (reimbursableUrls.length === 1) {
const shouldAddPeriod = nonReimbursableUrls.length === 0;
const reimbursableUrl = reimbursableUrls.at(0) ?? '';
result.push({
text: translateLocal('report.actions.type.exportedToIntegration.reimburseableLink') + (shouldAddPeriod ? '.' : ''),
url: reimbursableUrls.at(0) ?? '',
url: reimbursableUrl.startsWith('https://') ? reimbursableUrl : '',
});
}
if (reimbursableUrls.length === 1 && nonReimbursableUrls.length) {
Expand All @@ -2164,7 +2166,8 @@
let url = '';

if (nonReimbursableUrls.length === 1) {
url = nonReimbursableUrls.at(0) ?? '';
const nonReimbursableUrl = nonReimbursableUrls.at(0) ?? '';
url = nonReimbursableUrl.startsWith('https://') ? nonReimbursableUrl : '';
} else {
switch (label) {
case CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY.xero:
Expand Down
Loading