-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Reports - Details of last created expense, are not seen on preview on "Submit" while offline #70181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+57
−2
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
96c633a
fix: preview issue on submit in offline
mkzie2 0d5921b
fix: preview issue on submit in offline
mkzie2 d0c96e1
fix: preview issue on submit in offline
mkzie2 c71f0f4
chore: add test cases
mkzie2 f49b37e
Merge branch 'main' of https://github.com/Expensify/App into mkzie2-i…
mkzie2 00fe757
Merge branch 'main' of https://github.com/Expensify/App into mkzie2-i…
mkzie2 be548cf
merge main
mkzie2 543de3e
Merge branch 'main' into mkzie2-issue/v2/68827
mkzie2 e0cb1bb
Merge branch 'main' into mkzie2-issue/v2/68827
mkzie2 49cde65
fix getCurrentSearchQueryJSON issue
mkzie2 0e8c8f8
Merge branch 'main' into mkzie2-issue/v2/68827
mkzie2 ea13a90
Update src/libs/SearchUIUtils.ts
mkzie2 2fde184
Merge branch 'main' into mkzie2-issue/v2/68827
mkzie2 5681000
run prettier
mkzie2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are we doing here?
lastSearchNavigatorState. What is the reason for this change?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix this function to return the correct query JSON then the new expense can be updated on Search page in offline.
App/src/libs/Navigation/AppNavigator/createSearchFullscreenNavigator/useCustomState/index.ts
Line 10 in d37feb1
Because the preserved state of full-screen navigator only stores the last route, the search root page doesn't appear in the preserved state if we open the search money request page.
App/src/libs/Navigation/AppNavigator/createSearchFullscreenNavigator/useCustomState/index.ts
Line 10 in d37feb1