Fix imported transactions are displayed as skeleton loader

[nkdengineer]

Explanation of Change

Fixed Issues

$ #67644
PROPOSAL: #67644 (comment)

Tests

Precondition:

• User has added Wells Fargo card feed and assigned themselves Plaid Credit Card 3333.
• There is at least one imported card transaction.

1. Go to workspace chat.
2. Go to workspace settings > Company cards.
3. Click Settings.
4. Click Remove card feed > Delete.
5. Go to workspace chat.
6. Verify that: The imported transactions will be completely removed.

• Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[melvin-bot]

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[nkdengineer]

It seems there's some connection issues. I'll try again and add screenshots later

[trjExpensify]

Agree with the expectation that the transactions on an open report should be deleted when the feed is deleted. 👍

[mananjadhav]

@nkdengineer Are you able upload the screenshots now?

[mananjadhav]

Quick bump @nkdengineer

[nkdengineer]

@mananjadhav i still can't connect the company card. Could you please check this flow in your end?

[mananjadhav]

Let me try that on my end and see if it works for me.

[nkdengineer]

@mananjadhav Sorry but I think @c3024 should be the reviewer here since he reviewed the proposal in the issue.

[mananjadhav]

@mananjadhav Sorry but I think @c3024 should be the reviewer here since he reviewed the proposal in the issue.

Ohh got it. I thought this was one of the issues where there was no reviewer. Cool let's have @c3024. In case they're not available I can help.

[mananjadhav]

It's been a week the PR has been reviewed. @trjExpensify Do you want me to finish it? (I accidentally reviewed the code already assuming I was the C+).

[trjExpensify]

Yep, do it. 👍

[mananjadhav]

@nkdengineer The change doesn't seem to be working. I had a company card feed, which I deleted based on the steps. The transactions are still visible in the preview. But when I click to open the transaction report, I don't see them.

web-card-feed-delete.mov

web-card-feed-delete-2.mov

[c3024]

I was accidentally unassigned here on the linked issue so this PR never appeared in my notifications.

TY for handling this. @mananjadhav

[mananjadhav]

Quick bump on this @nkdengineer in case you missed.

Thanks for the help @c3024 :)

[nkdengineer]

Quick bump on #69492 (comment) @nkdengineer in case you missed.

@mananjadhav When you enable Allow deleting transaction, the backend doesn't return an update that clears these card transactions. And if we open the expense report, the backend still returns these transactions.

[mananjadhav]

Approving as code change is fine and want @techievivek to take a look at the comment

[mananjadhav]

I think then we should get this fixed on the BE and then retest on FE?

[techievivek]

The change doesn't seem to be working. I had a company card feed, which I deleted based on the steps. The transactions are still visible in the preview. But when I click to open the transaction report, I don't see them.

Oh, actually. I am looking at the code, and the backend does seem to be queuing updates to clear transactions on open reports. So why are we still seeing the transactions in previews?

[techievivek]

When you enable Allow deleting transaction, the backend doesn't return an update that clears these card transactions. And if we open the expense report, the backend still returns these transactions.

I am confused about this comment in particular, what does Allow deleting transaction do, and where do we enable that? And as I can see from the backend code, we do push updates to clear the card transactions so which part is actually not working as expected?

[techievivek]

Ok, digging further, I see the option Allow deleting transaction, but how does it relate to the bug we see here? I don't think @mananjadhav manually deleted any transactions, but deleted the card feed.

[mananjadhav]

Yes I deleted the card feed. I didn't manually delete transactions.

[techievivek]

@nkdengineer Can you please take a look at the above comments and help me understand the change? Thanks.

[nkdengineer]

@techievivek From our testing, this case doesn't work as expected since the backend doesn't return an update that clears the card transaction

[techievivek]

Discussing on Slack https://expensify.slack.com/archives/C01GTK53T8Q/p1758277505345179

[techievivek]

Discussing on Slack here https://expensify.slack.com/archives/C01GTK53T8Q/p1758806762768339?thread_ts=1758277505.345179&cid=C01GTK53T8Q since I can't find any issue in our backend code that would handle queuing updates differently when Allow deleting transaction is enabled on card feed settings.

[techievivek]

The fix has been merged and should be deployed by end of the day today. I will confirm once it’s live, and then we can verify everything is working as expected. Thanks for flagging this 🙇

[mananjadhav]

Thanks, will wait for the update.

[techievivek]

@mananjadhav @nkdengineer backend changes are deployed, can we get a re-test here? Thanks.

[nkdengineer]

@techievivek Works well now.

[techievivek]

Nice, thanks for confirming.

[techievivek]

@mananjadhav Can you fill up the PR reviewer checklist here?

[mananjadhav]

Yes I'll work on the checklist and finish the testing by weekend.

[techievivek]

Friendly bump @mananjadhav, thanks.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #69492      +/-   ##
==========================================
- Coverage   35.17%   35.14%   -0.04%     
==========================================
  Files        3290     3291       +1     
  Lines      107852   107963     +111     
  Branches    34421    34472      +51     
==========================================
+ Hits        37942    37946       +4     
- Misses      69725    69830     +105     
- Partials      185      187       +2     

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mananjadhav]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

mweb-chrome-card-feed.mov

iOS: HybridApp

ios-card-feed.mov

iOS: mWeb Safari

mweb-safari-card-feed.mov

MacOS: Chrome / Safari

web-delete-card-feed.mov

MacOS: Desktop

desktop-delete-card-feed.mov

[mananjadhav]

Issues with my android build. Just finished the checklist. @techievivek All yours.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/techievivek in version: 9.2.30-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.30-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅