[NO QA] Add CLAUDE.md documentation for App repository#68547
Conversation
|
We can ignore the test builds, this is just a md file change. |
|
Bumping this @amyevans 👼 |
|
Sorry 🙈! The day is getting away from me but I can look in a few hours! |
amyevans
left a comment
There was a problem hiding this comment.
Some NABs but feel free to merge if you want to skip them!
|
|
||
| ## Key Features & Modules | ||
|
|
||
| ### Core Functionality |
There was a problem hiding this comment.
(NAB) I am curious how these lists help. Have you noticed including them makes a difference? I would assume it could find this sort of context in HelpDot in the repo?
There was a problem hiding this comment.
It's a great question, and I'm not 100% sure, but I actually got Claude to generate this file. Theres a built in command that I used so I assume it is a good format. Then I removed anything I didn't think was necessary to trim it down.
So I think it's fine as a start. But I will add links to the HelpDot site!
There was a problem hiding this comment.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
@amyevans looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
The failing checks were unrelated, removing |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/amyevans in version: 9.1.96-0 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.96-2 🚀
|
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.1.96-2 🚀
|
Explanation of Change
This PR adds CLAUDE.md documentation to provide comprehensive overview of the App repository structure, architecture, and development practices.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/536386
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.