Skip to content

Merge subscription.compareModal translation #68252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 2 commits into from
Aug 14, 2025
Merged

Merge subscription.compareModal translation #68252

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1335bca
Merge subscription.compareModal translation
shubham1206agra Aug 9, 2025
34ff80f
Fixed minor mistake
shubham1206agra Aug 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/languages/de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6769,9 +6769,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Pläne vergleichen',
unlockTheFeatures: 'Schalten Sie die Funktionen frei, die Sie benötigen, mit dem Plan, der für Sie richtig ist.',
viewOurPricing: 'Sehen Sie sich unsere Preisseite an',
forACompleteFeatureBreakdown: 'für eine vollständige Funktionsübersicht unserer Pläne.',
subtitle: `<muted-text>Schalten Sie die Funktionen frei, die Sie benötigen, und wählen Sie den für Sie passenden Tarif. <a href="${CONST.PRICING}">Sehen Sie sich unsere Preisseite</a> oder eine vollständige Aufschlüsselung der Funktionen jedes unserer Tarife an.</muted-text>`,
},
details: {
title: 'Abonnementdetails',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6733,9 +6733,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Compare Plans',
unlockTheFeatures: 'Unlock the features you need with the plan that’s right for you. ',
viewOurPricing: 'View our pricing page',
forACompleteFeatureBreakdown: ' for a complete feature breakdown of each of our plans.',
subtitle: `<muted-text>Unlock the features you need with the plan that’s right for you. <a href="${CONST.PRICING}">View our pricing page</a> or a complete feature breakdown of each of our plans.</muted-text>`,
},
details: {
title: 'Subscription details',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7221,9 +7221,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Comparar planes',
unlockTheFeatures: 'Desbloquea las funciones que necesitas con el plan adecuado para ti. ',
viewOurPricing: 'Consulta nuestra página de precios',
forACompleteFeatureBreakdown: ' para ver un desglose completo de las funciones de cada uno de nuestros planes.',
subtitle: `<muted-text>Desbloquea las funciones que necesitas con el plan adecuado para ti. <a href="${CONST.PRICING}">Consulta nuestra página de precios</a> para ver un desglose completo de las funciones de cada uno de nuestros planes.</muted-text>`,
},
details: {
title: 'Datos de suscripción',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/fr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6780,9 +6780,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Comparer les forfaits',
unlockTheFeatures: 'Débloquez les fonctionnalités dont vous avez besoin avec le plan qui vous convient.',
viewOurPricing: 'Consultez notre page de tarification',
forACompleteFeatureBreakdown: 'pour un aperçu complet des fonctionnalités de chacun de nos plans.',
subtitle: `<muted-text>Débloquez les fonctionnalités dont vous avez besoin avec le forfait qui vous convient. <a href="${CONST.PRICING}">Consultez notre page de tarifs</a> ou la liste complète des fonctionnalités de chacun de nos forfaits.</muted-text>`,
},
details: {
title: "Détails de l'abonnement",
Expand Down
4 changes: 1 addition & 3 deletions src/languages/it.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6781,9 +6781,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Confronta i piani',
unlockTheFeatures: 'Sblocca le funzionalità di cui hai bisogno con il piano giusto per te.',
viewOurPricing: 'Visualizza la nostra pagina dei prezzi',
forACompleteFeatureBreakdown: 'per una panoramica completa delle funzionalità di ciascuno dei nostri piani.',
subtitle: `<muted-text>Sblocca le funzionalità di cui hai bisogno con il piano più adatto a te. <a href="${CONST.PRICING}">Consulta la nostra pagina dei prezzi</a> o una panoramica completa delle funzionalità di ciascuno dei nostri piani.</muted-text>`,
},
details: {
title: "Dettagli dell'abbonamento",
Expand Down
4 changes: 1 addition & 3 deletions src/languages/ja.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6733,9 +6733,7 @@ const translations = {
},
compareModal: {
comparePlans: 'プランを比較',
unlockTheFeatures: 'あなたに合ったプランで必要な機能をアンロックしましょう。',
viewOurPricing: '料金ページをご覧ください',
forACompleteFeatureBreakdown: '各プランの機能の詳細な内訳については、こちらをご覧ください。',
subtitle: `<muted-text>必要な機能を解放しましょう。あなたに最適なプランを選択してください。<a href="${CONST.PRICING}">料金ページをご覧いただくか</a>、各プランの機能詳細をご確認ください。</muted-text>`,
},
details: {
title: 'サブスクリプションの詳細',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/nl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6771,9 +6771,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Vergelijk Plannen',
unlockTheFeatures: 'Ontgrendel de functies die je nodig hebt met het plan dat bij je past.',
viewOurPricing: 'Bekijk onze prijspagina',
forACompleteFeatureBreakdown: 'voor een volledige functieverdeling van elk van onze plannen.',
subtitle: `<muted-text>Ontgrendel de functies die u nodig hebt met het abonnement dat bij u past. <a href="${CONST.PRICING}">Bekijk onze prijspagina</a> of een volledig overzicht van de functies van elk van onze abonnementen.</muted-text>`,
},
details: {
title: 'Abonnementsgegevens',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/pl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6756,9 +6756,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Porównaj plany',
unlockTheFeatures: 'Odblokuj potrzebne funkcje dzięki planowi, który jest dla Ciebie odpowiedni.',
viewOurPricing: 'Zobacz naszą stronę z cennikiem',
forACompleteFeatureBreakdown: 'aby uzyskać pełny podział funkcji każdego z naszych planów.',
subtitle: `<muted-text>Odblokuj potrzebne funkcje dzięki planowi, który najlepiej odpowiada Twoim potrzebom. <a href="${CONST.PRICING}">Zapoznaj się z naszą stroną z cennikiem</a> lub pełnym zestawieniem funkcji każdego z naszych planów.</muted-text>`,
},
details: {
title: 'Szczegóły subskrypcji',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/pt-BR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6769,9 +6769,7 @@ const translations = {
},
compareModal: {
comparePlans: 'Comparar Planos',
unlockTheFeatures: 'Desbloqueie os recursos que você precisa com o plano certo para você.',
viewOurPricing: 'Veja nossa página de preços',
forACompleteFeatureBreakdown: 'para uma análise completa dos recursos de cada um dos nossos planos.',
subtitle: `<muted-text>Desbloqueie os recursos de que você precisa com o plano ideal para você. <a href="${CONST.PRICING}">Consulte nossa página de preços</a> ou uma descrição completa dos recursos de cada um dos nossos planos.</muted-text>`,
},
details: {
title: 'Detalhes da assinatura',
Expand Down
4 changes: 1 addition & 3 deletions src/languages/zh-hans.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6639,9 +6639,7 @@ const translations = {
},
compareModal: {
comparePlans: '比较计划',
unlockTheFeatures: '选择适合您的计划，解锁您所需的功能。',
viewOurPricing: '查看我们的定价页面',
forACompleteFeatureBreakdown: '查看我们每个计划的完整功能细分。',
subtitle: `<muted-text>使用适合您的计划，释放您所需的功能。<a href="${CONST.PRICING}">查看我们的定价页面</a>或每个计划的完整功能明细。</muted-text>`,
},
details: {
title: '订阅详情',
Expand Down
11 changes: 4 additions & 7 deletions src/pages/settings/Subscription/SubscriptionPlan/ComparePlansModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,9 @@ import {View} from 'react-native';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import Modal from '@components/Modal';
import type {AnimationOut} from '@components/Modal/ReanimatedModal/types';
import RenderHTML from '@components/RenderHTML';
import SafeAreaConsumer from '@components/SafeAreaConsumer';
import ScrollView from '@components/ScrollView';
import Text from '@components/Text';
import TextLink from '@components/TextLink';
import useLocalize from '@hooks/useLocalize';
import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeStyles from '@hooks/useThemeStyles';
Expand Down Expand Up @@ -44,11 +43,9 @@ function ComparePlansModal({isModalVisible, setIsModalVisible}: ComparePlansModa

const renderPlans = () => (
<View style={isSmallScreenWidth ? [styles.ph4, styles.pb8] : [styles.ph8, styles.pb8]}>
<Text style={[styles.textLabelSupporting, styles.textNormal]}>
{translate('subscription.compareModal.unlockTheFeatures')}
<TextLink href={CONST.PRICING}>{translate('subscription.compareModal.viewOurPricing')}</TextLink>
{translate('subscription.compareModal.forACompleteFeatureBreakdown')}
</Text>
<View style={[styles.renderHTML]}>
<RenderHTML html={translate('subscription.compareModal.subtitle')} />
</View>
<View style={isSmallScreenWidth ? styles.flexColumn : [styles.flexRow, styles.gap3]}>
<SubscriptionPlanCard
subscriptionPlan={CONST.POLICY.TYPE.TEAM}
Expand Down
4 changes: 2 additions & 2 deletions tests/ui/BottomTabBarTest.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ describe('NavigationTabBar', () => {
<ComposeProviders components={[OnyxListItemProvider, LocaleContextProvider, SidebarOrderedReportsContextProvider]}>
<NavigationContainer>
<NavigationTabBar selectedTab={NAVIGATION_TABS.SETTINGS} />
</NavigationContainer>{' '}
</NavigationContainer>

@shubham1206agra shubham1206agra Aug 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a minor change in tests. And it does not need testing.

@allgandalf allgandalf Aug 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool thanks!

</ComposeProviders>,
);

Expand All @@ -127,7 +127,7 @@ describe('NavigationTabBar', () => {
<ComposeProviders components={[OnyxListItemProvider, LocaleContextProvider, SidebarOrderedReportsContextProvider]}>
<NavigationContainer>
<NavigationTabBar selectedTab={NAVIGATION_TABS.SETTINGS} />
</NavigationContainer>{' '}
</NavigationContainer>
</ComposeProviders>,
);

Expand Down
Loading