Skip to content

[NO QA] Bugfix/remove connect encrypted auth token #68040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
danieldoglas merged 7 commits into from
Aug 8, 2025
Merged

[NO QA] Bugfix/remove connect encrypted auth token #68040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ffda816
Replace connect with connectWithoutView
pasyukevich Aug 6, 2025
b248d4f
update --max-warnings
pasyukevich Aug 6, 2025
664985f
Merge branch 'main' into buffix/remove-connect-encryptedAuthToken
pasyukevich Aug 7, 2025
ef44873
Enhance addEncryptedAuthTokenToURL.ts with comments explaining the us…
pasyukevich Aug 7, 2025
66471b1
Update ESLint max warnings limit
pasyukevich Aug 7, 2025
1fac6c5
Merge branch 'main' into buffix/remove-connect-encryptedAuthToken
pasyukevich Aug 7, 2025
b361319
Merge branch 'main' into buffix/remove-connect-encryptedAuthToken
pasyukevich Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=283 --cache --cache-location=node_modules/.cache/eslint",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=282 --cache --cache-location=node_modules/.cache/eslint",
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
"lint-watch": "npx eslint-watch --watch --changed",
"shellcheck": "./scripts/shellCheck.sh",
Expand Down
5 changes: 4 additions & 1 deletion src/libs/addEncryptedAuthTokenToURL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,10 @@ import Onyx from 'react-native-onyx';
import ONYXKEYS from '@src/ONYXKEYS';

let encryptedAuthToken = '';
Onyx.connect({
// We use `connectWithoutView` here since this connection only updates a module-level variable
// and doesn't need to trigger component re-renders. UI components get the current token
// value when they call the exported function.
Onyx.connectWithoutView({

@allgandalf allgandalf Aug 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add a comment explaining why we used without view here, since it's not connected to any UI we can use it

@allgandalf allgandalf Aug 7, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can see other no QA pr's to get an idea

@pasyukevich pasyukevich Aug 7, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated with comment

key: ONYXKEYS.SESSION,
callback: (session) => (encryptedAuthToken = session?.encryptedAuthToken ?? ''),
});
Expand Down
Loading