Skip to content

[NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in PersistedRequests #67898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 3 commits into from
Aug 8, 2025
Merged

[NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in PersistedRequests #67898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4254e2e
Replaced Onyx.connect with Onyx.connectWithoutView in PersistedRequests
shubham1206agra Aug 5, 2025
dac6314
Merge branch 'main' into refactor-onyx-38
shubham1206agra Aug 7, 2025
f98d8a4
Merge branch 'main' into refactor-onyx-38
shubham1206agra Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
"test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
"perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
"typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=294 --cache --cache-location=node_modules/.cache/eslint",
"lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=292 --cache --cache-location=node_modules/.cache/eslint",
"lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
"lint-watch": "npx eslint-watch --watch --changed",
"shellcheck": "./scripts/shellCheck.sh",
Expand Down
6 changes: 4 additions & 2 deletions src/libs/actions/PersistedRequests.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ import type {Request} from '@src/types/onyx';
let persistedRequests: Request[] = [];
let ongoingRequest: Request | null = null;

Onyx.connect({
// We have opted for connectWithoutView here as this module is strictly non-UI
Onyx.connectWithoutView({
key: ONYXKEYS.PERSISTED_REQUESTS,
callback: (val) => {
Log.info('[PersistedRequests] hit Onyx connect callback', false, {isValNullish: val == null});
Expand All @@ -24,7 +25,8 @@ Onyx.connect({
}
},
});
Onyx.connect({
// We have opted for connectWithoutView here as this module is strictly non-UI
Onyx.connectWithoutView({
key: ONYXKEYS.PERSISTED_ONGOING_REQUESTS,
callback: (val) => {
ongoingRequest = val ?? null;
Expand Down
Loading