[No QA]: Refactor src/libs/actions/Link.ts to remove Onyx.connect() references

package.json

@@ -46,7 +46,7 @@
     "test:debug": "TZ=utc NODE_OPTIONS='--inspect-brk --experimental-vm-modules' jest --runInBand",
     "perf-test": "NODE_OPTIONS=--experimental-vm-modules npx reassure",
     "typecheck": "NODE_OPTIONS=--max_old_space_size=8192 tsc",
-    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=285 --cache --cache-location=node_modules/.cache/eslint",
+    "lint": "NODE_OPTIONS=--max_old_space_size=8192 eslint . --max-warnings=283 --cache --cache-location=node_modules/.cache/eslint",
     "lint-changed": "NODE_OPTIONS=--max_old_space_size=8192 ./scripts/lintChanged.sh",
     "lint-watch": "npx eslint-watch --watch --changed",
     "shellcheck": "./scripts/shellCheck.sh",

src/libs/actions/Link.ts

@@ -15,14 +15,16 @@ import ROUTES from '@src/ROUTES';
 import {canAnonymousUserAccessRoute, isAnonymousUser, signOutAndRedirectToSignIn} from './Session';
 
 let isNetworkOffline = false;
-Onyx.connect({
+// Use connectWithoutView since this is to open an external link and doesn't affect any UI
+Onyx.connectWithoutView({
     key: ONYXKEYS.NETWORK,
     callback: (value) => (isNetworkOffline = value?.isOffline ?? false),
 });
 
 let currentUserEmail = '';
 let currentUserAccountID: number = CONST.DEFAULT_NUMBER_ID;
-Onyx.connect({
+// Use connectWithoutView since this is to open an external link and doesn't affect any UI
+Onyx.connectWithoutView({
     key: ONYXKEYS.SESSION,
     callback: (value) => {
         currentUserEmail = value?.email ?? '';
@@ -237,15 +239,4 @@ function getTravelDotLink(policyID: OnyxEntry<string>) {
     });
 }
 
-export {
-    buildOldDotURL,
-    openOldDotLink,
-    openExternalLink,
-    openLink,
-    getInternalNewExpensifyPath,
-    getInternalExpensifyPath,
-    openTravelDotLink,
-    buildTravelDotURL,
-    openExternalLinkWithToken,
-    getTravelDotLink,
-};
+export {openOldDotLink, openExternalLink, openLink, getInternalNewExpensifyPath, getInternalExpensifyPath, openTravelDotLink, buildTravelDotURL, openExternalLinkWithToken, getTravelDotLink};