Migrate AttachmentModalContainer to use the Reanimated modal#67480
Closed
mhawryluk wants to merge 2 commits into
Closed
Migrate AttachmentModalContainer to use the Reanimated modal#67480mhawryluk wants to merge 2 commits into
mhawryluk wants to merge 2 commits into
Conversation
Contributor
Author
|
currently, there is a bug in reanimated that causes always the first attachment to be displayed during the exiting animation on web, even when a different one is selected. I created a PR fixing this: software-mansion/react-native-reanimated#7942 |
Contributor
Author
|
moved here: #68343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #64776
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Nagranie.z.ekranu.2025-08-8.o.18.03.14.mov
Android: mWeb Chrome
Nagranie.z.ekranu.2025-08-8.o.18.08.19.mov
iOS: Native
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-08-08.at.18.04.22.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.16.Pro.Max.-.2025-08-08.at.18.06.39.mp4
MacOS: Chrome / Safari
Nagranie.z.ekranu.2025-08-8.o.18.01.52.mov
MacOS: Desktop
Nagranie.z.ekranu.2025-08-8.o.18.11.41.mov