Skip to content

Troubleshoot flags persistance #67155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cristipaval merged 2 commits into from
Aug 12, 2025
Merged

Troubleshoot flags persistance #67155

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9d1883
Troubleshoot flags persistance
martasudol Jul 25, 2025
56fa271
simplified approach: fixed toggling Use Staging Server flag
martasudol Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/actions/SignInRedirect.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
let currentShouldForceOffline: boolean | undefined;
Onyx.connect({
key: ONYXKEYS.NETWORK,
callback: (network) => {

Check warning on line 12 in src/libs/actions/SignInRedirect.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check 

Onyx.connect() is deprecated. Use useOnyx() hook instead and pass the data as parameters to a pure function
currentIsOffline = network?.isOffline;
currentShouldForceOffline = network?.shouldForceOffline;
},
Expand All @@ -25,6 +25,7 @@
keysToPreserve.push(ONYXKEYS.PREFERRED_THEME);
keysToPreserve.push(ONYXKEYS.ACTIVE_CLIENTS);
keysToPreserve.push(ONYXKEYS.DEVICE_ID);
keysToPreserve.push(ONYXKEYS.ACCOUNT);

@hoangzinh hoangzinh Sep 11, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coming from this issue, it causes an issue of an edge case with Copilot mode. Please check out this proposal for more details #69133 (comment)


// After signing out, set ourselves as offline if we were offline before logging out and we are not forcing it.
// If we are forcing offline, ignore it while signed out, otherwise it would require a refresh because there's no way to toggle the switch to go back online while signed out.
Expand Down
Loading