chore: Clean up file-level `kycWallRef` by dominictb · Pull Request #67036 · Expensify/App

dominictb · 2025-07-24T08:59:41Z

Explanation of Change

Referencing a ref object in a separated file that is not attached to React component lifecycle is a deprecated pattern. This PR refactors kycWallRef so that it is now referenced via a global Context.

Fixed Issues

$ #64602
PROPOSAL:

Tests

Precondition:

Workspace has Workflow enabled but not connected a bank account

As workspace member, submit an expense
As workspace admin, approve the expense > Pay > Pay with business account
Verify you are navigated to business bank account connection flow
Proceed to add a bank account
Verify the bank is added to the workspace
Press Pay button
Verify the report is paid

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-10-02.at.20.51.19-compressed.mov

MacOS: Desktop

…hore/64602

melvin-bot · 2025-07-30T17:33:36Z

@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-07-30T17:34:09Z

Lint failures are not related to this PR

…hore/64602

dominictb · 2025-08-07T02:07:20Z

Friendly bump @allroundexperts

allroundexperts · 2025-08-11T23:29:31Z

Hi @dominictb!
I am OoO till this Tuesday. Will review this ASAP once back.

allroundexperts · 2025-08-14T12:47:46Z

Hi @dominictb,
Can you resolve the conflicts please?

…hore/64602

dominictb · 2025-08-18T14:59:36Z

Resolved.

allroundexperts · 2025-08-26T14:35:36Z

+        source,
+        shouldShowPersonalBankAccountOption = false,
+    }: KYCWallProps,
+    ref: ForwardedRef<KYCWallRef>,


I think we are getting rid of forward refs. Can you add this to the prop itself?

Just updated.

…hore/64602

trjExpensify · 2025-09-22T17:39:28Z

This PR is dwindling. What's the blocker?

…hore/64602

dominictb · 2025-09-22T18:06:58Z

No blocker. Just pending @allroundexperts review.

allroundexperts · 2025-10-01T20:57:21Z

Sorry, I was not able to prioritise this PR. @dominictb Can you please merge main, and I will retest?

…hore/64602

codecov · 2025-10-02T13:59:17Z

Codecov Report

❌ Patch coverage is 17.64706% with 14 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/KYCWall/BaseKYCWall.tsx	0.00%	5 Missing ⚠️
src/pages/EnablePayments/ActivateStep.tsx	0.00%	2 Missing ⚠️
src/pages/settings/Wallet/AddDebitCardPage.tsx	0.00%	2 Missing ⚠️
src/components/KYCWall/index.tsx	0.00%	1 Missing ⚠️
src/components/MoneyReportHeader.tsx	0.00%	1 Missing ⚠️
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	0.00%	1 Missing ⚠️
src/components/SettlementButton/index.tsx	0.00%	1 Missing ⚠️
src/libs/actions/PaymentMethods.ts	0.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/App.tsx	`100.00% <ø> (ø)`
src/components/KYCWall/KYCWallContext.tsx	`100.00% <100.00%> (ø)`
src/pages/AddPersonalBankAccountPage.tsx	`0.00% <ø> (ø)`
...s/EnablePayments/AddBankAccount/AddBankAccount.tsx	`0.00% <ø> (ø)`
src/pages/Search/SearchSelectedNarrow.tsx	`0.00% <ø> (ø)`
src/pages/home/report/PureReportActionItem.tsx	`51.49% <100.00%> (+0.08%)`	⬆️
...rc/pages/settings/Wallet/WalletPage/WalletPage.tsx	`0.00% <ø> (ø)`
src/components/KYCWall/index.tsx	`0.00% <0.00%> (ø)`
src/components/MoneyReportHeader.tsx	`0.18% <0.00%> (-0.01%)`	⬇️
...nents/Search/SearchPageHeader/SearchFiltersBar.tsx	`0.00% <0.00%> (ø)`
... and 5 more

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

dominictb · 2025-10-02T14:06:48Z

Just updated

…hore/64602

allroundexperts · 2025-10-06T08:12:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

Screen.Recording.2025-10-07.at.11.39.25.PM.mov

iOS: HybridApp

iOS: mWeb Safari

Screen.Recording.2025-10-07.at.11.32.57.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-07.at.11.12.05.PM.mov

MacOS: Desktop

Screen.Recording.2025-10-07.at.11.27.41.PM.mov

allroundexperts · 2025-10-07T19:18:46Z

BUG

Repeat all the steps in OP.
Go to profile -> wallets.
Remove the attached bank account.
Create a new expense in the same workspace.
Try to pay it.
While connecting bank, select Connect bank account automatically.
Notice that instead of going to Plaid, it goes to the manual bank account flow.

Screen.Recording.2025-10-08.at.12.14.30.AM.mov

…hore/64602

dominictb · 2025-10-13T16:53:15Z

It's already on staging and not related to this PR.

Screen.Recording.2025-10-13.at.23.49.34-compressed.mov

In the above video, since I already had a business bank account, when I pressed Pay with business bank account, it should have opened the connect existing bank account modal instead. But anyway it's not related to this PR.

OSBotify · 2025-10-16T20:57:52Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-16T23:41:09Z

🚀 Deployed to staging by https://github.com/AndrewGable in version: 9.2.33-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-20T09:24:57Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.33-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

dominictb added 3 commits July 24, 2025 15:54

implement kyc wall context

a3b5ebf

assign kyc wall ref value

f351e73

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

bb1b04a

…hore/64602

dominictb changed the title ~~chore: Clean up file-level kycWallRef~~ [WIP] chore: Clean up file-level kycWallRef Jul 24, 2025

use kycWallRef from context API

483674c

dominictb mentioned this pull request Jul 24, 2025

[Due for payment 2025-10-27] [$500] [EUR Billing] Adding a debit card to pay for your subscription leads to a flow to Add a Bank Account after. #64602

Closed

16 tasks

dominictb added 2 commits July 31, 2025 00:17

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

5e7980a

…hore/64602

fix lint

0124baa

dominictb changed the title ~~[WIP] chore: Clean up file-level kycWallRef~~ chore: Clean up file-level kycWallRef Jul 30, 2025

dominictb marked this pull request as ready for review July 30, 2025 17:33

dominictb requested a review from a team as a code owner July 30, 2025 17:33

melvin-bot Bot requested review from allroundexperts and removed request for a team July 30, 2025 17:33

dominictb added 2 commits August 6, 2025 13:24

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

1182a70

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

a371b55

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

3cccb90

…hore/64602

allroundexperts reviewed Aug 26, 2025

View reviewed changes

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

82e902e

…hore/64602

dominictb requested a review from a team as a code owner September 3, 2025 10:27

dominictb added 3 commits September 3, 2025 21:27

remove forwarded ref

c501f56

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

3f6661b

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

4de72bb

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

7a5268c

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

27824aa

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

8e1f394

…hore/64602

Merge branch 'main' of github.com-dominictb:dominictb/epsf-app into c…

79a00ee

…hore/64602

fix typecheck

ee2dfe9

allroundexperts approved these changes Oct 14, 2025

View reviewed changes

melvin-bot Bot requested a review from AndrewGable October 14, 2025 19:38

AndrewGable approved these changes Oct 16, 2025

View reviewed changes

AndrewGable merged commit 06f6ab9 into Expensify:main Oct 16, 2025
21 checks passed

OSBotify mentioned this pull request Oct 16, 2025

Deploy Checklist: New Expensify 2025-10-16 #72816

Closed

67 tasks

Conversation

dominictb commented Jul 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jul 30, 2025

Uh oh!

dominictb commented Jul 30, 2025

Uh oh!

dominictb commented Aug 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

allroundexperts commented Aug 11, 2025

Uh oh!

allroundexperts commented Aug 14, 2025

Uh oh!

dominictb commented Aug 18, 2025

Uh oh!

allroundexperts Aug 26, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

trjExpensify commented Sep 22, 2025

Uh oh!

dominictb commented Sep 22, 2025

Uh oh!

allroundexperts commented Oct 1, 2025

Uh oh!

codecov Bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dominictb commented Oct 2, 2025

Uh oh!

allroundexperts commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allroundexperts commented Oct 7, 2025

Uh oh!

dominictb commented Oct 13, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

OSBotify commented Oct 16, 2025

Uh oh!

OSBotify commented Oct 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

dominictb commented Jul 24, 2025 •

edited

Loading

dominictb commented Aug 7, 2025 •

edited

Loading

codecov Bot commented Oct 2, 2025 •

edited

Loading

allroundexperts commented Oct 6, 2025 •

edited

Loading