Show Empty Chat with draft messages in LHN

[parasharrajat]

Details

Fixed Issues

$ #6619

Tests | QA Steps

1. Make sure the focus Mode is not on from the Preference Page.
2. Open any new chat that does not have any messages yet.
3. Check that it is listed in LHN when active.
4. Create a draft message on the same chat.
5. Switch to another chat.
6. Confirm that the old chat is still visible in LHN with the pencil icon.
7. Open the old chat.
8. Clear the draft.
9. Switch to another chat.
10. Confirm that chat is not more visible in LHN.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

output_file.mp4

I think other videos are not needed I just moved one flag from Focus mode to both modes and thus it should work if it works on one platform.

Mobile Web

Desktop

iOS

Android

[roryabraham]

Sorry for not noticing during your proposal @parasharrajat, but the goal of this PR is to show reports with drafts for both the focus and standard modes. Given that, I think there will no longer be a use-case where we want to exclude a report from a getOptions result just because it contains a draft comment.

So instead of the implementation you have in this PR, we should just get rid of the showReportsWithDrafts parameter of getOptions entirely, since it will no longer be used and we don't need it to default to false. We should also get rid of the logic here that filters out reports with a draft comment.

[parasharrajat]

Oh yeah, overlooked that. Thanks for noticing

But we will still need the filter for hasDraftComment otherwise shouldFilterReportIfEmpty will block the report to be shown in LHN. We can definitely remove the flag.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.1.20-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by @Julesssss in version: 1.1.21-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅