Skip to content

[NO QA] fix: types related to #65329 #65438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JS00001 merged 2 commits into from
Jul 3, 2025
Merged

[NO QA] fix: types related to #65329 #65438

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f6681b
fix: types
daledah Jul 3, 2025
5c0c31c
fix: test
daledah Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 24 additions & 30 deletions tests/unit/ReportSecondaryActionUtilsTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,36 +885,6 @@ describe('getSecondaryAction', () => {
const result = getSecondaryReportActions({report, chatReport, reportTransactions: [transaction], violations: {}, policy});
expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.DELETE)).toBe(false);
});

it('include EXPORT_TO_ACCOUNTING option for settled expense report', async () => {
const report = {
reportID: REPORT_ID,
type: CONST.REPORT.TYPE.EXPENSE,
ownerAccountID: EMPLOYEE_ACCOUNT_ID,
statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,
stateNum: CONST.REPORT.STATE_NUM.APPROVED,
policyID: POLICY_ID,
} as unknown as Report;

const TRANSACTION_ID = 'TRANSACTION_ID';
const transaction = {
transactionID: TRANSACTION_ID,
reportID: REPORT_ID,
} as unknown as Transaction;

const policy = {
connections: {
[CONST.POLICY.CONNECTIONS.NAME.XERO]: {},
},
id: POLICY_ID,
role: CONST.POLICY.ROLE.ADMIN,
} as Policy;

await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report);

const result = getSecondaryReportActions({report, chatReport, reportTransactions: [transaction], violations: {}, policy});
expect(result.includes(CONST.REPORT.SECONDARY_ACTIONS.EXPORT_TO_ACCOUNTING)).toBe(true);
});
});

describe('getSecondaryExportReportActions', () => {
Expand Down Expand Up @@ -991,6 +961,30 @@ describe('getSecondaryExportReportActions', () => {
expect(result.includes(CONST.REPORT.EXPORT_OPTIONS.EXPORT_TO_INTEGRATION)).toBe(true);
});

it('include EXPORT option for settled expense report with integrated policy', async () => {
const report = {
reportID: REPORT_ID,
type: CONST.REPORT.TYPE.EXPENSE,
ownerAccountID: EMPLOYEE_ACCOUNT_ID,
statusNum: CONST.REPORT.STATUS_NUM.REIMBURSED,
stateNum: CONST.REPORT.STATE_NUM.APPROVED,
policyID: POLICY_ID,
} as unknown as Report;

const policy = {
connections: {
[CONST.POLICY.CONNECTIONS.NAME.XERO]: {},
},
id: POLICY_ID,
role: CONST.POLICY.ROLE.ADMIN,
} as Policy;

await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report);

const result = getSecondaryExportReportActions(report, policy);
expect(result.includes(CONST.REPORT.EXPORT_OPTIONS.EXPORT_TO_INTEGRATION)).toBe(true);
});

it('includes MARK_AS_EXPORTED option for invoice report sender', async () => {
const report = {
reportID: REPORT_ID,
Expand Down
Loading