Skip to content

fix: system message not threaded after setting new tax value #65320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 6 commits into from
Nov 14, 2025
Merged

fix: system message not threaded after setting new tax value #65320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a331d36
fix: system message not threaded after setting new tax value
nkdengineer Jul 2, 2025
1282d9f
merge main
nkdengineer Oct 8, 2025
189b19a
Merge branch 'main' into fix/63515
nkdengineer Oct 23, 2025
1589ed0
resolve conflict
nkdengineer Nov 12, 2025
d8c177a
update translation
nkdengineer Nov 12, 2025
20f4601
update translation for update tax action
nkdengineer Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/CONST/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1267,6 +1267,9 @@ const CONST = {
ADD_INTEGRATION: 'POLICYCHANGELOG_ADD_INTEGRATION',
ADD_REPORT_FIELD: 'POLICYCHANGELOG_ADD_REPORT_FIELD',
ADD_TAG: 'POLICYCHANGELOG_ADD_TAG',
ADD_TAX: 'POLICYCHANGELOG_ADD_TAX',
DELETE_TAX: 'POLICYCHANGELOG_DELETE_TAX',
UPDATE_TAX: 'POLICYCHANGELOG_UPDATE_TAX',
DELETE_ALL_TAGS: 'POLICYCHANGELOG_DELETE_ALL_TAGS',
DELETE_APPROVER_RULE: 'POLICYCHANGELOG_DELETE_APPROVER_RULE',
DELETE_BUDGET: 'POLICYCHANGELOG_DELETE_BUDGET',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/de.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6147,6 +6148,30 @@ ${amount} für ${merchant} - ${date}`,
`änderte die Rate der Berichte, die zufällig zur manuellen Genehmigung weitergeleitet werden, auf ${Math.round(newAuditRate * 100)}% (zuvor ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`hat das manuelle Genehmigungslimit für alle Ausgaben auf ${newLimit} geändert (vorher ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `hat die Steuer "${taxName}" hinzugefügt`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `hat die Steuer "${taxName}" entfernt`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `hat die Steuer "${oldValue}" in "${newValue}" umbenannt`;
}
case 'code': {
return `hat den Steuercode für "${taxName}" von "${oldValue}" auf "${newValue}" geändert`;
}
case 'rate': {
return `hat den Steuersatz für "${taxName}" von "${oldValue}" auf "${newValue}" geändert`;
}
case 'enabled': {
return `${oldValue ? `hat die Steuer "${taxName}" deaktiviert` : `hat die Steuer "${taxName}" aktiviert`}`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Mitglied nicht gefunden.',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6117,6 +6118,30 @@ const translations = {
`changed the rate of reports randomly routed for manual approval to ${Math.round(newAuditRate * 100)}% (previously ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`changed the manual approval limit for all expenses to ${newLimit} (previously ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `added the tax "${taxName}"`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `removed the tax "${taxName}"`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `renamed the tax "${oldValue}" to "${newValue}"`;
}
case 'code': {
return `changed the tax code for "${taxName}" from "${oldValue}" to "${newValue}"`;
}
case 'rate': {
return `changed the tax rate for "${taxName}" from "${oldValue}" to "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? 'disabled' : 'enabled'} the tax "${taxName}"`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Member not found.',
Expand Down
24 changes: 24 additions & 0 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5784,6 +5784,30 @@ ${amount} para ${merchant} - ${date}`,
updatedAuditRate: ({oldAuditRate, newAuditRate}) =>
`cambió la tasa de informes enviados aleatoriamente para aprobación manual a ${Math.round(newAuditRate * 100)}% (previamente ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}) => `cambió el límite de aprobación manual para todos los gastos a ${newLimit} (previamente ${oldLimit})`,
addTax: ({taxName}) => `añadió el impuesto "${taxName}"`,
deleteTax: ({taxName}) => `eliminó el impuesto "${taxName}"`,
updateTax: ({oldValue, taxName, updatedField, newValue}) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `cambió el nombre del impuesto de "${oldValue}" a "${newValue}"`;
}
case 'code': {
return `cambió el código del impuesto "${taxName}" de "${oldValue}" a "${newValue}"`;
}
case 'rate': {
return `cambió la tasa del impuesto "${taxName}" de "${oldValue}" a "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? 'deshabilitó' : 'habilitó'} el impuesto "${taxName}"`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Miembro no encontrado.',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/fr.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6154,6 +6155,30 @@ ${amount} pour ${merchant} - ${date}`,
`a changé le taux de rapports acheminés aléatoirement pour approbation manuelle à ${Math.round(newAuditRate * 100)}% (précédemment ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`a modifié la limite d'approbation manuelle pour toutes les dépenses à ${newLimit} (précédemment ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `a ajouté la taxe "${taxName}"`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `a supprimé la taxe "${taxName}"`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `a renommé la taxe "${oldValue}" en "${newValue}"`;
}
case 'code': {
return `a modifié le code de la taxe "${taxName}" de "${oldValue}" à "${newValue}"`;
}
case 'rate': {
return `a modifié le taux de la taxe "${taxName}" de "${oldValue}" à "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? 'a désactivé' : 'a activé'} la taxe "${taxName}"`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Membre non trouvé.',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/it.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6162,6 +6163,30 @@ ${amount} per ${merchant} - ${date}`,
`ha cambiato la percentuale di rapporti instradati casualmente per l'approvazione manuale a ${Math.round(newAuditRate * 100)}% (precedentemente ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`ha cambiato il limite di approvazione manuale per tutte le spese a ${newLimit} (precedentemente ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `ha aggiunto l'imposta "${taxName}"`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `ha rimosso l'imposta "${taxName}"`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `ha rinominato l'imposta da "${oldValue}" a "${newValue}"`;
}
case 'code': {
return `ha modificato il codice dell'imposta "${taxName}" da "${oldValue}" a "${newValue}"`;
}
case 'rate': {
return `ha modificato l'aliquota dell'imposta "${taxName}" da "${oldValue}" a "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? 'ha disattivato' : 'ha attivato'} l'imposta "${taxName}"`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Membro non trovato.',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/ja.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6097,6 +6098,30 @@ ${date} - ${merchant}に${amount}`,
updatedAuditRate: ({oldAuditRate, newAuditRate}: UpdatedPolicyAuditRateParams) =>
`レポートが手動承認のためにランダムにルーティングされる割合を${Math.round(newAuditRate * 100)}%（以前は${Math.round(oldAuditRate * 100)}%）に変更しました。`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) => `すべての経費の手動承認限度額を${newLimit}に変更しました（以前は${oldLimit}）`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `税 "${taxName}" を追加しました`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `税 "${taxName}" を削除しました`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `税 "${oldValue}" の名前を "${newValue}" に変更しました`;
}
case 'code': {
return `税 "${taxName}" のコードを "${oldValue}" から "${newValue}" に変更しました`;
}
case 'rate': {
return `税 "${taxName}" の税率を "${oldValue}" から "${newValue}" に変更しました`;
}
case 'enabled': {
return `${oldValue ? `税 "${taxName}" を無効にしました` : `税 "${taxName}" を有効にしました`}`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'メンバーが見つかりません。',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/nl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6144,6 +6145,30 @@ ${amount} voor ${merchant} - ${date}`,
`heeft het percentage van rapporten dat willekeurig wordt doorgestuurd voor handmatige goedkeuring gewijzigd naar ${Math.round(newAuditRate * 100)}% (voorheen ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`heeft de handmatige goedkeuringslimiet voor alle uitgaven gewijzigd naar ${newLimit} (voorheen ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `heeft de belasting "${taxName}" toegevoegd`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `heeft de belasting "${taxName}" verwijderd`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `heeft de belasting "${oldValue}" hernoemd naar "${newValue}"`;
}
case 'code': {
return `heeft de belastingcode voor "${taxName}" gewijzigd van "${oldValue}" naar "${newValue}"`;
}
case 'rate': {
return `heeft het belastingtarief voor "${taxName}" gewijzigd van "${oldValue}" naar "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? `heeft de belasting "${taxName}" uitgeschakeld` : `heeft de belasting "${taxName}" ingeschakeld`}`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Lid niet gevonden.',
Expand Down
3 changes: 3 additions & 0 deletions src/languages/params.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ type UpdatedPolicyCategoryExpenseLimitTypeParams = {categoryName: string; oldVal

type UpdatedPolicyCategoryMaxAmountNoReceiptParams = {categoryName: string; oldValue?: string; newValue: string};

type UpdatedPolicyTaxParams = {taxName: string; oldValue?: string | boolean | number; newValue?: string | boolean | number; updatedField?: string};

type UpdatedPolicyTagParams = {tagListName: string; tagName?: string; enabled?: boolean; count?: string};

type UpdatedPolicyTagNameParams = {oldName: string; newName: string; tagListName: string};
Expand Down Expand Up @@ -1199,6 +1201,7 @@ export type {
UpdatedPolicyCustomUnitTaxRateExternalIDParams,
UpdatedPolicyCustomUnitTaxClaimablePercentageParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagFieldParams,
UpdatedPolicyReportFieldDefaultValueParams,
Expand Down
25 changes: 25 additions & 0 deletions src/languages/pl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6131,6 +6132,30 @@ ${amount} dla ${merchant} - ${date}`,
`zmieniono wskaźnik raportów losowo kierowanych do ręcznej akceptacji na ${Math.round(newAuditRate * 100)}% (wcześniej ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`zmieniono limit ręcznego zatwierdzania dla wszystkich wydatków na ${newLimit} (wcześniej ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `dodał podatek "${taxName}"`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `usunął podatek "${taxName}"`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `zmienił nazwę podatku z "${oldValue}" na "${newValue}"`;
}
case 'code': {
return `zmienił kod podatku "${taxName}" z "${oldValue}" na "${newValue}"`;
}
case 'rate': {
return `zmienił stawkę podatku "${taxName}" z "${oldValue}" na "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? `wyłączył podatek "${taxName}"` : `włączył podatek "${taxName}"`}`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Nie znaleziono członka.',
Expand Down
25 changes: 25 additions & 0 deletions src/languages/pt-BR.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,7 @@ import type {
UpdatedPolicyTagFieldParams,
UpdatedPolicyTagNameParams,
UpdatedPolicyTagParams,
UpdatedPolicyTaxParams,
UpdatedTheDistanceMerchantParams,
UpdatedTheRequestParams,
UpdatePolicyCustomUnitParams,
Expand Down Expand Up @@ -6144,6 +6145,30 @@ ${amount} para ${merchant} - ${date}`,
`alterou a taxa de relatórios encaminhados aleatoriamente para aprovação manual para ${Math.round(newAuditRate * 100)}% (anteriormente ${Math.round(oldAuditRate * 100)}%)`,
updatedManualApprovalThreshold: ({oldLimit, newLimit}: UpdatedPolicyManualApprovalThresholdParams) =>
`alterou o limite de aprovação manual para todas as despesas para ${newLimit} (anteriormente ${oldLimit})`,
addTax: ({taxName}: UpdatedPolicyTaxParams) => `adicionou o imposto "${taxName}"`,
deleteTax: ({taxName}: UpdatedPolicyTaxParams) => `removeu o imposto "${taxName}"`,
updateTax: ({oldValue, taxName, updatedField, newValue}: UpdatedPolicyTaxParams) => {
if (!updatedField) {
return '';
}
switch (updatedField) {
case 'name': {
return `renomeou o imposto de "${oldValue}" para "${newValue}"`;
}
case 'code': {
return `alterou o código do imposto "${taxName}" de "${oldValue}" para "${newValue}"`;
}
case 'rate': {
return `alterou a taxa do imposto "${taxName}" de "${oldValue}" para "${newValue}"`;
}
case 'enabled': {
return `${oldValue ? 'desativou' : 'ativou'} o imposto "${taxName}"`;
}
default: {
return '';
}
}
},
},
roomMembersPage: {
memberNotFound: 'Membro não encontrado.',
Expand Down
Loading
Loading