perf: bottom bar switching and search by martasudol · Pull Request #64995 · Expensify/App

martasudol · 2025-06-26T08:14:13Z

Explanation of Change

These changes optimize performance of switching between bottom tabs and search action in Reports tab.

Fixed Issues

$#60007

Tests

Switch between bottom tabs - from the functional point of view everything should work in the same way.
Navigate to Reports tab, click on search bar and type something. Also, everything should work the same way from the functional point of view.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Nagranie.z.ekranu.2025-06-26.o.10.39.52.mov

iOS: Native

Nagranie.z.ekranu.2025-06-26.o.10.23.47.mov

iOS: mWeb Safari

Nagranie.z.ekranu.2025-06-26.o.10.27.46.mov

MacOS: Chrome / Safari

Nagranie.z.ekranu.2025-06-26.o.10.36.07.mov

MacOS: Desktop

Nagranie.z.ekranu.2025-06-26.o.10.36.55.mov

=== 📁 Trace File Analysis ===

📄 File: main-search.json
  • Commit count: 55
  • Total render duration: 2753.986 ms
  • p50 / p95 / p99 (ms):
    • p50: 19.735 ms
    • p95: 170.482 ms
    • p99: 473.206 ms

📄 File: profiling-data.26.06.2025.10-03-40.json
  • Commit count: 29
  • Total render duration: 1752.655 ms
  • p50 / p95 / p99 (ms):
    • p50: 13.763 ms
    • p95: 213.854 ms
    • p99: 465.946 ms

=== 📊 Trace Comparison ===

🔁 Comparing Baseline ↔️ profiling-data.26.06.2025.10-03-40.json
  🟢 Duration Diff: -1001.331 ms
  🟢 Commit Count Diff: -26

melvin-bot · 2025-06-26T09:57:05Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

adhorodyski · 2025-06-27T11:06:46Z

cc @mountiny just a friendly ping if we could fast track this one 🙏🏻

rushatgabhane · 2025-06-27T11:27:36Z

yes, prioritizing this

rushatgabhane · 2025-06-27T13:20:01Z

    const {shouldUseNarrowLayout} = useResponsiveLayout();
    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
-    const [session] = useOnyx(ONYXKEYS.SESSION, {canBeMissing: false});
+    const [accountID] = useOnyx(ONYXKEYS.SESSION, {canBeMissing: false, selector: (onyxSession) => onyxSession?.accountID});


Did we get a 1s improvement in time to render?

The changes look good to me!

I'm wondering if we should make this as a recommendation to prefer selecting data if you need less than ~3 keys from an onyx object that changes a lot (eg: session, account)

+1, lets make sure we capture these ideas and make them into best practices, better yet, custom eslint rules @adhorodyski

rushatgabhane · 2025-06-27T14:22:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-06-27.at.18.56.24.mov

iOS: mWeb Safari

Screen.Recording.2025-06-27.at.18.39.40.mov

MacOS: Chrome / Safari

Screen.Recording.2025-06-27.at.18.29.52.mov

Screen.Recording.2025-06-27.at.18.34.06.mov

MacOS: Desktop

Screen.Recording.2025-06-27.at.18.51.48.mov

mountiny

Thank you @martasudol this is really cool to see such improvement is done from such an innocent change

mountiny · 2025-06-27T17:59:41Z

    const {shouldUseNarrowLayout} = useResponsiveLayout();
    const [account] = useOnyx(ONYXKEYS.ACCOUNT, {canBeMissing: true});
-    const [session] = useOnyx(ONYXKEYS.SESSION, {canBeMissing: false});
+    const [accountID] = useOnyx(ONYXKEYS.SESSION, {canBeMissing: false, selector: (onyxSession) => onyxSession?.accountID});


+1, lets make sure we capture these ideas and make them into best practices, better yet, custom eslint rules @adhorodyski

OSBotify · 2025-06-27T18:17:36Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-27T23:45:58Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-27T23:57:54Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.72-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…-bar-switching-and-search" This reverts commit 6b3047f, reversing changes made to 9092e8e.

[CP Staging] Revert #64995

[CP Staging] Revert #64995 (cherry picked from commit cfecca7) (cherry-picked to staging by puneetlath)

github-actions · 2025-06-30T22:21:41Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.72-10 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-30T22:51:16Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.73-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-07-01T22:06:55Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.1.73-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

martasudol added 2 commits June 26, 2025 08:47

perf: bottom tabs

8dc2476

perf: bottom tabs

f2984be

martasudol changed the title ~~Perf bottom bar switching and search~~ perf: bottom bar switching and search Jun 26, 2025

martasudol added 2 commits June 26, 2025 10:29

perf: bottom tabs

2d92dea

perf: bottom tabs

ff26b84

martasudol marked this pull request as ready for review June 26, 2025 09:57

martasudol requested a review from a team as a code owner June 26, 2025 09:57

melvin-bot Bot requested review from rushatgabhane and removed request for a team June 26, 2025 09:57

rushatgabhane reviewed Jun 27, 2025

View reviewed changes

fabioh8010 mentioned this pull request Jun 27, 2025

Investigate open report slowness in ios for Jasons account #64828

Closed

rushatgabhane approved these changes Jun 27, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny June 27, 2025 16:57

mountiny assigned martasudol Jun 27, 2025

mountiny approved these changes Jun 27, 2025

View reviewed changes

mountiny merged commit 6b3047f into Expensify:main Jun 27, 2025
21 of 22 checks passed

github-actions Bot mentioned this pull request Jun 27, 2025

Deploy Checklist: New Expensify 2025-06-27 #65114

Closed

JS00001 mentioned this pull request Jun 30, 2025

Results returned when searching for a user and default back to suggestions #65144

Closed

16 tasks

JS00001 added a commit that referenced this pull request Jun 30, 2025

Revert "Merge pull request #64995 from callstack-internal/perf-bottom…

d10f016

…-bar-switching-and-search" This reverts commit 6b3047f, reversing changes made to 9092e8e.

JS00001 mentioned this pull request Jun 30, 2025

[CP Staging] Revert #64995 #65182

Merged

50 tasks

puneetlath added a commit that referenced this pull request Jun 30, 2025

Merge pull request #65182 from Expensify/jsenyitko-revert-644995

cfecca7

[CP Staging] Revert #64995

OSBotify pushed a commit that referenced this pull request Jun 30, 2025

Merge pull request #65182 from Expensify/jsenyitko-revert-644995

8eb6fe0

[CP Staging] Revert #64995 (cherry picked from commit cfecca7) (cherry-picked to staging by puneetlath)

BlameGPT mentioned this pull request Jun 30, 2025

Reports - Export option does not bring up Basic Export menu in Reports #65117

Closed

8 tasks

github-actions Bot mentioned this pull request Jun 30, 2025

Deploy Checklist: New Expensify 2025-06-30 #65214

Closed

29 tasks

Uh oh!

Conversation

martasudol commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jun 26, 2025

Uh oh!

adhorodyski commented Jun 27, 2025

Uh oh!

rushatgabhane commented Jun 27, 2025

Uh oh!

rushatgabhane Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

rushatgabhane commented Jun 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny Jun 27, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 27, 2025

Uh oh!

github-actions Bot commented Jun 30, 2025

Uh oh!

github-actions Bot commented Jun 30, 2025

Uh oh!

github-actions Bot commented Jul 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

martasudol commented Jun 26, 2025 •

edited

Loading

rushatgabhane Jun 27, 2025 •

edited

Loading

rushatgabhane commented Jun 27, 2025 •

edited

Loading