Skip to content

fix: last actor display name not update on actionableMentionWhisper #64204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcochavezf merged 4 commits into from
Jul 2, 2025
Merged

fix: last actor display name not update on actionableMentionWhisper #64204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d43a0d7
get lastActorAccountID from lastAction instead of report
samranahm Jun 13, 2025
ceb65ec
Add ActionableMentionWhisper in visible as lastAction
samranahm Jun 13, 2025
9136b1e
fix: reportActionsForDisplay to include whisper and use lastAction fo…
samranahm Jun 13, 2025
de0bbdf
fix lint error
samranahm Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/libs/OptionsListUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ import {
isTaskAction,
isThreadParentMessage,
isUnapprovedAction,
isWhisperAction,
shouldReportActionBeVisible,
} from './ReportActionsUtils';
import {
Expand Down Expand Up @@ -419,7 +418,6 @@ Onyx.connect({
const reportActionsForDisplay = sortedReportActions.filter(
(reportAction, actionKey) =>
shouldReportActionBeVisible(reportAction, actionKey, isWriteActionAllowed) &&
!isWhisperAction(reportAction) &&
reportAction.actionName !== CONST.REPORT.ACTIONS.TYPE.CREATED &&
reportAction.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
);
Expand Down Expand Up @@ -956,7 +954,7 @@ function createOption(accountIDs: number[], personalDetails: OnyxInputOrEntry<Pe
const lastAction = lastVisibleReportActions[report.reportID];
// lastActorAccountID can be an empty string
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
const lastActorAccountID = report.lastActorAccountID || lastAction?.actorAccountID;
const lastActorAccountID = lastAction?.actorAccountID || report.lastActorAccountID;
const lastActorDetails = lastActorAccountID ? (personalDetails?.[lastActorAccountID] ?? null) : null;
const lastActorDisplayName = getLastActorDisplayName(lastActorDetails);
const lastMessageTextFromReport = getLastMessageTextForReport(report, lastActorDetails, undefined, reportNameValuePairs);
Expand Down
2 changes: 1 addition & 1 deletion src/libs/ReportActionsUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,7 @@ function shouldReportActionBeVisibleAsLastAction(reportAction: OnyxInputOrEntry<
// If the action's message text is empty and it is not a deleted parent with visible child actions, hide it. Else, consider the action to be displayable.
return (
shouldReportActionBeVisible(reportAction, reportAction.reportActionID, canUserPerformWriteAction) &&
!(isWhisperAction(reportAction) && !isReportPreviewAction(reportAction) && !isMoneyRequestAction(reportAction)) &&
(!(isWhisperAction(reportAction) && !isReportPreviewAction(reportAction) && !isMoneyRequestAction(reportAction)) || isActionableMentionWhisper(reportAction)) &&
!(isDeletedAction(reportAction) && !isDeletedParentAction(reportAction))
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/libs/SidebarUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ function getOptionData({
const lastAction = visibleReportActionItems[report.reportID];
// lastActorAccountID can be an empty string
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
const lastActorAccountID = report.lastActorAccountID || lastAction?.actorAccountID;
const lastActorAccountID = lastAction?.actorAccountID || report.lastActorAccountID;
// If the last actor's details are not currently saved in Onyx Collection,
// then try to get that from the last report action if that action is valid
// to get data from.
Expand Down