fix(perf): move useOnyx call up the tree on LHN by adhorodyski · Pull Request #64076 · Expensify/App

adhorodyski · 2025-06-12T14:26:06Z

Explanation of Change

This PR moves useOnyx connections from within render items of LHN up the tree to the list level. This lets the CPU breathe more while maintaining the very same behaviour and data.
A reattempt after #63362 got reverted.

Fixed Issues

$ #63439
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create fresh account
Start chat with a random user and send a message
Go back to LHN and verify the chat is on the top of the list
Long press/Right click on Concierge chat and select "Pin"
Verify the Concierge chat went to the top of the list
Start another chat
Create a task and assign it to yourself
Verify that chat went to the 1st or 2nd position in the LHN (it would be sorted alphabetically together with Concierge)
Go to Account -> Preferences
Change the Priority Mode to Focus
Go back to LHN
Verify the only visible chats are Pinned chat and the one where you assigned the task with GBR
Go to Account -> Preferences
Change the Priority Mode to Most Recent
Go back to LHN
Verify all three reports are visible

In addition, QA steps from this deploy blocker apply: #63811

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

adhorodyski · 2025-06-12T14:44:42Z

Looking for a solution to #63811 now.

adhorodyski · 2025-06-12T16:21:57Z

Opening for review, done with testing under #63811 (comment)

melvin-bot · 2025-06-12T16:22:04Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-06-12T17:02:49Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-06-12T17:34:47Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #64076.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/64076/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/64076/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/64076/NewExpensify.dmg	https://64076.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

mountiny · 2025-06-12T19:44:56Z

@adhorodyski asked for the restest but please add the test steps to the pr body

adhorodyski · 2025-06-13T09:31:08Z

Just updated, sorry! I figured we can use the same steps as one of @TMisiukiewicz's recent PR.

adhorodyski · 2025-06-13T09:36:07Z

Backlinking, it's no longer reproducible by the QA team: #63811 (comment)

mountiny · 2025-06-13T14:44:51Z

@brunovjk can you please complete the review and testing? thanks!

brunovjk · 2025-06-13T15:01:17Z

Sure :D

brunovjk · 2025-06-13T16:03:19Z

I can still reproduce this bug in our PR @adhorodyski:

Screen.Recording.2025-06-13.at.13.01.18.mov

adhorodyski · 2025-06-13T16:35:03Z

Huh that's tricky then, I'll rerun it way more times now and see what's the dependency there. It was just fine this morning for 3-4 tries.

adhorodyski · 2025-06-16T10:37:59Z

iOS: https://github.com/user-attachments/assets/4bffa0a4-5cea-4e0e-addb-f93aa7dbdbf2

Android: https://github.com/user-attachments/assets/72e3feb2-d459-4b24-9e77-2684ef1dbc28

Cannot reproduce now on iOS, doing Web next.

Update: Android is working fine.

adhorodyski · 2025-06-16T13:23:23Z

@brunovjk managed to fix this here, updated the PR. Can I ask you for a retest, also from the performance standpoint? Looks like I had to add one render back.

For some reason it was only a wide layout problem - worked fine even on the narrow web. isReportsSplitNavigatorLast needs to be also passed down the list's extraData, even though it's a dependency for renderItem. I already have this general issue on my radar with @TMisiukiewicz because it's the case for other props as well.

brunovjk · 2025-06-17T16:30:06Z

Very good @adhorodyski we fixed the bug. I compared our PR with the app in production and everything is consistent, but there are two details:

Step 3 does not happen, when creating a new chat, it appears below the Concierge:

MacOS: Chrome / Safari - This PR

Screen.Recording.2025-06-17.at.13.26.12.mov

I found another bug, where the chat containing the completed task does not appear after returning from "Mode to Focus" to "Most Recent":

MacOS: Chrome / Safari - This PR

our_PR.mov

MacOS: Chrome / Safari - Production

prod.mov

However, both are also reproducible in the app in production, so I believe we are good to go here. I will continue testing on the other platforms and complete the checklist. What do you think @adhorodyski? Thanks.

adhorodyski · 2025-06-18T08:21:06Z

This looks good! I'll also restest this myself today from React's performance perspective.

brunovjk · 2025-06-18T14:36:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

64076_android_web.mov

iOS: HybridApp

64076_ios_native.mov

iOS: mWeb Safari

64076_ios_web.mov

MacOS: Chrome / Safari

64076_web_chrome.mov

MacOS: Desktop

brunovjk

I tested this PR alongside new.expensify.com, and everything appears consistent to me. However, I noticed that the following bugs are reproducible in both versions:

The tooltip in the Concierge chat does not appear immediately when logging in with a new account:

MacOS: Chrome / Safari

Screen.Recording.2025-06-18.at.11.48.02.mov
A 1:1 chat with a completed task will disappear from the LHN when switching from "Focus Mode" back to "Most Recent" mode:

MacOS: Chrome / Safari

Screen.Recording.2025-06-18.at.11.51.35.mov

Correct me if I’m wrong, but this PR is intended to improve performance only, without changing any existing app functionality. Maybe we should update the “Test Steps” here accordingly, so that the QA team doesn't get confused with the existing bugs. What do you think @adhorodyski?

adhorodyski · 2025-06-18T15:36:15Z

Yup, I think I got them wrong in the first place. cc @TMisiukiewicz I'll remove these mentioned steps now.

mountiny · 2025-06-18T22:26:09Z

@brunovjk those bugs you found, if that is present on main, can you please raise them in bugs channel? Or where did the expected behaviour come from?

mountiny

Same as last time with one additional commit, looks good to me

OSBotify · 2025-06-18T22:36:06Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-06-18T23:45:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.69-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-19T09:39:37Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.69-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

github-actions · 2025-06-19T10:19:52Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.69-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

github-actions · 2025-06-20T12:47:16Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.1.69-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix(perf): move useOnyx call up the tree on LHN

6036922

adhorodyski mentioned this pull request Jun 12, 2025

[$1,000] Improve lists performance by not calling useOnyx in list items #63439

Closed

Merge branch 'main' into fix/lhn-props

165be10

mountiny assigned adhorodyski Jun 12, 2025

adhorodyski marked this pull request as ready for review June 12, 2025 16:21

adhorodyski requested a review from a team as a code owner June 12, 2025 16:21

melvin-bot Bot requested a review from brunovjk June 12, 2025 16:22

melvin-bot Bot removed the request for review from a team June 12, 2025 16:22

Expensify deleted a comment from github-actions Bot Jun 12, 2025

fix: add missing extraData to lhn

bfa7cf2

brunovjk approved these changes Jun 18, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny June 18, 2025 15:08

mountiny approved these changes Jun 18, 2025

View reviewed changes

mountiny merged commit 1b91363 into Expensify:main Jun 18, 2025
19 checks passed

github-actions Bot mentioned this pull request Jun 18, 2025

Deploy Checklist: New Expensify 2025-06-18 #64518

Closed

58 tasks

mitarachim mentioned this pull request Jun 19, 2025

Chat with task/GBR not visible after switching Priority Mode back to Most Recent #64540

Closed

8 tasks

mountiny mentioned this pull request Jun 19, 2025

Revert "fix(perf): move useOnyx call up the tree on LHN" #64599

Closed

brunovjk mentioned this pull request Jun 20, 2025

[$250] Sign Up - Tooltip in Concierge chat, is not shown until navigating to a different section. #63811

Closed

8 tasks

adhorodyski deleted the fix/lhn-props branch June 23, 2025 10:04

Uh oh!

Conversation

adhorodyski commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

adhorodyski commented Jun 12, 2025

Uh oh!

adhorodyski commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot Bot commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

github-actions Bot commented Jun 12, 2025

Uh oh!

mountiny commented Jun 12, 2025

Uh oh!

adhorodyski commented Jun 13, 2025

Uh oh!

adhorodyski commented Jun 13, 2025

Uh oh!

mountiny commented Jun 13, 2025

Uh oh!

brunovjk commented Jun 13, 2025

Uh oh!

brunovjk commented Jun 13, 2025

Uh oh!

adhorodyski commented Jun 13, 2025

Uh oh!

adhorodyski commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adhorodyski commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brunovjk commented Jun 17, 2025

Uh oh!

adhorodyski commented Jun 18, 2025

Uh oh!

brunovjk commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

brunovjk left a comment

Choose a reason for hiding this comment

Uh oh!

adhorodyski commented Jun 18, 2025

Uh oh!

mountiny commented Jun 18, 2025

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jun 18, 2025

Uh oh!

github-actions Bot commented Jun 18, 2025

Uh oh!

github-actions Bot commented Jun 19, 2025

Uh oh!

github-actions Bot commented Jun 19, 2025

Uh oh!

github-actions Bot commented Jun 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

adhorodyski commented Jun 12, 2025 •

edited

Loading

adhorodyski commented Jun 12, 2025 •

edited

Loading

adhorodyski commented Jun 16, 2025 •

edited

Loading

adhorodyski commented Jun 16, 2025 •

edited

Loading

brunovjk commented Jun 18, 2025 •

edited

Loading