Skip to content

[CP staging]Revert "fix(perf): directly pass props to lhn items"#63864

Merged
mountiny merged 1 commit into
mainfrom
revert-63362-fix/lhn-props
Jun 10, 2025
Merged

[CP staging]Revert "fix(perf): directly pass props to lhn items"#63864
mountiny merged 1 commit into
mainfrom
revert-63362-fix/lhn-props

Conversation

@techievivek

@techievivek techievivek commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Reverts #63362

@techievivek techievivek self-assigned this Jun 10, 2025
@techievivek techievivek requested a review from a team as a code owner June 10, 2025 15:31
@techievivek techievivek added the CP Staging marks PRs that have been CP'd to staging label Jun 10, 2025
@techievivek techievivek requested a review from mountiny June 10, 2025 15:31
@melvin-bot melvin-bot Bot requested review from carlosmiceli and removed request for a team June 10, 2025 15:32
@melvin-bot

melvin-bot Bot commented Jun 10, 2025

Copy link
Copy Markdown

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny merged commit 29b5829 into main Jun 10, 2025
18 of 21 checks passed
@mountiny mountiny deleted the revert-63362-fix/lhn-props branch June 10, 2025 15:33
@melvin-bot melvin-bot Bot added the Emergency label Jun 10, 2025
@melvin-bot

melvin-bot Bot commented Jun 10, 2025

Copy link
Copy Markdown

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

mountiny commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Jun 10, 2025
@mountiny @OSBotify
Merge pull request #63864 from Expensify/revert-63362-fix/lhn-props
8380f00 
[CP staging]Revert "fix(perf): directly pass props to lhn items"

(cherry picked from commit 29b5829)

(cherry-picked to staging by mountiny)
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
Closed
77 tasks
@OSBotify

OSBotify commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

github-actions Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.63-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@Julesssss

Julesssss commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Requested a retest here

@github-actions

github-actions Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.1.63-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@brunovjk brunovjk mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlosmiceli carlosmiceli carlosmiceli approved these changes
@mountiny mountiny Awaiting requested review from mountiny

Assignees

@techievivek techievivek

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@techievivek @mountiny @OSBotify @Julesssss @carlosmiceli