[CP Staging] use legacy modal for FeatureTrainingModal by s77rt · Pull Request #62701 · Expensify/App

s77rt · 2025-05-23T23:05:52Z

Explanation of Change

The new modal does not seem to work with keyboard avoiding view. This caused problem on the onboarding modal (FeatureTrainingModal). This PR excludes that modal from using the new modal and instead uses the previous one. This is a temporarily solution to unblock deploy flow. We should still fix the new modal keyboard avoiding behaviour.

Fixed Issues

$ #62682
$ #62692

PROPOSAL:

Tests

Log in with a new Gmail account.
Tap Skip on work email page.
Select Track and budget expenses.
Enter name > Continue.
On "Take us for a test drive" modal, tap on the email field.
Verify the email field is visible after the keyboard is opened

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2025-05-23.at.11.59.18.PM.mov

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-05-23T23:05:58Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-05-23T23:12:27Z

🚧 @francoisl has triggered a test app build. You can view the workflow run here.

marcaaron · 2025-05-23T23:52:56Z

Does this also solve #62692?

s77rt · 2025-05-24T00:23:49Z

I'm not sure but I think it's related to keyboardShouldPersistTaps prop. I'm not able to test as now I'm getting some weird issues in node versions (two dependencies conflicting on the node version).

I have pushed a commit that shall fix that too, can you please confirm?

github-actions · 2025-05-24T00:53:53Z

🚧 @marcaaron has triggered a test app build. You can view the workflow run here.

github-actions · 2025-05-24T01:25:39Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
Android 🤖🔄	iOS 🍎🔄
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/62701-hybrid/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/62701-hybrid/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/62701/NewExpensify.dmg	https://62701.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

marcaaron · 2025-05-24T01:36:34Z

Testing now!

marcaaron · 2025-05-24T01:55:40Z

Working good. I'm also not able to repro #62692 on this branch... but lemme see if I can repro on staging.

marcaaron · 2025-05-24T02:01:11Z

Yep this change fixes it.

marcaaron · 2025-05-24T02:03:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

2025-05-23_15-54-31.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-05-24T02:16:23Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

use legacy modal for FeatureTrainingModal (cherry picked from commit 31b4b03) (cherry-picked to staging by Beamanator)

github-actions · 2025-05-26T17:19:43Z

🚀 Cherry-picked to staging by https://github.com/Beamanator in version: 9.1.51-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

github-actions · 2025-05-26T19:18:20Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.1.51-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

use legacy modal for FeatureTrainingModal

fab20ff

s77rt requested a review from a team as a code owner May 23, 2025 23:05

melvin-bot Bot requested review from alitoshmatov and removed request for a team May 23, 2025 23:05

s77rt mentioned this pull request May 23, 2025

[Due for payment 2025-06-17] [Due for payment 2025-06-05] [Due for payment 2025-06-02] mweb - Onboarding - "Take us for a test drive" modal does not move up when keyboard is opened #62682

Closed

8 tasks

francoisl added the Ready To Build label May 23, 2025

This comment has been minimized.

Sign in to view

keyboardShouldPersistTaps handled

cb569fc

marcaaron approved these changes May 24, 2025

View reviewed changes

marcaaron assigned s77rt May 24, 2025

marcaaron removed the request for review from alitoshmatov May 24, 2025 02:03

marcaaron merged commit 31b4b03 into Expensify:main May 24, 2025
17 checks passed

marcaaron changed the title ~~use legacy modal for FeatureTrainingModal~~ [CP Staging] use legacy modal for FeatureTrainingModal May 24, 2025

marcaaron mentioned this pull request May 24, 2025

[Due for payment 2025-06-05] [Due for payment 2025-06-02] iOS-Onboarding-"Start test drive" and "Skip"buttons don't trigger action when keyboard is open #62692

Closed

8 tasks

OSBotify pushed a commit that referenced this pull request May 26, 2025

Merge pull request #62701 from s77rt/legacy-modal-FeatureTrainingModal

b51a846

use legacy modal for FeatureTrainingModal (cherry picked from commit 31b4b03) (cherry-picked to staging by Beamanator)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label May 26, 2025

github-actions Bot mentioned this pull request May 26, 2025

Deploy Checklist: New Expensify 2025-05-23 #62662

Closed

jmusial mentioned this pull request May 27, 2025

Fix test drive modal not moving when keyboard openes #62799

Merged

49 tasks

Uh oh!

Conversation

s77rt commented May 23, 2025 • edited by marcaaron Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented May 23, 2025

Uh oh!

github-actions Bot commented May 23, 2025

Uh oh!

This comment has been minimized.

marcaaron commented May 23, 2025

Uh oh!

s77rt commented May 24, 2025

Uh oh!

github-actions Bot commented May 24, 2025

Uh oh!

github-actions Bot commented May 24, 2025

Uh oh!

marcaaron commented May 24, 2025

Uh oh!

marcaaron commented May 24, 2025

Uh oh!

marcaaron commented May 24, 2025

Uh oh!

marcaaron commented May 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented May 24, 2025

Uh oh!

github-actions Bot commented May 26, 2025

Uh oh!

github-actions Bot commented May 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

s77rt commented May 23, 2025 •

edited by marcaaron

Loading

marcaaron commented May 24, 2025 •

edited

Loading