Skip to content

Fix position of total in narrow header of transaction component #62103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srikarparsi merged 2 commits into from
May 16, 2025
Merged

Fix position of total in narrow header of transaction component #62103

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
410e385
fix spacing
sumo-slonik May 15, 2025
3f75f74
add new narrow condition to header
sumo-slonik May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/SelectionList/Search/ReportListItemHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ function FirstHeaderRow<TItem extends ListItem>({
/>
</View>
</View>
<View style={[styles.flexShrink0, styles.mr3]}>
<View style={[styles.flexShrink0, shouldShowAction && styles.mr3]}>
<TotalCell
showTooltip
isLargeScreenWidth={false}
Expand Down Expand Up @@ -161,14 +161,14 @@ function ReportListItemHeader<TItem extends ListItem>({
const reportItem = item as unknown as ReportListItemType;
const {currentSearchHash} = useSearchContext();
const {translate} = useLocalize();
const {shouldUseNarrowLayout} = useResponsiveLayout();
const {isLargeScreenWidth} = useResponsiveLayout();
const thereIsFromAndTo = !!reportItem?.from && !!reportItem?.to;
const showArrowComponent = reportItem.type === CONST.REPORT.TYPE.IOU && thereIsFromAndTo;

const handleOnButtonPress = () => {
handleActionButtonPress(currentSearchHash, reportItem, () => onSelectRow(item));
};
return shouldUseNarrowLayout ? (
return !isLargeScreenWidth ? (
<View>
<FirstHeaderRow
item={item}
Expand Down