Skip to content

Wrap PDF in TouchableWithoutFeedback #6169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luke9389 merged 3 commits into from
Nov 19, 2021
Merged

Wrap PDF in TouchableWithoutFeedback #6169

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7adfff
Wrap PDF in TouchableWithoutFeedback
CamilaRivera Nov 2, 2021
c6896ae
Remove unnecessary wrapping View
CamilaRivera Nov 2, 2021
3081be8
Remove unnecessary import
CamilaRivera Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/PDFView/index.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React from 'react';
import PropTypes from 'prop-types';
import {View} from 'react-native';
import {TouchableWithoutFeedback} from 'react-native';
import PDF from 'react-native-pdf';
import styles, {getWidthAndHeightStyle} from '../../styles/styles';
import withWindowDimensions, {windowDimensionsPropTypes} from '../withWindowDimensions';
Expand Down Expand Up @@ -30,7 +30,7 @@ const defaultProps = {
*/

const PDFView = props => (
<View style={[styles.flex1, props.style]}>
<TouchableWithoutFeedback style={[styles.flex1, props.style]}>
<PDF
activityIndicator={<FullScreenLoadingIndicator />}
source={{uri: props.sourceURL}}
Expand All @@ -39,7 +39,7 @@ const PDFView = props => (
getWidthAndHeightStyle(props.windowWidth, props.windowHeight),
]}
/>
</View>
</TouchableWithoutFeedback>
);

PDFView.propTypes = propTypes;
Expand Down