[Internal QA]: Update domainAccountID #61343
Conversation
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@puneetlath, could you please help test this PR or create an ad-hoc build and require an internal QA? Many thanks |
|
@DylanDylann Does this needs C+ testing? |
|
@parasharrajat Hmmm, I think not....... Becasue this PR requires an internal QA to test this flow |
|
🚧 @puneetlath has triggered a test app build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
Actually @DylanDylann I don't think this is working properly. It is passing the workspace accountID even if the feed is a domain feed. |
|
🚀 Deployed to staging by https://github.com/puneetlath in version: 9.1.40-0 🚀
|
|
I checked this off the QA checklist as the QA has been done here. There is some follow-up we need to do, but nothing that needs to block the deploy. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/13)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/13)Meaningless Changes To Duration (9/12)Show entries
Show details
|
Performance Comparison Report 📊 (11/13)Meaningless Changes To Duration (10/12)Show entries
Show details
|
Performance Comparison Report 📊 (12/13)Meaningless Changes To Duration (11/12)Show entries
Show details
|
Performance Comparison Report 📊 (13/13)Meaningless Changes To Duration (12/12)Show entries
Show details
|
Performance Comparison Report 📊 (2/13)Meaningless Changes To Duration (1/12)Show entries
Show details
|
Performance Comparison Report 📊 (3/13)Meaningless Changes To Duration (2/12)Show entries
Show details
|
Performance Comparison Report 📊 (4/13)Meaningless Changes To Duration (3/12)Show entries
Show details
|
Performance Comparison Report 📊 (5/13)Meaningless Changes To Duration (4/12)Show entries
Show details
|
Performance Comparison Report 📊 (6/13)Meaningless Changes To Duration (5/12)Show entries
Show details
|
Performance Comparison Report 📊 (7/13)Meaningless Changes To Duration (6/12)Show entries
Show details
|
Performance Comparison Report 📊 (8/13)Meaningless Changes To Duration (7/12)Show entries
Show details
|
Performance Comparison Report 📊 (9/13)Meaningless Changes To Duration (8/12)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀
|
Explanation of Change
Update domainAccountID and add UTs for sortCardsByCardholderName function
Fixed Issues
$ #60978
PROPOSAL:
Tests
Offline tests
QA Steps
PREREQUISITES: domain cards enabled on a policy
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop