Skip to content

Do not show hold option for invoice #60894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 3 commits into from
Apr 28, 2025
Merged

Do not show hold option for invoice #60894

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9bfa457
Do not show hold option for invoice
jnowakow Apr 25, 2025
86b4f49
Follow naming guidelines
jnowakow Apr 25, 2025
2956cff
apply suggestion
jnowakow Apr 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/hooks/useSelectedTransactionsActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {deleteMoneyRequest, unholdRequest} from '@libs/actions/IOU';
import {exportReportToCSV} from '@libs/actions/Report';
import Navigation from '@libs/Navigation/Navigation';
import {getIOUActionForTransactionID, getOriginalMessage, isDeletedAction, isMoneyRequestAction} from '@libs/ReportActionsUtils';
import {canDeleteCardTransactionByLiabilityType, canDeleteTransaction} from '@libs/ReportUtils';
import {canDeleteCardTransactionByLiabilityType, canDeleteTransaction, isMoneyRequestReport as isMoneyRequestReportUtils} from '@libs/ReportUtils';
import {getTransaction, isOnHold} from '@libs/TransactionUtils';
import CONST from '@src/CONST';
import ROUTES from '@src/ROUTES';
Expand All @@ -30,8 +30,9 @@ function useSelectedTransactionsActions({report, reportActions, session, onExpor
const anyTransactionOnHold = selectedTransactions.some(isOnHold);
const allTransactionOnHold = selectedTransactions.every(isOnHold);
const isReportReimbursed = report?.stateNum === CONST.REPORT.STATE_NUM.APPROVED && report?.statusNum === CONST.REPORT.STATUS_NUM.REIMBURSED;
const isMoneyRequestReport = isMoneyRequestReportUtils(report);

if (!anyTransactionOnHold && selectedTransactions.length === 1 && !isReportReimbursed) {
if (isMoneyRequestReport && !anyTransactionOnHold && selectedTransactions.length === 1 && !isReportReimbursed) {
options.push({
text: translate('iou.hold'),
icon: Expensicons.Stopwatch,
Expand All @@ -45,7 +46,7 @@ function useSelectedTransactionsActions({report, reportActions, session, onExpor
});
}

if (allTransactionOnHold && selectedTransactions.length === 1) {
if (isMoneyRequestReport && allTransactionOnHold && selectedTransactions.length === 1) {
options.push({
text: translate('iou.unhold'),
icon: Expensicons.Stopwatch,
Expand Down