Skip to content

show empty state when no prohibited expenses are enabled #60731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dangrous merged 1 commit into from
Apr 25, 2025
Merged

show empty state when no prohibited expenses are enabled #60731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4888,7 +4888,6 @@ const translations = {
prohibitedDefaultDescription:
'Flag any receipts where alcohol, gambling, or other restricted items appear. Expenses with receipts where these line items appear will require manual review.',
prohibitedExpenses: 'Prohibited expenses',
none: 'None',
alcohol: 'Alcohol',
hotelIncidentals: 'Hotel incidentals',
gambling: 'Gambling',
Expand Down
1 change: 0 additions & 1 deletion src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4959,7 +4959,6 @@ const translations = {
prohibitedDefaultDescription:
'Marque cualquier recibo donde aparezcan alcohol, apuestas u otros artículos restringidos. Los gastos con recibos que incluyan estos conceptos requerirán una revisión manual.',
prohibitedExpenses: 'Gastos prohibidos',
none: 'Ninguno',
alcohol: 'Alcohol',
hotelIncidentals: 'Gastos incidentales de hotel',
gambling: 'Juegos de azar',
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/rules/IndividualExpenseRulesSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ function IndividualExpenseRulesSection({policyID}: IndividualExpenseRulesSection

// If no expenses are prohibited, return empty string
if (!prohibitedExpensesList.length) {
return translate('workspace.rules.individualExpenseRules.none');
return '';
}

return prohibitedExpensesList.join(', ');
Expand Down