fix: correctly display offline created group members#60716
Conversation
…rt-attributes-on-personal-details-change
f1d1950 to
f2a3c4a
Compare
f2a3c4a to
54a6c78
Compare
…rt-attributes-on-personal-details-change
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppCleanShot.2025-05-05.at.13.42.05.mp4Android: mWeb ChromeCleanShot.2025-05-05.at.13.18.12.mp4iOS: HybridAppCleanShot.2025-05-05.at.13.07.59.mp4iOS: mWeb SafariCleanShot.2025-05-05.at.12.59.04.mp4MacOS: Chrome / SafariCleanShot.2025-05-05.at.12.51.27.mp4MacOS: DesktopCleanShot.2025-05-05.at.13.47.22.mp4 |
|
@TMisiukiewicz is it expected that the user is displayed as Hidden; it's a group with a user I haven't interaction with before : |
…rt-attributes-on-personal-details-change
|
@fedirjh hmm I think it might happen, the user is probably not in your personal details list |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #60602 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊 (1/11)Significant Changes To Duration
Show details
|
Performance Comparison Report 📊 (10/11)Meaningless Changes To Duration (9/10)Show entries
Show details
|
Performance Comparison Report 📊 (11/11)Meaningless Changes To Duration (10/10)Show entries
Show details
|
Performance Comparison Report 📊 (2/11)Meaningless Changes To Duration (1/10)Show entries
Show details
|
Performance Comparison Report 📊 (3/11)Meaningless Changes To Duration (2/10)Show entries
Show details
|
Performance Comparison Report 📊 (4/11)Meaningless Changes To Duration (3/10)Show entries
Show details
|
Performance Comparison Report 📊 (5/11)Meaningless Changes To Duration (4/10)Show entries
Show details
|
Performance Comparison Report 📊 (6/11)Meaningless Changes To Duration (5/10)Show entries
Show details
|
Performance Comparison Report 📊 (7/11)Meaningless Changes To Duration (6/10)Show entries
Show details
|
Performance Comparison Report 📊 (8/11)Meaningless Changes To Duration (7/10)Show entries
Show details
|
Performance Comparison Report 📊 (9/11)Meaningless Changes To Duration (8/10)Show entries
Show details
|
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
|
🥲 did we run this 11 times? Well, looks like the first time it ran with a regression and then ran 10 times without a significant one. I am confused because the run that failed has
|
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.1.40-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.1.40-7 🚀
|

Explanation of Change
Fixed Issues
$ #60602
PROPOSAL:
Tests
Offline tests
n/a
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
iOS: Native
ios.mp4
iOS: mWeb Safari
ios-web.mp4
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov