Skip to content

[No QA] Re-work ESLint ignore in SplitRouter.ts #60699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 1 commit into from
Apr 25, 2025
Merged

[No QA] Re-work ESLint ignore in SplitRouter.ts #60699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/libs/Navigation/AppNavigator/createSplitNavigator/SplitRouter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,8 @@ function adaptStateIfNecessary({state, options: {sidebarScreen, defaultCentralSc
const params = isEmptyObject(copiedParams) ? undefined : copiedParams;

// @ts-expect-error Updating read only property
// noinspection JSConstantReassignment
state.stale = true; // eslint-disable-line
// eslint-disable-next-line no-param-reassign
state.stale = true;

// @ts-expect-error Updating read only property
// Unshift the root screen to fill left pane.
Expand All @@ -78,8 +78,8 @@ function adaptStateIfNecessary({state, options: {sidebarScreen, defaultCentralSc
previousSameNavigatorState?.routes && previousSameNavigatorState.routes.length > 1 ? previousSameNavigatorState.routes.at(-1)?.name : undefined;

// @ts-expect-error Updating read only property
// noinspection JSConstantReassignment
state.stale = true; // eslint-disable-line
// eslint-disable-next-line no-param-reassign
state.stale = true;

// @ts-expect-error Updating read only property
// Push the default settings central pane screen.
Expand All @@ -89,8 +89,10 @@ function adaptStateIfNecessary({state, options: {sidebarScreen, defaultCentralSc
});
}
}
// eslint-disable-next-line no-param-reassign, @typescript-eslint/non-nullable-type-assertion-style
(state.index as number) = state.routes.length - 1;

// @ts-expect-error Updating read only property
// eslint-disable-next-line no-param-reassign
state.index = state.routes.length - 1;
}

function isPushingSidebarOnCentralPane(state: StackState, action: CommonActions.Action | StackActionType, options: SplitNavigatorRouterOptions) {
Expand Down