Skip to content

fix: remove isSuccess state from bank account creation, use api error #60489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
madmax330 merged 11 commits into from
Apr 28, 2025
+6 −6
Merged

fix: remove isSuccess state from bank account creation, use api error #60489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6064e45
fix: remove isSuccess state from bank account creation, use api error
pasyukevich Apr 18, 2025
3c54bee
fix: ensure cleanup function is returned in useEffect for bank info c…
pasyukevich Apr 18, 2025
48bbe4b
Merge branch 'main' into fix/update-to-api-error-bank-account
pasyukevich Apr 18, 2025
617152f
feat: revert isSuccess field
pasyukevich Apr 18, 2025
6d7bd9d
fix prettier
pasyukevich Apr 18, 2025
d740db9
Merge branch 'main' into fix/update-to-api-error-bank-account
pasyukevich Apr 22, 2025
789523c
Fix condition in useEffect to simplify loading checks in BankInfo com…
pasyukevich Apr 23, 2025
3ab2439
Fix submit condition in useEffect for BankInfo component
pasyukevich Apr 23, 2025
6e33238
Reset errors state in createCorpayBankAccount and simplify loading ch…
pasyukevich Apr 24, 2025
b2e5b3f
Remove unused usePrevious hook import in BankInfo component
pasyukevich Apr 24, 2025
2eaa287
Adjust flow checks to improve stability
pasyukevich Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/actions/BankAccounts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,7 @@ function createCorpayBankAccount(fields: ReimbursementAccountForm, policyID: str
value: {
isLoading: false,
isCreateCorpayBankAccount: false,
errors: null,
isSuccess: true,
},
},
Expand All @@ -454,7 +455,6 @@ function createCorpayBankAccount(fields: ReimbursementAccountForm, policyID: str
isLoading: false,
isCreateCorpayBankAccount: false,
isSuccess: false,
errors: getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
},
},
],
Expand Down
10 changes: 5 additions & 5 deletions src/pages/ReimbursementAccount/NonUSD/BankInfo/BankInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,18 +51,18 @@ function BankInfo({onBackButtonPress, onSubmit, policyID}: BankInfoProps) {
};

useEffect(() => {
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
if (reimbursementAccount?.errors || reimbursementAccount?.isLoading || !reimbursementAccount?.isSuccess) {
if (reimbursementAccount?.isLoading === true || !!reimbursementAccount?.errors) {
return;
}

if (reimbursementAccount?.isSuccess) {
if (reimbursementAccount?.isSuccess === true) {
onSubmit();
clearReimbursementAccountBankCreation();
}
}, [onSubmit, reimbursementAccount?.errors, reimbursementAccount?.isLoading, reimbursementAccount?.isSuccess]);

useEffect(() => {
return () => clearReimbursementAccountBankCreation();
}, [onSubmit, reimbursementAccount?.errors, reimbursementAccount?.isCreateCorpayBankAccount, reimbursementAccount?.isLoading, reimbursementAccount?.isSuccess]);
}, []);
Comment on lines +63 to +65

@DylanDylann DylanDylann Apr 25, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pasyukevich Why do we need to split it out to a new useEffect?

@pasyukevich pasyukevich Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've separated it to clean values only on unmount (without connection with the changes inside the dependencies)


useEffect(() => {
if (country === '') {
Expand Down