Skip to content

fix: Reports empty state is blank briefly #59711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luacmartins merged 6 commits into from
Apr 10, 2025
Merged

fix: Reports empty state is blank briefly #59711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68b5c31
fix: Reports empty state is blank briefly
nkdengineer Apr 6, 2025
ccc3735
fix lint
nkdengineer Apr 6, 2025
4af33b4
Merge branch 'main' into fix/59623
nkdengineer Apr 9, 2025
96f8c4e
fix animantion
nkdengineer Apr 9, 2025
e0420fd
Merge branch 'main' into fix/59623
nkdengineer Apr 10, 2025
1275cfa
fix prettier
nkdengineer Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Lottie/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@ function Lottie({source, webStyle, shouldLoadAfterInteractions, ...props}: Props
// eslint-disable-next-line react/jsx-props-no-spreading
{...props}
source={animationFile}
key={`${hasNavigatedAway}`}

@luacmartins luacmartins Apr 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we using a template string? Can we just pass the variable?

@nkdengineer nkdengineer Apr 10, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@luacmartins hasNavigatedAway has type 'boolean' and it is not assignable to type 'Key | null | undefined'.

@luacmartins luacmartins Apr 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying. That looks a bit odd though, maybe we could have used a different key, but I won't block on that

ref={(ref) => {
if (typeof forwardedRef === 'function') {
forwardedRef(ref);
Expand Down
2 changes: 1 addition & 1 deletion src/components/Search/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,7 +405,7 @@ function Search({queryJSON, currentSearchResults, lastNonEmptySearchResults, onS
);
}

if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type) && isFocused) {
if (shouldShowEmptyState(isDataLoaded, data.length, searchResults.search.type)) {
return (
<View style={[shouldUseNarrowLayout ? styles.searchListContentContainerStyles : styles.mt3, styles.flex1]}>
<EmptySearchView
Expand Down