Skip to content

[No QA] Add missing --repo flag for cleanupDeployBlockers to work without a checkout #59591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
grgia merged 2 commits into from
Apr 4, 2025
Merged

[No QA] Add missing --repo flag for cleanupDeployBlockers to work without a checkout #59591

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d026cb4
Add missing --repo flag for it to work without a checkout
roryabraham Apr 3, 2025
91ddb04
Add repo in gh issue edit command as well
roryabraham Apr 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/finishReleaseCycle.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,11 +88,12 @@ jobs:
steps:
- run: |
gh issue list \
--repo 'Expensify/App' \
--state all \
--label DeployBlockerCash \
--json number \

@grgia grgia Apr 3, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB
xargs option:

xargs -n1 -P4 -I{} gh issue edit {} --repo 'Expensify/App' --remove-label DeployBlockerCash

@roryabraham roryabraham Apr 3, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, you are probably right about this, and it should be a blocker 😬

--jq '.[].number' \
| xargs -L1 --max-procs=4 gh issue edit "$1" --remove-label DeployBlockerCash
| xargs -L1 --max-procs=4 gh issue edit "$1" --repo 'Expensify/App' --remove-label DeployBlockerCash
env:
GITHUB_TOKEN: ${{ github.token }}

Expand Down