Skip to content

fix: loading spinner displayed and user stuck after signin #59511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 3 commits into from
Apr 8, 2025
Merged

fix: loading spinner displayed and user stuck after signin #59511

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53d3c4b
fix: loading spinner displayed and user stuck after signin
nkdengineer Apr 2, 2025
853fba6
Merge branch 'main' into fix/59409
nkdengineer Apr 3, 2025
483f4bf
Merge branch 'main' into fix/59409
nkdengineer Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libs/API/parameters/LogOutParams.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ type LogOutParams = {
partnerName: string;
partnerPassword: string;
shouldRetry: boolean;
skipReauthentication?: boolean;
};

export default LogOutParams;
4 changes: 3 additions & 1 deletion src/libs/actions/Session/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import type {
BeginGoogleSignInParams,
BeginSignInParams,
DisableTwoFactorAuthParams,
LogOutParams,
RequestAccountValidationLinkParams,
RequestNewValidateCodeParams,
RequestUnlinkValidationLinkParams,
Expand Down Expand Up @@ -197,13 +198,14 @@ function signInWithSupportAuthToken(authToken: string) {
*/
function signOut(): Promise<void | Response> {
Log.info('Flushing logs before signing out', true, {}, true);
const params = {
const params: LogOutParams = {
// Send current authToken because we will immediately clear it once triggering this command
authToken: NetworkStore.getAuthToken() ?? null,
partnerUserID: credentials?.autoGeneratedLogin ?? '',
partnerName: CONFIG.EXPENSIFY.PARTNER_NAME,
partnerPassword: CONFIG.EXPENSIFY.PARTNER_PASSWORD,
shouldRetry: false,
skipReauthentication: true,
};

// eslint-disable-next-line rulesdir/no-api-side-effects-method
Expand Down