Skip to content

fix: debounce sound for new message #58798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pecanoro merged 3 commits into from
Mar 31, 2025
Merged

fix: debounce sound for new message #58798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
02468e7
fix: debounce sound for new message
daledah Mar 20, 2025
93e40f3
Merge branch 'main' into fix/57961
daledah Mar 31, 2025
b54f849
fix: reduce debounce time and add explain comment
daledah Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1521,6 +1521,7 @@ const CONST = {
LIST_SCROLLING_DEBOUNCE_TIME: 200,
PUSHER_PING_PONG: 'pusher_ping_pong',
LOCATION_UPDATE_INTERVAL: 5000,
PLAY_SOUND_MESSAGE_DEBOUNCE_TIME: 500,
},
PRIORITY_MODE: {
GSD: 'gsd',
Expand Down
13 changes: 12 additions & 1 deletion src/libs/actions/User.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {isBefore} from 'date-fns';
import debounce from 'lodash/debounce';
import type {OnyxCollection, OnyxEntry, OnyxUpdate} from 'react-native-onyx';
import Onyx from 'react-native-onyx';
import type {ValueOf} from 'type-fest';
Expand Down Expand Up @@ -1041,9 +1042,19 @@ function subscribeToUserEvents() {
applyOnyxUpdatesReliably(updates);
});

// Debounce the playSoundForMessageType function to avoid playing sounds too often, for example when a user comeback after offline and alot of messages come in
// See https://github.com/Expensify/App/issues/57961 for more details
const debouncedPlaySoundForMessageType = debounce(

@pecanoro pecanoro Mar 27, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a comment explaining why we need to debounce it?

@pecanoro pecanoro Mar 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daledah Friendly bump!

@daledah daledah Mar 31, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, I updated.

(pushJSONMessage: OnyxServerUpdate[]) => {
playSoundForMessageType(pushJSONMessage);
},
CONST.TIMING.PLAY_SOUND_MESSAGE_DEBOUNCE_TIME,
{trailing: true},
);

// Handles Onyx updates coming from Pusher through the mega multipleEvents.
PusherUtils.subscribeToMultiEvent(Pusher.TYPE.MULTIPLE_EVENT_TYPE.ONYX_API_UPDATE, (pushJSON: OnyxServerUpdate[]) => {
playSoundForMessageType(pushJSON);
debouncedPlaySoundForMessageType(pushJSON);

return SequentialQueue.getCurrentRequest().then(() => {
// If we don't have the currentUserAccountID (user is logged out) or this is not the
Expand Down