Skip to content

[CP Staging] Revert "Fix desktop updates to install the latest one"#58272

Merged
cristipaval merged 1 commit into
mainfrom
revert-57547-fix/54112-app-updates
Mar 12, 2025
Merged

[CP Staging] Revert "Fix desktop updates to install the latest one"#58272
cristipaval merged 1 commit into
mainfrom
revert-57547-fix/54112-app-updates

Conversation

@mountiny

@mountiny mountiny commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

Reverts #57547

Straight revert, we will need to clean this up but we verified it works

@mountiny mountiny requested a review from cristipaval March 12, 2025 10:42
@mountiny mountiny self-assigned this Mar 12, 2025
@mountiny mountiny requested a review from a team as a code owner March 12, 2025 10:42
@melvin-bot melvin-bot Bot removed the request for review from a team March 12, 2025 10:42
@melvin-bot

melvin-bot Bot commented Mar 12, 2025

Copy link
Copy Markdown

@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cristipaval cristipaval merged commit b9629bf into main Mar 12, 2025
@cristipaval cristipaval deleted the revert-57547-fix/54112-app-updates branch March 12, 2025 11:03
@melvin-bot melvin-bot Bot added the Emergency label Mar 12, 2025
@melvin-bot

melvin-bot Bot commented Mar 12, 2025

Copy link
Copy Markdown

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny

mountiny commented Mar 12, 2025

Copy link
Copy Markdown
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Mar 12, 2025
@cristipaval @OSBotify
Merge pull request #58272 from Expensify/revert-57547-fix/54112-app-u…
65501fc 
…pdates

[CP Staging] Revert "Fix desktop updates to install the latest one"

(cherry picked from commit b9629bf)

(CP triggered by mountiny)
@github-actions github-actions Bot added the CP Staging marks PRs that have been CP'd to staging label Mar 12, 2025
@OSBotify

OSBotify commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot mentioned this pull request Mar 12, 2025
Closed
@github-actions

github-actions Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.11-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Mar 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.1.11-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.12-7 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cristipaval cristipaval cristipaval approved these changes

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mountiny @OSBotify @cristipaval