[NO QA]Add a try/catch for build in review error for iOS#5594
Merged
Conversation
Jag96
reviewed
Sep 29, 2021
| if e.message.include? "Another build is in review" | ||
| UI.important("Another build is already in external beta review. Skipping external beta review submission") | ||
| else | ||
| raise |
Contributor
There was a problem hiding this comment.
nab - Can we do something like this instead to remove the if/else?
rescue Exception => e
raise e unless e.message.include? "Another build is in review"
UI.important("Another build is already in external beta review. Skipping external beta review submission")
end
Contributor
Author
There was a problem hiding this comment.
Yes, I think so- Is that valid ruby?
Contributor
There was a problem hiding this comment.
I think that'll work, but I'm fine leaving it simple w/ the if/else since its more straightforward
Jag96
approved these changes
Sep 29, 2021
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
15 tasks
Contributor
Contributor
|
🚀 Deployed to production by @chiragsalian in version: 1.1.4-0 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Adds a try/catch for the error message we were receiving for the iOS errors.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/178492
Tests
QA Steps
N/A